ACPT-490

Fixing static tests

Author: JacobBrownAustin

app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php

@@ -267,6 +267,10 @@ protected function _getProductAttributes($attrSetData)
     /**
      * Initialize attributes parameters for all attributes' sets.
      *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     *
      * @return $this
      */
     protected function _initAttributes()
@@ -311,16 +315,16 @@ protected function _initAttributes()
         $addedAttributes = array_merge(...$addedAttributes);
         $attributesToLoadFromTable = [];
         foreach ($addedAttributes as $addedAttribute) {
-           if (isset($addedAttribute['options_use_table'])) {
+            if (isset($addedAttribute['options_use_table'])) {
                 $attributesToLoadFromTable[] = $addedAttribute['id'];
-               unset(self::$commonAttributesCache[$addedAttribute['id']]['options_use_table']);
+                unset(self::$commonAttributesCache[$addedAttribute['id']]['options_use_table']);
             }
         }
         if (!empty($attributesToLoadFromTable)) {
             $collection = $this->attributeOptionCollectionFactory->create();
             $collection->setAttributeFilter(['in' => $attributesToLoadFromTable]);
             $collection->setStoreFilter(\Magento\Store\Model\Store::DEFAULT_STORE_ID);
-            foreach($collection as $option) {
+            foreach ($collection as $option) {
                 $attributeId = $option->getAttributeId();
                 $value = strtolower($option->getValue());
                 self::$commonAttributesCache[$attributeId]['options'][$value] = $option->getOptionId();
@@ -369,7 +373,7 @@ protected function attachAttributesById($attributeSetName, $attributeIds)
                 ['in' => $this->_forcedAttributesCodes]
             ]
         ) as $attribute) {
-           $this->attachAttribute($attributeSetName, $attribute);
+            $this->attachAttribute($attributeSetName, $attribute);
         }
     }
 
@@ -417,13 +421,14 @@ private function attachAttributesByForcedCodes(string $attributeSetName) : array
     }
 
     /**
-     * Attach Attributes By Id
+     * Attach Attribute to self::$commonAttributesCache or self::$invAttributesCache
      *
      * @param string $attributeSetName
      * @param ProductAttributeInterface $attribute
      * @return array|null
      */
-    private function attachAttribute(string $attributeSetName, ProductAttributeInterface $attribute) {
+    private function attachAttribute(string $attributeSetName, ProductAttributeInterface $attribute)
+    {
         $cachedAttribute = null;
         $attributeCode = $attribute->getAttributeCode();
         $attributeId = $attribute->getId();

app/code/Magento/ImportExport/Model/Import/Entity/AbstractEntity.php

@@ -442,7 +442,7 @@ protected function _saveValidatedBunches()
      * Workaround. Only way to implement dependency and not to break inherited child classes
      *
      * @return Json
-     * @deprecated 100.2.0
+     * @deprecated 100.2.0 It's just a workaround. It was never intended to be used.
      */
     private function getSerializer()
     {