Skip to content

Commit 00e3b5e

Browse files
author
Joan He
committed
MAGETWO-94269: PayPal advanced payments won't process payment due to an incorrect redirect after a silent post
- address code review comments
1 parent 3a8c27f commit 00e3b5e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

app/code/Magento/Paypal/Test/Unit/Controller/Payflow/ReturnUrlTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,8 @@ public function testExecuteAllowedOrderState($state)
200200
->willReturnSelf();
201201

202202
$this->eventManagerMock->expects($this->once())
203-
->method('dispatch');
203+
->method('dispatch')
204+
->with('checkout_success', $this->arrayHasKey('order'));
204205

205206
$result = $this->returnUrl->execute();
206207
$this->assertNull($result);

app/code/Magento/Signifyd/Observer/PlaceOrder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private function createCaseForOrder($order)
8383
$orderId = $order->getEntityId();
8484
if (null === $orderId
8585
|| $order->getPayment()->getMethodInstance()->isOffline()
86-
|| $order->getState() == Order::STATE_PENDING_PAYMENT) {
86+
|| $order->getState() === Order::STATE_PENDING_PAYMENT) {
8787
return;
8888
}
8989

0 commit comments

Comments
 (0)