Skip to content

Commit 007a891

Browse files
committed
DEPRECATED: AbstractAccount for Magento_Customer controllers
1 parent cac512f commit 007a891

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

app/code/Magento/Customer/Controller/AbstractAccount.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
use Magento\Framework\App\Action\Action;
1010

1111
/**
12-
* Class AbstractAccount
13-
* @package Magento\Customer\Controller
1412
* @SuppressWarnings(PHPMD.NumberOfChildren)
13+
* @deprecated 2.4.0
14+
* @see \Magento\Customer\Controller\AccountInterface
1515
*/
1616
abstract class AbstractAccount extends Action implements AccountInterface
1717
{

app/code/Magento/Customer/Controller/Plugin/Account.php

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6+
declare(strict_types=1);
7+
68
namespace Magento\Customer\Controller\Plugin;
79

10+
use Magento\Customer\Controller\AccountInterface;
811
use Magento\Customer\Model\Session;
912
use Magento\Framework\App\ActionInterface;
1013
use Magento\Framework\App\RequestInterface;
1114
use Magento\Framework\App\ResponseInterface;
12-
use Magento\Framework\App\Action\AbstractAction;
1315
use Magento\Framework\Controller\ResultInterface;
1416

1517
class Account
@@ -23,29 +25,35 @@ class Account
2325
* @var array
2426
*/
2527
private $allowedActions = [];
28+
/**
29+
* @var RequestInterface
30+
*/
31+
private $request;
2632

2733
/**
34+
* @param RequestInterface $request
2835
* @param Session $customerSession
2936
* @param array $allowedActions List of actions that are allowed for not authorized users
3037
*/
3138
public function __construct(
39+
RequestInterface $request,
3240
Session $customerSession,
3341
array $allowedActions = []
3442
) {
3543
$this->session = $customerSession;
3644
$this->allowedActions = $allowedActions;
45+
$this->request = $request;
3746
}
3847

3948
/**
4049
* Dispatch actions allowed for not authorized users
4150
*
42-
* @param AbstractAction $subject
43-
* @param RequestInterface $request
51+
* @param AccountInterface $subject
4452
* @return void
4553
*/
46-
public function beforeDispatch(AbstractAction $subject, RequestInterface $request)
54+
public function beforeExecute(AccountInterface $subject)
4755
{
48-
$action = strtolower($request->getActionName());
56+
$action = strtolower($this->request->getActionName());
4957
$pattern = '/^(' . implode('|', $this->allowedActions) . ')$/i';
5058

5159
if (!preg_match($pattern, $action)) {
@@ -60,13 +68,12 @@ public function beforeDispatch(AbstractAction $subject, RequestInterface $reques
6068
/**
6169
* Remove No-referer flag from customer session
6270
*
63-
* @param AbstractAction $subject
71+
* @param AccountInterface $subject
6472
* @param ResponseInterface|ResultInterface $result
65-
* @param RequestInterface $request
6673
* @return ResponseInterface|ResultInterface
6774
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
6875
*/
69-
public function afterDispatch(AbstractAction $subject, $result, RequestInterface $request)
76+
public function afterExecute(AccountInterface $subject, $result)
7077
{
7178
$this->session->unsNoReferer(false);
7279
return $result;

app/code/Magento/Customer/etc/frontend/di.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
</argument>
5252
</arguments>
5353
</type>
54-
<type name="Magento\Customer\Controller\AbstractAccount">
54+
<type name="Magento\Customer\Controller\AccountInterface">
5555
<plugin name="customer_account" type="Magento\Customer\Controller\Plugin\Account" />
5656
</type>
5757
<type name="Magento\Checkout\Block\Cart\Sidebar">

0 commit comments

Comments
 (0)