Skip to content

Commit 0068a8b

Browse files
author
Igor Melnikov
committed
MAGETWO-62134: Create data converter that can process nested serialized data
Resolving code review feedback
1 parent a3cfd27 commit 0068a8b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Creditmemo.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class Creditmemo extends AbstractItems
3333
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
3434
* @param array $data
3535
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
36+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
3637
*/
3738
public function __construct(
3839
\Magento\Framework\Model\Context $context,
@@ -47,7 +48,6 @@ public function __construct(
4748
Json $serializer = null
4849
) {
4950
$this->string = $string;
50-
$serializer = $serializer ?: ObjectManager::getInstance()->get(Json::class);
5151
parent::__construct(
5252
$context,
5353
$registry,

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class Invoice extends AbstractItems
3333
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
3434
* @param array $data
3535
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
36+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
3637
*/
3738
public function __construct(
3839
\Magento\Framework\Model\Context $context,
@@ -46,7 +47,6 @@ public function __construct(
4647
array $data = [],
4748
Json $serializer = null
4849
) {
49-
$serializer = $serializer ?: ObjectManager::getInstance()->get(Json::class);
5050
$this->string = $coreString;
5151
parent::__construct(
5252
$context,

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Shipment.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class Shipment extends AbstractItems
3131
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
3232
* @param array $data
3333
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
34+
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
3435
*/
3536
public function __construct(
3637
\Magento\Framework\Model\Context $context,
@@ -45,7 +46,6 @@ public function __construct(
4546
Json $serializer = null
4647
) {
4748
$this->string = $string;
48-
$serializer = $serializer ?: ObjectManager::getInstance()->get(Json::class);
4949
parent::__construct(
5050
$context,
5151
$registry,

0 commit comments

Comments
 (0)