MAGETWO-34612: Unit tests coverage build failure

- adding tests folders to be checked for obsolete tests

Author: mazhalai

dev/tests/static/testsuite/Magento/Test/Integrity/DependencyTest.php

@@ -427,7 +427,7 @@ public function getAllFiles()
             $files,
             $this->_prepareFiles(
                 'php',
-                \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, true),
+                \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, true, false),
                 true
             )
         );
@@ -489,7 +489,7 @@ protected static function _prepareMapRouters()
         $pattern = '/(?<namespace>[A-Z][a-z]+)[_\/\\\\](?<module>[A-Z][a-zA-Z]+)\/Controller\/' .
             '(?<path>[\/\w]*).php/';
 
-        $files = \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false);
+        $files = \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false, false);
         foreach ($files as $file) {
             if (preg_match($pattern, $file, $matches)) {
                 $module = $matches['namespace'] . '\\' . $matches['module'];

dev/tests/static/testsuite/Magento/Test/Integrity/Layout/BlocksTest.php

@@ -94,7 +94,9 @@ function ($alias, $file) {
     public function getChildBlockDataProvider()
     {
         $result = [];
-        foreach (\Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, true, false) as $file) {
+        foreach (
+            \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, true, false, false) as $file
+        ) {
             $aliases = \Magento\Framework\Test\Utility\Classes::getAllMatches(
                 file_get_contents($file),
                 '/\->getChildBlock\(\'([^\']+)\'\)/x'

dev/tests/static/testsuite/Magento/Test/Integrity/Library/DependencyTest.php

@@ -85,7 +85,7 @@ function ($file) use ($path) {
                     );
                 }
             },
-            $files->getPhpFiles(false, true, false)
+            $files->getPhpFiles(false, true, false, true, false)
         );
     }
 

dev/tests/static/testsuite/Magento/Test/Legacy/TableTest.php

@@ -32,7 +32,7 @@ function ($filePath) {
                 $message = $this->_composeFoundsMessage($legacyTables);
                 $this->assertEmpty($message, $message);
             },
-            \Magento\Framework\Test\Utility\Files::init()->getPhpFiles()
+            \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, true, true, true, false)
         );
     }
 

dev/tools/Magento/Tools/Migration/factory_names.php

@@ -8,7 +8,7 @@
 require realpath(dirname(dirname(dirname(dirname(dirname(__DIR__)))))) . '/dev/tests/static/framework/bootstrap.php';
 
 // PHP code
-foreach (\Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, true, true, false) as $file) {
+foreach (\Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, true, true, false, false) as $file) {
     $content = file_get_contents($file);
     $classes = \Magento\Framework\Test\Utility\Classes::collectPhpCodeClasses($content);
     $factoryNames = array_filter($classes, 'isFactoryName');

dev/tools/Magento/Tools/Migration/factory_table_names.php

@@ -32,7 +32,7 @@
 $tablesAssociation = getFilesCombinedArray(__DIR__ . '/FactoryTableNames', 'replace_*.php');
 $blackList = getFilesCombinedArray(__DIR__ . '/FactoryTableNames', 'blacklist_*.php');
 
-$phpFiles = \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false);
+$phpFiles = \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false, false);
 
 $replacementResult = false;
 if (!$isSearchTables || $isDryRunMode) {

dev/tools/Magento/Tools/Migration/get_aliases_map.php

@@ -39,7 +39,7 @@
 $map = [];
 $compositeModules = getFilesCombinedArray(__DIR__ . '/aliases_map', '/^composite_modules_.*\.php$/');
 // PHP code
-foreach ($utilityFiles->getPhpFiles(true, true, true, false) as $file) {
+foreach ($utilityFiles->getPhpFiles(true, true, true, false, false) as $file) {
     $content = file_get_contents($file);
     $classes = \Magento\Framework\Test\Utility\Classes::collectPhpCodeClasses($content);
     if ($classes) {

lib/internal/Magento/Framework/Test/Utility/Classes.php

@@ -189,7 +189,9 @@ public static function collectModuleClasses($subTypePattern = '[A-Za-z]+')
             '/'
         ) . '\/app\/code\/([A-Za-z]+)\/([A-Za-z]+)\/(' . $subTypePattern . '\/.+)\.php$/';
         $result = [];
-        foreach (\Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false) as $file) {
+        foreach (
+            \Magento\Framework\Test\Utility\Files::init()->getPhpFiles(true, false, false, false, false) as $file
+        ) {
             if (preg_match($pattern, $file, $matches)) {
                 $module = "{$matches[1]}_{$matches[2]}";
                 $class = "{$module}" . '\\' . str_replace(

lib/internal/Magento/Framework/Test/Utility/Files.php

@@ -100,9 +100,10 @@ public function getPathToSource()
      * @param bool $otherCode non-application PHP-code (doesn't include "dev" directory)
      * @param bool $templates application PHTML-code
      * @param bool $asDataSet
+     * @param bool $tests tests folder
      * @return array
      */
-    public function getPhpFiles($appCode = true, $otherCode = true, $templates = true, $asDataSet = true)
+    public function getPhpFiles($appCode = true, $otherCode = true, $templates = true, $asDataSet = true, $tests = true)
     {
         $key = __METHOD__ . "/{$this->_path}/{$appCode}/{$otherCode}/{$templates}";
         if (!isset(self::$_cache[$key])) {
@@ -124,6 +125,12 @@ public function getPhpFiles($appCode = true, $otherCode = true, $templates = tru
                     self::getFiles(["{$this->_path}/dev/tools/Magento/Tools/SampleData"], '*.php')
                 );
             }
+            if ($tests) {
+                $files = array_merge(
+                    $files,
+                    self::getFiles(["{$this->_path}/dev/tests"], '*.php')
+                );
+            }
             if ($templates) {
                 $files = array_merge($files, $this->getPhtmlFiles(false, false));
             }