Skip to content

Commit fcef955

Browse files
committed
MC-2214: Implement Design Change
- Split up content type specific converters for margins and padding - Updated configuration for all components to stop using composite converters and readers - Delete composite converters and readers - Update documentation
1 parent ba3a657 commit fcef955

File tree

36 files changed

+310
-328
lines changed

36 files changed

+310
-328
lines changed

app/code/Magento/PageBuilder/docs/how-to-add-new-content-type.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ To add configuration for a new content type, create a file under the following l
7272
<property name="border_color" source="border_color" converter="Magento_PageBuilder/js/converter/style/color"/>
7373
<property name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
7474
<property name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
75-
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins-and-paddings" converter="Magento_PageBuilder/js/converter/style/margins-and-paddings"/>
76-
</style_properties>
75+
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
76+
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/> </style_properties>
7777
<attributes>
7878
<attribute name="name" source="data-role"/>
7979
</attributes>
@@ -273,7 +273,8 @@ Now, let's add content type that can contain other content types. Create configu
273273
<property name="border_color" source="border_color" converter="Magento_PageBuilder/js/converter/style/color"/>
274274
<property name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
275275
<property name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
276-
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins-and-paddings" converter="Magento_PageBuilder/js/converter/style/margins-and-paddings"/>
276+
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
277+
<complex_property name="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
277278
</style_properties>
278279
<attributes>
279280
<attribute name="name" source="data-role"/>
Lines changed: 7 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/row/converter/style/paddings.js

Lines changed: 53 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slide/converter/style/margins.js

Lines changed: 66 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 11 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/converter/style/margins-and-paddings.js

Lines changed: 0 additions & 84 deletions
This file was deleted.

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/margins-and-paddings.js

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)