Skip to content

Commit fb5fa8c

Browse files
dhaeckerdhaecker
committed
MC-3228: Add Missing P0-P1 MFTF Tests For Slider
- Adding more coverage for slides for inline editing content - Adding supporting action group
1 parent e143b92 commit fb5fa8c

6 files changed

+414
-7
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeSliderActionGroup.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,7 @@
4242
<waitForPageLoad stepKey="waitForAnimation" time="30"/>
4343
<waitForElementNotVisible selector="{{SlideOnBackend.optionTitle}}" stepKey="dontSeeSlideOptionsEdit"/>
4444
</actionGroup>
45+
<actionGroup name="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" extends="inlineEditWYSIWYGFromStage">
46+
<click selector="{{SlideOnBackend.base(index)}}" stepKey="focusOnEditorArea"/>
47+
</actionGroup>
4548
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 98 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<features value="PageBuilder"/>
1414
<stories value="Slider"/>
1515
<title value="Collage Center - Can Inline Edit Slide Content"/>
16-
<description value="Verify that users are able to inline edit a collage center Slide's content from the stage"/>
16+
<description value="Verify that users are able to inline edit a collage center slide's content from the stage"/>
1717
<severity value="MAJOR"/>
1818
<useCaseId value="MC-937"/>
1919
<testCaseId value="MC-3849"/>
@@ -26,6 +26,102 @@
2626
</actionGroup>
2727
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
2828
</test>
29+
<test name="SlideItemCollageCenterWYSIWYGDisabledInlineEdit" extends="SlideItemPosterCanInlineEditContent">
30+
<annotations>
31+
<features value="PageBuilder"/>
32+
<stories value="Slider"/>
33+
<title value="Collage Center - Inline Edit With WYSIWYG Disabled"/>
34+
<description value="Verify that a user can inline edit slide collage center content when WYSIWYG is disabled"/>
35+
<severity value="MAJOR"/>
36+
<useCaseId value="MC-3228"/>
37+
<testCaseId value="MC-3980"/>
38+
<group value="pagebuilder"/>
39+
<group value="pagebuilder-slide"/>
40+
<group value="pagebuilder-slideItemCollageCenter"/>
41+
</annotations>
42+
<before>
43+
<remove keyForRemoval="enableWYSIWYG"/>
44+
<remove keyForRemoval="enableTinyMCE4"/>
45+
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG" before="loginAsAdmin"/>
46+
</before>
47+
<after>
48+
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
49+
</after>
50+
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
51+
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
52+
</actionGroup>
53+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
54+
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
55+
<argument name="contentType" value="PageBuilderSliderContentType"/>
56+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
57+
</actionGroup>
58+
<executeJS function="return document.querySelector('{{SlideOnConfigurationPanel.textArea}}').value" stepKey="seeMessageText"/>
59+
<assertEquals stepKey="assertTextAreaValueEditPanel" after="seeMessageText">
60+
<expectedResult type="string">{{PageBuilderSlideItemContent_Slide1.value}}</expectedResult>
61+
<actualResult type="variable">seeMessageText</actualResult>
62+
</assertEquals>
63+
<actionGroup ref="assertTextareaContainsValue" stepKey="seeMessageContentStage">
64+
<argument name="selector" value="{{PageBuilderStage.inlineTextAreaEditor(PageBuilderSlideContentType.role, '1')}}"/>
65+
<argument name="value" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
66+
</actionGroup>
67+
<seeElement selector="{{SlideOnFrontend.messageContentTextArea('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeMessageContentStorefront"/>
68+
</test>
69+
<test name="SlideItemCollageCenterTinyMCE3InlineEdit" extends="SlideItemPosterCanInlineEditContent">
70+
<annotations>
71+
<features value="PageBuilder"/>
72+
<stories value="Slider"/>
73+
<title value="Collage Center - Inline Edit With TinyMCE3 Enabled"/>
74+
<description value="Verify that a user can inline edit slide collage center content when TinyMCE3 is enabled"/>
75+
<severity value="MAJOR"/>
76+
<useCaseId value="MC-3228"/>
77+
<testCaseId value="MC-3973"/>
78+
<group value="pagebuilder"/>
79+
<group value="pagebuilder-slide"/>
80+
<group value="pagebuilder-slideItemCollageCenter"/>
81+
</annotations>
82+
<before>
83+
<remove keyForRemoval="enableTinyMCE4"/>
84+
<magentoCLI command="config:set cms/wysiwyg/editor Magento_Tinymce3/tinymce3Adapter" stepKey="enableTinyMCE3" before="loginAsAdmin"/>
85+
</before>
86+
<after>
87+
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4" before="logout"/>
88+
</after>
89+
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
90+
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
91+
</actionGroup>
92+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
93+
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
94+
<argument name="contentType" value="PageBuilderSliderContentType"/>
95+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
96+
</actionGroup>
97+
<actionGroup ref="assertTextareaContainsValue" stepKey="seeMessageContentStage">
98+
<argument name="selector" value="{{PageBuilderStage.inlineTextAreaEditor(PageBuilderSlideContentType.role, '1')}}"/>
99+
<argument name="value" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
100+
</actionGroup>
101+
<seeElement selector="{{SlideOnFrontend.messageContentTextArea('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeMessageContentStorefront"/>
102+
</test>
103+
<test name="SlideItemCollageCenterCanInlineEditContentWhenIn25PercentWidthColumn" extends="SlideItemPosterCanInlineEditContentWhenIn25PercentWidthColumn">
104+
<annotations>
105+
<features value="PageBuilder"/>
106+
<stories value="Slider"/>
107+
<title value="Collage Center - Can Inline Edit Slide Content When In Small Column"/>
108+
<description value="Verify that users are able to inline edit a collage center slide's content from the stage when the slide is in a 25 percent width column"/>
109+
<severity value="AVERAGE"/>
110+
<useCaseId value="MC-3228"/>
111+
<testCaseId value="MC-3977"/>
112+
<group value="pagebuilder"/>
113+
<group value="pagebuilder-slide"/>
114+
<group value="pagebuilder-slideItemCollageCenter"/>
115+
</annotations>
116+
<actionGroup ref="chooseVisualSelectOption" after="dragContentTypeIntoContainer2" stepKey="enterAppearancePropertyExtended">
117+
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
118+
</actionGroup>
119+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
120+
<actionGroup ref="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" stepKey="inlineEdit">
121+
<argument name="contentType" value="PageBuilderSlideContentType"/>
122+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
123+
</actionGroup>
124+
</test>
29125
<test name="SlideCollageCenteredMobileWithMobileImageValues">
30126
<annotations>
31127
<features value="PageBuilder"/>
@@ -345,7 +441,7 @@
345441
<title value="Slide Collage Center - Update All Attributes"/>
346442
<description value="A user should be able to add a collage center slide with all attribute fields filled."/>
347443
<severity value="CRITICAL"/>
348-
<useCaseId value="MC-3230"/>
444+
<useCaseId value="MC-3228"/>
349445
<testCaseId value="MC-2770"/>
350446
<group value="pagebuilder"/>
351447
<group value="pagebuilder-slide"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 97 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,102 @@
2626
</actionGroup>
2727
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
2828
</test>
29+
<test name="SlideItemCollageLeftWYSIWYGDisabledInlineEdit" extends="SlideItemPosterCanInlineEditContent">
30+
<annotations>
31+
<features value="PageBuilder"/>
32+
<stories value="Slider"/>
33+
<title value="Collage Left - Inline Edit With WYSIWYG Disabled"/>
34+
<description value="Verify that a user can inline edit slide collage left content when WYSIWYG is disabled"/>
35+
<severity value="MAJOR"/>
36+
<useCaseId value="MC-3228"/>
37+
<testCaseId value="MC-3981"/>
38+
<group value="pagebuilder"/>
39+
<group value="pagebuilder-slide"/>
40+
<group value="pagebuilder-slideItemCollageLeft"/>
41+
</annotations>
42+
<before>
43+
<remove keyForRemoval="enableWYSIWYG"/>
44+
<remove keyForRemoval="enableTinyMCE4"/>
45+
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG" before="loginAsAdmin"/>
46+
</before>
47+
<after>
48+
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG" before="logout"/>
49+
</after>
50+
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
51+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
52+
</actionGroup>
53+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
54+
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
55+
<argument name="contentType" value="PageBuilderSliderContentType"/>
56+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
57+
</actionGroup>
58+
<executeJS function="return document.querySelector('{{SlideOnConfigurationPanel.textArea}}').value" stepKey="seeMessageText"/>
59+
<assertEquals stepKey="assertTextAreaValueEditPanel" after="seeMessageText">
60+
<expectedResult type="string">{{PageBuilderSlideItemContent_Slide1.value}}</expectedResult>
61+
<actualResult type="variable">seeMessageText</actualResult>
62+
</assertEquals>
63+
<actionGroup ref="assertTextareaContainsValue" stepKey="seeMessageContentStage">
64+
<argument name="selector" value="{{PageBuilderStage.inlineTextAreaEditor(PageBuilderSlideContentType.role, '1')}}"/>
65+
<argument name="value" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
66+
</actionGroup>
67+
<seeElement selector="{{SlideOnFrontend.messageContentTextArea('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeMessageContentStorefront"/>
68+
</test>
69+
<test name="SlideItemCollageLeftTinyMCE3InlineEdit" extends="SlideItemPosterCanInlineEditContent">
70+
<annotations>
71+
<features value="PageBuilder"/>
72+
<stories value="Slider"/>
73+
<title value="Collage Left - Inline Edit With TinyMCE3 Enabled"/>
74+
<description value="Verify that a user can inline edit slide collage left content when TinyMCE3 is enabled"/>
75+
<severity value="MAJOR"/>
76+
<useCaseId value="MC-3228"/>
77+
<testCaseId value="MC-3974"/>
78+
<group value="pagebuilder"/>
79+
<group value="pagebuilder-slide"/>
80+
<group value="pagebuilder-slideItemCollageLeft"/>
81+
</annotations>
82+
<before>
83+
<remove keyForRemoval="enableTinyMCE4"/>
84+
<magentoCLI command="config:set cms/wysiwyg/editor Magento_Tinymce3/tinymce3Adapter" stepKey="enableTinyMCE3" before="loginAsAdmin"/>
85+
</before>
86+
<after>
87+
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4" before="logout"/>
88+
</after>
89+
<actionGroup ref="chooseVisualSelectOption" after="dragSliderIntoStage" stepKey="enterAppearancePropertyExtended">
90+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
91+
</actionGroup>
92+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
93+
<actionGroup ref="inlineEditTextAreaFromStage" stepKey="inlineEdit">
94+
<argument name="contentType" value="PageBuilderSliderContentType"/>
95+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
96+
</actionGroup>
97+
<actionGroup ref="assertTextareaContainsValue" stepKey="seeMessageContentStage">
98+
<argument name="selector" value="{{PageBuilderStage.inlineTextAreaEditor(PageBuilderSlideContentType.role, '1')}}"/>
99+
<argument name="value" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
100+
</actionGroup>
101+
<seeElement selector="{{SlideOnFrontend.messageContentTextArea('1', PageBuilderSlideItemContent_Slide1.value)}}" stepKey="seeMessageContentStorefront"/>
102+
</test>
103+
<test name="SlideItemCollageLeftCanInlineEditContentWhenIn25PercentWidthColumn" extends="SlideItemPosterCanInlineEditContentWhenIn25PercentWidthColumn">
104+
<annotations>
105+
<features value="PageBuilder"/>
106+
<stories value="Slider"/>
107+
<title value="Collage Left - Can Inline Edit Slide Content When In Small Column"/>
108+
<description value="Verify that users are able to inline edit a collage left slide's content from the stage when the slide is in a 25 percent width column"/>
109+
<severity value="AVERAGE"/>
110+
<useCaseId value="MC-3228"/>
111+
<testCaseId value="MC-3978"/>
112+
<group value="pagebuilder"/>
113+
<group value="pagebuilder-slide"/>
114+
<group value="pagebuilder-slideItemCollageLeft"/>
115+
</annotations>
116+
<actionGroup ref="chooseVisualSelectOption" after="dragContentTypeIntoContainer2" stepKey="enterAppearancePropertyExtended">
117+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
118+
</actionGroup>
119+
<actionGroup ref="saveEditPanelSettings" stepKey="closeEditPanelSettings"/>
120+
<actionGroup ref="inlineEditWYSIWYGFromStageForSlideCollageAppearancesInSmallColumns" stepKey="inlineEdit">
121+
<argument name="contentType" value="PageBuilderSlideContentType"/>
122+
<argument name="content" value="{{PageBuilderSlideItemContent_Slide1.value}}"/>
123+
</actionGroup>
124+
</test>
29125
<test name="SlideCollageLeftMobileWithMobileImageValues" extends="SlideCollageCenteredMobileWithMobileImageValues">
30126
<annotations>
31127
<features value="PageBuilder"/>
@@ -225,7 +321,7 @@
225321
<title value="Slide Collage Left - Update All Attributes"/>
226322
<description value="A user should be able to add a collage left slide with all attribute fields filled."/>
227323
<severity value="CRITICAL"/>
228-
<useCaseId value="MC-3230"/>
324+
<useCaseId value="MC-3228"/>
229325
<testCaseId value="MC-2535"/>
230326
<group value="pagebuilder"/>
231327
<group value="pagebuilder-slide"/>

0 commit comments

Comments
 (0)