Skip to content

Commit fa63d8e

Browse files
author
Hwashiang Yu
committed
MC-4150: Widget placeholder and variable placeholder styling is broken on inline editing
- Updated less nesting
1 parent ffc5e1b commit fa63d8e

File tree

1 file changed

+29
-25
lines changed

1 file changed

+29
-25
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_typography.less

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ body {
167167
background: @placeholder-background;
168168
box-sizing: initial;
169169
color: @color-black;
170-
cursor: pointer !important;
170+
cursor: pointer;
171171
display: inline-block;
172172
font-size: 14px;
173173
font-style: normal;
@@ -184,36 +184,40 @@ body {
184184
display: inline-block;
185185
height: 20px;
186186
margin: 0 5px;
187-
outline: 2px solid @placeholder-error-outline !important;
187+
outline: 2px solid @placeholder-error-outline;
188188
padding: 2px 4px;
189189
vertical-align: bottom;
190-
}
191190

192-
.magento-placeholder-error:before {
193-
background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABWUlEQVR42qVTS07DMBD1pggqcQAQEofINbrNvh977Au04gJtxZYiVZwLJJasAhJJ3LBrI4Xwxm3SKErCz9Koqec9e/xmnhBYdjK5tlo/R8ZsI63XIdGFqK1QSg+5MNY6scbMXobDU5eIpbyKiaZIpLExOX4/cdg6IOoXZP6OlbpDPjtgUks0y4l6An8esbl1iUPghgyA5ZPvnzAo0XphC/IRkyZKKVEnl8GVEK04+LsRY8yb4HJbAVpnLprJmVVqIcLx+DIieqiX2Bl8ITQB93wv0mDQb3pnGxkXLqsiu8WCufd2H5KBfM/Yepv/d0Du+2c/fQJjIilvyyfwhLEgvxHR7itZORFjHs82clcbuRNazwXm/uOvg4RKAoFSbkofVMjJN6MMzG5DNBI5XAVDTeG0XaE0a9JpJviADejM5LrgeT1UMsJmAOC8nLCqnbG3QQ6Y13ciWbTyC+DUOUqNY1A2AAAAAElFTkSuQmCC);
194-
background-position-x: 1px;
195-
background-position-y: 1px;
196-
background-repeat: no-repeat;
197-
content: '';
198-
display: inline-block;
199-
height: inherit;
200-
margin-right: 4px;
201-
vertical-align: middle;
202-
width: 20px;
191+
img {
192+
display: none;
193+
}
194+
195+
&:before {
196+
background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABWUlEQVR42qVTS07DMBD1pggqcQAQEofINbrNvh977Au04gJtxZYiVZwLJJasAhJJ3LBrI4Xwxm3SKErCz9Koqec9e/xmnhBYdjK5tlo/R8ZsI63XIdGFqK1QSg+5MNY6scbMXobDU5eIpbyKiaZIpLExOX4/cdg6IOoXZP6OlbpDPjtgUks0y4l6An8esbl1iUPghgyA5ZPvnzAo0XphC/IRkyZKKVEnl8GVEK04+LsRY8yb4HJbAVpnLprJmVVqIcLx+DIieqiX2Bl8ITQB93wv0mDQb3pnGxkXLqsiu8WCufd2H5KBfM/Yepv/d0Du+2c/fQJjIilvyyfwhLEgvxHR7itZORFjHs82clcbuRNazwXm/uOvg4RKAoFSbkofVMjJN6MMzG5DNBI5XAVDTeG0XaE0a9JpJviADejM5LrgeT1UMsJmAOC8nLCqnbG3QQ6Y13ciWbTyC+DUOUqNY1A2AAAAAElFTkSuQmCC);
197+
background-position-x: 1px;
198+
background-position-y: 1px;
199+
background-repeat: no-repeat;
200+
content: '';
201+
display: inline-block;
202+
height: inherit;
203+
margin-right: 4px;
204+
vertical-align: middle;
205+
width: 20px;
206+
}
207+
208+
&[data-mce-selected] {
209+
outline: 2px solid @placeholder-error-outline-mce;
210+
}
203211
}
204212

205-
.magento-placeholder-error img {
206-
display: none;
207-
}
208213

209-
.magento-placeholder-error[data-mce-selected] {
210-
outline: 2px solid @placeholder-error-outline-mce !important;
211-
}
212214

213-
.magento-placeholder-error img,
214-
.magento-placeholder img {
215-
margin-right: 5px;
216-
max-height: 20px;
217-
vertical-align: middle;
215+
.magento-placeholder-error,
216+
.magento-placeholder {
217+
img {
218+
margin-right: 5px;
219+
max-height: 20px;
220+
vertical-align: middle;
221+
}
218222
}
219223
}

0 commit comments

Comments
 (0)