Skip to content

Commit f8c98fb

Browse files
author
Hwashiang Yu
committed
MC-4323: Cannot Add Slider WYSIWYG Image From Gallery or Link to Image in Gallery After Page Has Been Saved
- Reverted action group
1 parent b646d9b commit f8c98fb

File tree

4 files changed

+8
-27
lines changed

4 files changed

+8
-27
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup.xml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -161,23 +161,4 @@
161161
<actualResult type="variable">textareaValue</actualResult>
162162
</assertEquals>
163163
</actionGroup>
164-
<actionGroup name="openMediaGalleryFromTinyMCEInlineEditor">
165-
<arguments>
166-
<argument name="contentType"/>
167-
<argument name="index" type="string" defaultValue="1"/>
168-
</arguments>
169-
<click selector="{{PageBuilderStage.inlineWYSIWYGEditor(contentType.role, index)}}" stepKey="focusOnEditorArea"/>
170-
<waitForPageLoad stepKey="waitForInlineWYSIWYGEditor"/>
171-
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelector}}" stepKey="clickWYSIWYGImageSelector"/>
172-
<waitForPageLoad stepKey="waitForImageSelectorModal"/>
173-
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelectorBrowse}}" stepKey="clickWYSIWYGImageSelectorBrowseButton"/>
174-
<waitForPageLoad stepKey="waitForImageSelectorBrowseModal"/>
175-
</actionGroup>
176-
<actionGroup name="openMediaGalleryFromCustomTinyMCEInlineEditor">
177-
<waitForPageLoad stepKey="waitForInlineWYSIWYGEditor"/>
178-
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelector}}" stepKey="clickWYSIWYGImageSelector"/>
179-
<waitForPageLoad stepKey="waitForImageSelectorModal"/>
180-
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelectorBrowse}}" stepKey="clickWYSIWYGImageSelectorBrowseButton"/>
181-
<waitForPageLoad stepKey="waitForImageSelectorBrowseModal"/>
182-
</actionGroup>
183164
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2255,9 +2255,7 @@
22552255
<comment userInput="Removed closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
22562256
<!-- Add Image to Banner -->
22572257
<comment userInput="Add Image to Banner" stepKey="commentAddImageToContentType"/>
2258-
<actionGroup ref="openMediaGalleryFromTinyMCEInlineEditor" stepKey="openMediaGalleryFromTinyMCEInlineEditor">
2259-
<argument name="contentType" value="PageBuilderBannerContentType"/>
2260-
</actionGroup>
2258+
<click selector="{{PageBuilderStage.inlineWYSIWYGEditor(PageBuilderBannerContentType.role, '1')}}" stepKey="focusOnEditorArea"/>
22612259
<!-- Validated Backend -->
22622260
<seeElement selector="{{BannerOnBackend.inlineWYSIWYGEditorWithTag('1', 'img')}}" stepKey="validateImageInEditor"/>
22632261
<!-- Validated Backend After Save -->

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,9 +1756,12 @@
17561756
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
17571757
<!-- Add Image to Slide -->
17581758
<comment userInput="Add Image to Slide" stepKey="commentAddImageToContentType"/>
1759-
<actionGroup ref="openMediaGalleryFromTinyMCEInlineEditor" stepKey="openMediaGalleryFromTinyMCEInlineEditor">
1760-
<argument name="contentType" value="PageBuilderSlideContentType"/>
1761-
</actionGroup>
1759+
<click selector="{{PageBuilderStage.inlineWYSIWYGEditor(PageBuilderSlideContentType.role, '1')}}" stepKey="focusOnEditorArea"/>
1760+
<waitForPageLoad stepKey="waitForInlineWYSIWYGEditor"/>
1761+
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelector}}" stepKey="clickWYSIWYGImageSelector"/>
1762+
<waitForPageLoad stepKey="waitForImageSelectorModal"/>
1763+
<click selector="{{WYSIWYGOnPageBuilderInline.imageSelectorBrowse}}" stepKey="clickWYSIWYGImageSelectorBrowseButton"/>
1764+
<waitForPageLoad stepKey="waitForImageSelectorBrowseModal"/>
17621765
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="NavigateToWYSIWYGFolderActionGroup">
17631766
<argument name="FolderName" value="{{PageBuilderBackgroundImage_JPG.path}}"/>
17641767
</actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2421,8 +2421,7 @@
24212421
<comment userInput="Removed closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
24222422
<!-- Add Image to Text -->
24232423
<comment userInput="Add Image to Text" stepKey="commentAddImageToContentType"/>
2424-
<click selector="{{TextOnStage.tinymce('1')}}" stepKey="focusOnEditorArea" after="commentAddImageToContentType"/>
2425-
<actionGroup ref="openMediaGalleryFromCustomTinyMCEInlineEditor" stepKey="openMediaGalleryFromTinyMCEInlineEditor"/>
2424+
<click selector="{{TextOnStage.tinymce('1')}}" stepKey="focusOnEditorArea"/>
24262425
<!-- Validated Backend -->
24272426
<seeElement selector="{{TextOnStage.inlineWYSIWYGEditorWithTag('1', 'img')}}" stepKey="validateImageInEditor"/>
24282427
<!-- Validated Backend After Save -->

0 commit comments

Comments
 (0)