Skip to content

Commit f7cb469

Browse files
committed
MC-4254: Text Height Inconsistency On Stage & Storefront
- tweak test
1 parent 15f8a1c commit f7cb469

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,15 @@
112112
<waitForPageLoad stepKey="waitForPageLoad"/>
113113
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="loseFocusFromEditor"/>
114114
</actionGroup>
115+
<actionGroup name="inlineEditTextWYSIWYGFromStage">
116+
<arguments>
117+
<argument name="content" type="string"/>
118+
<argument name="index" defaultValue="1" type="string"/>
119+
</arguments>
120+
<click selector="{{TextOnStage.tinymce(index)}}" stepKey="focusOnEditorArea"/>
121+
<pressKey selector="{{TextOnStage.tinymce(index)}}" userInput="{{content}}" stepKey="fillTextToTinyMCE4"/>
122+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="loseFocusFromEditor"/>
123+
</actionGroup>
115124
<actionGroup name="inlineEditTextAreaFromStage">
116125
<arguments>
117126
<argument name="contentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2640,21 +2640,21 @@
26402640
</actionGroup>
26412641
<!--Input text into stage-->
26422642
<comment userInput="Input text into stage" stepKey="commentInputTextIntoStage"/>
2643-
<click selector="{{TextOnStage.tinymce('1')}}" stepKey="focusOnEditorArea"/>
2644-
<pressKey selector="{{TextOnStage.tinymce('1')}}" userInput="{{PageBuilderTextProperty.value}}" stepKey="fillTextToTinyMCE4"/>
2645-
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="lostFocusFromWYSIWYG1"/>
2643+
<actionGroup ref="inlineEditTextWYSIWYGFromStage" stepKey="inlineEdit">
2644+
<argument name="content" value="{{PageBuilderTextProperty.value}}"/>
2645+
</actionGroup>
26462646
<executeJS function="return document.evaluate(&quot;{{TextOnStage.base('1'))}}&quot;, document.body).iterateNext().offsetHeight;" stepKey="getTextOnStageHeight"/>
26472647
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
2648-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
26492648
<!--Get storefront information-->
26502649
<comment userInput="Get storefront information" stepKey="commentGetStorefrontInformation"/>
26512650
<amOnPage url="$$createCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
26522651
<waitForPageLoad stepKey="waitForStorefront"/>
26532652
<waitForElement selector="{{TextOnStorefront.base('1')}}" stepKey="waitForTextOnStorefront"/>
26542653
<executeJS function="return document.evaluate(&quot;{{TextOnStorefront.base('1'))}}&quot;, document.body).iterateNext().offsetHeight;" stepKey="getTextOnStorefrontHeight"/>
2655-
<executeJS function="return Math.abs({$getTextOnStageHeight} - ${getTextOnStorefrontHeight}) &lt;= 2" stepKey="getStageAndStorefrontHeightDifference"/>
2656-
<assertTrue stepKey="assertStageAndStorefrontHeightAreClose">
2654+
<executeJS function="return Math.abs({$getTextOnStageHeight} - {$getTextOnStorefrontHeight})" stepKey="getStageAndStorefrontHeightDifference"/>
2655+
<assertLessThanOrEqual stepKey="assertStageAndStorefrontHeightAreClose">
2656+
<expectedResult type="int">2</expectedResult>
26572657
<actualResult type="variable">getStageAndStorefrontHeightDifference</actualResult>
2658-
</assertTrue>
2658+
</assertLessThanOrEqual>
26592659
</test>
26602660
</tests>

0 commit comments

Comments
 (0)