Skip to content

Commit f773fa9

Browse files
author
Hwashiang Yu
committed
MC-13925: Hard Coded Margins On individual Button
- Added test coverge for default button item margin
1 parent 14a1424 commit f773fa9

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonItemTests.xml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -650,6 +650,13 @@
650650
<seeElement selector="{{ButtonItemOnStage.noBorderWidth('1')}}" stepKey="seeNoBorderWidthStage"/>
651651
<seeElement selector="{{ButtonItemOnStage.noBorderRadius('1')}}" stepKey="seeNoBorderRadiusStage"/>
652652
<seeElement selector="{{ButtonItemOnStage.noMargins('1')}}" stepKey="seeNoMarginsStage"/>
653+
<!-- Validate default margin -->
654+
<comment userInput="Validate default margin" stepKey="commentDefaultMarginStage"/>
655+
<executeJS function="return window.getComputedStyle({{ButtonItemOnStage.jsButtonSelector('1')}}).margin" stepKey="getDefaultMarginValueStage"/>
656+
<assertEquals stepKey="checkDefaultMarginValueStage">
657+
<expectedResult type="string">0px 10px 10px 0px</expectedResult>
658+
<actualResult type="variable">getDefaultMarginValueStage</actualResult>
659+
</assertEquals>
653660
<seeElement selector="{{ButtonItemOnStage.noPadding('1')}}" stepKey="seeNoPaddingStage"/>
654661
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
655662
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
@@ -661,6 +668,13 @@
661668
<seeElement selector="{{ButtonItemOnStage.noBorderWidth('1')}}" stepKey="seeNoBorderWidthStage2"/>
662669
<seeElement selector="{{ButtonItemOnStage.noBorderRadius('1')}}" stepKey="seeNoBorderRadiusStage2"/>
663670
<seeElement selector="{{ButtonItemOnStage.noMargins('1')}}" stepKey="seeNoMarginsStage2"/>
671+
<!-- Validate default margin After Save -->
672+
<comment userInput="Validate default margin After Save" stepKey="commentDefaultMarginStage2"/>
673+
<executeJS function="return window.getComputedStyle({{ButtonItemOnStage.jsButtonSelector('1')}}).margin" stepKey="getDefaultMarginValueStage2"/>
674+
<assertEquals stepKey="checkDefaultMarginValueStage2">
675+
<expectedResult type="string">0px 10px 10px 0px</expectedResult>
676+
<actualResult type="variable">getDefaultMarginValueStage2</actualResult>
677+
</assertEquals>
664678
<seeElement selector="{{ButtonItemOnStage.noPadding('1')}}" stepKey="seeNoPaddingStage2"/>
665679
<!-- Validate Edit Panel After Save -->
666680
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
@@ -703,6 +717,13 @@
703717
<seeElement selector="{{ButtonItemOnStorefrontEmptyLink.noBorderWidth('1')}}" stepKey="seeNoBorderWidthStorefront"/>
704718
<seeElement selector="{{ButtonItemOnStorefrontEmptyLink.noBorderRadius('1')}}" stepKey="seeNoBorderRadiusStorefront"/>
705719
<seeElement selector="{{ButtonItemOnStorefrontEmptyLink.noMargins('1')}}" stepKey="seeNoMarginsStorefront"/>
720+
<!-- Validate default margin Storefront -->
721+
<comment userInput="Validate default margin Storefront" stepKey="commentDefaultMarginStorefront"/>
722+
<executeJS function="return window.getComputedStyle({{ButtonItemOnStorefrontEmptyLink.jsButtonSelector('1')}}).margin" stepKey="getDefaultMarginValueStorefront"/>
723+
<assertEquals stepKey="checkDefaultMarginValueStorefront">
724+
<expectedResult type="string">0px 10px 10px 0px</expectedResult>
725+
<actualResult type="variable">getDefaultMarginValueStorefront</actualResult>
726+
</assertEquals>
706727
<seeElement selector="{{ButtonItemOnStorefrontEmptyLink.noPadding('1')}}" stepKey="seeNoPaddingStorefront"/>
707728
</test>
708729
<test name="ButtonItemUpdateAdvancedConfigurationValues">

0 commit comments

Comments
 (0)