Skip to content

Commit f770475

Browse files
committed
Merge remote-tracking branch 'origin/558_7_content-type-style-attribute-removal' into 558_7_content-type-style-attribute-removal
2 parents 95be745 + 20a1ef3 commit f770475

25 files changed

+114
-122
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeTabsActionGroup/ValidateTabContentAdvancedConfigurationAllOptionsActionGroup.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
<annotations>
1212
<description>Validates Tab content</description>
1313
</annotations>
14-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).textAlign" stepKey="grabAlignmentValue"/>
15-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).borderStyle" stepKey="grabBorderStyleValue"/>
16-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).borderColor" stepKey="grabBorderColorValue"/>
17-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).borderWidth.replace(&quot;px&quot;, &quot;&quot;)" stepKey="grabBorderWidthValue"/>
18-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).borderRadius.replace(/px/g, &quot;&quot;)" stepKey="grabBorderRadiusValue"/>
19-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).margin.replace(/px/g, &quot;&quot;)" stepKey="grabMarginValue"/>
20-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.advancedTabContentConfigurationPath(index)}}', document.body).iterateNext()).padding.replace(/px/g, &quot;&quot;)" stepKey="grabPaddingValue"/>
14+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).textAlign" stepKey="grabAlignmentValue"/>
15+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).borderStyle" stepKey="grabBorderStyleValue"/>
16+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).borderColor" stepKey="grabBorderColorValue"/>
17+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).borderWidth.replace(&quot;px&quot;, &quot;&quot;)" stepKey="grabBorderWidthValue"/>
18+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).borderRadius.replace(/px/g, &quot;&quot;)" stepKey="grabBorderRadiusValue"/>
19+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).margin.replace(/px/g, &quot;&quot;)" stepKey="grabMarginValue"/>
20+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).padding.replace(/px/g, &quot;&quot;)" stepKey="grabPaddingValue"/>
2121
</actionGroup>
2222
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/LayoutConfigurationActionGroup/ValidateLayoutConfigurationWithAllUpdatedActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818
<argument name="verticalAlign" defaultValue="PageBuilderVerticalAlignmentPropertyCenter"/>
1919
</arguments>
2020
<waitForElementVisible selector="{{page.base(index)}}" stepKey="waitForContentType"/>
21-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.minHeightPath(index)}}', document.body).iterateNext()).minHeight.replace(/px/g, &quot;&quot;)" stepKey="grabMinHeightValue"/>
21+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.base(index)}}', document.body).iterateNext()).minHeight.replace(/px/g, &quot;&quot;)" stepKey="grabMinHeightValue"/>
2222
<assertEquals stepKey="assertMinHeightVisible">
2323
<expectedResult type="string">{{minHeight.value}}</expectedResult>
2424
<actualResult type="variable">grabMinHeightValue</actualResult>
2525
</assertEquals>
26-
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.verticalAlignContainerPath(index)}}', document.body).iterateNext()).justifyContent" stepKey="grabVerticalAlignValue"/>
26+
<executeJS function="return window.getComputedStyle(document.evaluate('{{page.elementChildren(index)}}', document.body).iterateNext()).justifyContent" stepKey="grabVerticalAlignValue"/>
2727
<assertEquals stepKey="verticalAlignVisible">
2828
<expectedResult type="string">{{verticalAlign.value}}</expectedResult>
2929
<actualResult type="variable">grabVerticalAlignValue</actualResult>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderColumnSection/ColumnOnBackendSection.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010
<section name="ColumnOnBackend">
11-
<element name="base" type="button" selector="(//div[@data-content-type='column'])[{{arg1}}]" parameterized="true"/>
11+
<element name="base" type="button" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
1212
<element name="baseJS" type="text" selector="document.querySelectorAll('[data-content-type=column]')[{{arg1}} - 1]" parameterized="true"/>
1313
<element name="baseCSS" type="text" selector="[data-content-type=column][data-element=main]"/>
14+
<element name="elementChildren" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]/div[contains(@class,&quot;element-children&quot;)]" parameterized="true"/>
1415
<element name="columnConfigurationPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
1516
<element name="columnChildrenConfigurationPath" type="text" selector="(//div[contains(@class, &quot;pagebuilder-column-group&quot;)])[{{arg1}}]/descendant::div[contains(@class, &quot;pagebuilder-content-type&quot;) and contains(@class, &quot;pagebuilder-column&quot;)][{{arg2}}]//div[contains(@class, &quot;element-children&quot;)]" parameterized="true"/>
1617
<element name="allColumns" type="text" selector="//div[contains(@class, 'pagebuilder-content-type') and contains(@class, 'pagebuilder-column')]"/>
17-
<element name="default" type="button" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-column')])[{{arg1}}][@style='border: {{arg2}}; border-radius: {{arg3}}px; margin: {{arg4}}px; padding: {{arg5}}px; width: {{arg6}}; background-size: {{arg7}}; background-repeat: {{arg8}}; background-attachment: {{arg9}}; align-self: {{arg10}};']" parameterized="true"/>
18+
<element name="default" type="button" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-column')])[{{arg1}}][@style='border: {{arg2}}; border-radius: {{arg3}}px; margin: {{arg4}}px; padding: {{arg5}}px; width: {{arg6}}; background-size: {{arg7}}; background-repeat: {{arg8}}; background-attachment: {{arg9}}; align-self: {{arg10}};']" parameterized="true" deprecated="Styles are not inline"/>
1819
<element name="empty" type="button" selector="(//div[contains(@class,'empty-container')]//div[contains(@class,'element-children') and contains(@class,'column-container')])[{{arg1}}]" parameterized="true"/>
1920
<element name="columnGroup" type="text" selector="(//div[contains(@class, 'pagebuilder-column-group')])[{{arg1}}]" parameterized="true"/>
2021
<element name="columnGroupPath" type="text" selector="(//div[contains(@class, &quot;pagebuilder-column-group&quot;)])[{{arg1}}]" parameterized="true"/>
@@ -37,9 +38,7 @@
3738
<element name="gridSizeError" type="button" selector="(//div[contains(@class, 'pagebuilder-column-group')])[{{arg1}}]/descendant::div[contains(@class, 'admin__field-error') and contains(text(), '{{arg2}}')]" parameterized="true"/>
3839
<element name="appearance" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
3940
<element name="minHeight" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true" deprecated="Styles are not inline"/>
40-
<element name="minHeightPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
4141
<element name="verticalAlignContainer" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}]/div[contains(@class,'column-container')][contains(@style,'justify-content: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>
42-
<element name="verticalAlignContainerPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]/div[contains(@class,&quot;column-container&quot;)]" parameterized="true"/>
4342
<!-- Background Configuration -->
4443
<element name="backgroundPath" type="text" selector="(//div[contains(@class,&quot;pagebuilder-column&quot;) and contains(@class,&quot;pagebuilder-content-type&quot;)])[{{arg1}}]" parameterized="true"/>
4544
<element name="backgroundPosition" type="button" selector="(//div[contains(@class,'pagebuilder-column') and contains(@class,'pagebuilder-content-type')])[{{arg1}}][contains(@style,'background-position: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderColumnSection/ColumnOnFrontendSection.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<element name="base" type="block" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
1212
<element name="baseJS" type="text" selector="document.querySelectorAll('[data-content-type=column]')[{{arg1}} - 1]" parameterized="true"/>
1313
<element name="baseCSS" type="text" selector="[data-content-type=column]"/>
14+
<element name="elementChildren" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
1415
<element name="columnGroup" type="text" selector="(//div[contains(@class, 'pagebuilder-column-group')])[{{arg1}}]" parameterized="true"/>
1516
<element name="allColumnGroups" type="block" selector=".pagebuilder-column-group"/>
1617
<element name="allColumns" type="block" selector="(//div[@data-content-type='column'])"/>
@@ -54,9 +55,7 @@
5455
<element name="columnClass" type="button" selector="[data-content-type='column']:first-child.first-class.second-class.third-class"/>
5556
<element name="appearance" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
5657
<element name="minHeight" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'min-height: {{arg2}}px;')]" parameterized="true" deprecated="Styles are not inline"/>
57-
<element name="minHeightPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
5858
<element name="verticalAlignContainer" type="text" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'justify-content: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>
59-
<element name="verticalAlignContainerPath" type="text" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
6059
<!-- Background Configuration -->
6160
<element name="backgroundPath" type="button" selector="(//div[@data-content-type=&quot;column&quot;])[{{arg1}}]" parameterized="true"/>
6261
<element name="backgroundPosition" type="button" selector="(//div[@data-content-type='column'])[{{arg1}}][contains(@style,'background-position: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderRowSection/RowOnStageSection.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010
<section name="RowOnStage">
1111
<element name="allRows" type="text" selector="//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')]"/>
12-
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}]" parameterized="true"/>
12+
<element name="base" type="text" selector="(//div[contains(@class,&quot;pagebuilder-content-type&quot;) and contains(@class,&quot;pagebuilder-row&quot;)])[{{arg1}}]" parameterized="true"/>
1313
<element name="baseJS" type="text" selector="document.querySelectorAll('[data-content-type=row]')[{{arg1}} - 1]" parameterized="true"/>
14+
<element name="elementChildren" type="text" selector="(//div[contains(@class, &quot;pagebuilder-row&quot;)])[{{arg1}}]//div[contains(@class, &quot;element-children&quot;) and contains(@class, &quot;row-container&quot;)]" parameterized="true"/>
1415
<element name="hidden" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
1516
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1617
<element name="baseCSS" type="text" selector="div.pagebuilder-content-type.pagebuilder-row"/>
@@ -24,9 +25,7 @@
2425
<element name="appearanceContained" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
2526
<element name="appearanceFullWidthFullBleed" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][@data-appearance='{{arg2}}']" parameterized="true"/>
2627
<element name="minHeight" type="button" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{arg1}}][contains(@style,'min-height: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>
27-
<element name="minHeightPath" type="text" selector="(//div[contains(@class,&quot;pagebuilder-content-type&quot;) and contains(@class,&quot;pagebuilder-row&quot;)])[{{arg1}}]" parameterized="true"/>
2828
<element name="verticalAlignContainer" type="button" selector="(//div[contains(@class, 'pagebuilder-row')])[{{arg1}}]//div[contains(@class, 'element-children') and contains(@class, 'row-container')][contains(@style,'justify-content: {{arg2}};')]" parameterized="true" deprecated="Styles are not inline"/>
29-
<element name="verticalAlignContainerPath" type="text" selector="(//div[contains(@class, &quot;pagebuilder-row&quot;)])[{{arg1}}]//div[contains(@class, &quot;element-children&quot;) and contains(@class, &quot;row-container&quot;)]" parameterized="true"/>
3029
<!-- Background Configuration -->
3130
<element name="backgroundPath" type="button" selector="(//div[contains(@class,&quot;pagebuilder-content-type&quot;) and contains(@class,&quot;pagebuilder-row&quot;)])[{{arg1}}]" parameterized="true"/>
3231
<element name="backgroundType" type="text" parameterized="true" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-row')])[{{index}}][@data-background-type='{{backgroundType}}']"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderRowSection/RowOnStage_ContainedSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010
<section name="RowOnStage_Contained">
11-
<element name="base" type="text" selector="(//div[@data-content-type='row'])[{{arg1}}]//div[@data-element='inner']" parameterized="true"/>
11+
<element name="base" type="text" selector="(//div[@data-content-type=&quot;row&quot;])[{{arg1}}]//div[@data-element=&quot;inner&quot;]" parameterized="true"/>
1212
<element name="baseJS" type="text" selector="(document.querySelectorAll('[data-content-type=row]')[{{arg1}} - 1]).querySelector('[data-element=inner]')" parameterized="true"/>
1313
</section>
1414
</sections>

0 commit comments

Comments
 (0)