Skip to content

Commit f690c74

Browse files
danmooney2danmooney2
committed
MC-3870: Background does not conform to border radius for banner, image, contained row & video
Address CR feedback - Break up tests - Use executeJS to calculate expectedValue for poster appearance
1 parent 07f3cc2 commit f690c74

5 files changed

+214
-239
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1280,4 +1280,37 @@
12801280
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
12811281
<see selector="{{BannerOnFrontend.button('1')}}" userInput="{{PageBuilderBannerButtonTextProperty_Non_Breaking_Space.value}}" stepKey="seeStorefrontNBSPButtonAfterSave"/>
12821282
</test>
1283+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageCenteredAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
1284+
<annotations>
1285+
<features value="PageBuilder"/>
1286+
<stories value="Banner"/>
1287+
<title value="Collage Center - Overlay does not have border radius applied on collage centered appearance"/>
1288+
<description value="As a content creator I do not want border radius of banner overlay with collage centered appearance to have a border radius applied to it so that I may be able to style it independently"/>
1289+
<severity value="MAJOR"/>
1290+
<useCaseId value="MC-3870"/>
1291+
<testCaseId value="MC-5253"/>
1292+
<group value="pagebuilder"/>
1293+
<group value="pagebuilder-banner"/>
1294+
<group value="pagebuilder-bannerCollageCenter"/>
1295+
</annotations>
1296+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
1297+
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
1298+
</actionGroup>
1299+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
1300+
<expectedResult type="int">0</expectedResult>
1301+
<actualResult type="variable">$overlayBorderRadius</actualResult>
1302+
</assertEquals>
1303+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
1304+
<expectedResult type="int">0</expectedResult>
1305+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
1306+
</assertEquals>
1307+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
1308+
<expectedResult type="int">0</expectedResult>
1309+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
1310+
</assertEquals>
1311+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
1312+
<expectedResult type="int">0</expectedResult>
1313+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
1314+
</assertEquals>
1315+
</test>
12831316
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,4 +1184,37 @@
11841184
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
11851185
</actionGroup>
11861186
</test>
1187+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageLeftAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
1188+
<annotations>
1189+
<features value="PageBuilder"/>
1190+
<stories value="Banner"/>
1191+
<title value="Collage Left - Overlay does not have border radius applied on collage left appearance"/>
1192+
<description value="As a content creator I do not want border radius of banner overlay with collage left appearance to have a border radius applied to it so that I may be able to style it independently"/>
1193+
<severity value="MAJOR"/>
1194+
<useCaseId value="MC-3870"/>
1195+
<testCaseId value="MC-5254"/>
1196+
<group value="pagebuilder"/>
1197+
<group value="pagebuilder-banner"/>
1198+
<group value="pagebuilder-bannerCollageLeft"/>
1199+
</annotations>
1200+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
1201+
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
1202+
</actionGroup>
1203+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
1204+
<expectedResult type="int">0</expectedResult>
1205+
<actualResult type="variable">$overlayBorderRadius</actualResult>
1206+
</assertEquals>
1207+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
1208+
<expectedResult type="int">0</expectedResult>
1209+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
1210+
</assertEquals>
1211+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
1212+
<expectedResult type="int">0</expectedResult>
1213+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
1214+
</assertEquals>
1215+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
1216+
<expectedResult type="int">0</expectedResult>
1217+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
1218+
</assertEquals>
1219+
</test>
11871220
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,4 +1184,37 @@
11841184
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
11851185
</actionGroup>
11861186
</test>
1187+
<test name="BannerOverlayDoesNotHaveBorderRadiusAppliedOnCollageRightAppearance" extends="BannerOverlayHasConvertedBorderRadiusAppliedOnPosterAppearance">
1188+
<annotations>
1189+
<features value="PageBuilder"/>
1190+
<stories value="Banner"/>
1191+
<title value="Collage Right - Overlay does not have border radius applied on collage right appearance"/>
1192+
<description value="As a content creator I do not want border radius of banner overlay with collage right appearance to have a border radius applied to it so that I may be able to style it independently"/>
1193+
<severity value="MAJOR"/>
1194+
<useCaseId value="MC-3870"/>
1195+
<testCaseId value="MC-5252"/>
1196+
<group value="pagebuilder"/>
1197+
<group value="pagebuilder-banner"/>
1198+
<group value="pagebuilder-bannerCollageRight"/>
1199+
</annotations>
1200+
<actionGroup ref="chooseVisualSelectOption" stepKey="selectAppearance">
1201+
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
1202+
</actionGroup>
1203+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidth">
1204+
<expectedResult type="int">0</expectedResult>
1205+
<actualResult type="variable">$overlayBorderRadius</actualResult>
1206+
</assertEquals>
1207+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusGreaterThanBorderWidthOnStorefront">
1208+
<expectedResult type="int">0</expectedResult>
1209+
<actualResult type="variable">$overlayBorderRadiusStorefront</actualResult>
1210+
</assertEquals>
1211+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidth">
1212+
<expectedResult type="int">0</expectedResult>
1213+
<actualResult type="variable">$overlayBorderRadius2</actualResult>
1214+
</assertEquals>
1215+
<assertEquals stepKey="assertOverlayBorderRadiusEqualityWhereBorderRadiusLessThanOrEqualToBorderWidthOnStorefront">
1216+
<expectedResult type="int">0</expectedResult>
1217+
<actualResult type="variable">$overlayBorderRadiusStorefront2</actualResult>
1218+
</assertEquals>
1219+
</test>
11871220
</tests>

0 commit comments

Comments
 (0)