Skip to content

Commit f5e17be

Browse files
committed
MC-4280: Row Vertical Alignment Doesn't Work Inside Block & Dynamic Block
- clientHeight can be greater than min height
1 parent 7220057 commit f5e17be

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeBlockActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@
4949
</arguments>
5050
<executeJS function="return document.querySelectorAll('{{block.baseCSS}} {{container.baseCSS}}')[{{index}}-1].clientHeight;" stepKey="containerHeight"/>
5151
<executeJS function="return {$containerHeight}-{{storefrontBugOffset}}" stepKey="minusBugOffset"/>
52-
<assertEquals stepKey="assertContainerHeightEqualsMinHeight">
52+
<assertGreaterThanOrEqual stepKey="assertContainerHeightEqualsMinHeight">
5353
<expectedResult type="string">{{minHeight}}</expectedResult>
5454
<actualResult type="variable">minusBugOffset</actualResult>
55-
</assertEquals>
55+
</assertGreaterThanOrEqual>
5656
<executeJS function="return document.querySelectorAll('{{block.baseCSS}} {{container.baseCSS}}')[{{index}}-1].getBoundingClientRect().bottom-{{padding.paddingBottom}}" stepKey="containerBottomPositionMinusPadding"/>
5757
<executeJS function="return document.querySelectorAll('{{block.baseCSS}} {{content.baseCSS}}')[{{index}}-1].getBoundingClientRect().bottom" stepKey="contentBottomPosition"/>
5858
<executeJS function="return Math.round(({$containerBottomPositionMinusPadding}/{$contentBottomPosition})*100)/100" stepKey="bottomPositionRatio"/>

0 commit comments

Comments
 (0)