#558: Content Types Output Style Attribute Removal

- Minor Refactoring

Author: bluemwhitew

app/code/Magento/PageBuilder/Setup/Converters/PageBuilderStripStyles.php

@@ -20,6 +20,7 @@ class PageBuilderStripStyles implements DataConverterInterface
 {
     const BODY_ID = 'html-body';
     const DATA_ATTRIBUTE = 'data-pb-style';
+    const XPATH_SELECTOR = '//*[@data-content-type][@style]|//*[@data-content-type]/*[@style]';
 
     /**
      * @var DOMDocument
@@ -74,7 +75,7 @@ public function convert($value)
         libxml_clear_errors();
 
         $body = $document->documentElement->lastChild;
-        $nodes = $xpath->query('//*[@data-content-type][@style]|//*[@data-content-type]/*[@style]'); // Query for Inline Styles
+        $nodes = $xpath->query(self::XPATH_SELECTOR); // Query for Inline Styles
         $styleMap = [];
 
         foreach ($nodes as $node) {

dev/tests/integration/testsuite/Magento/PageBuilder/Setup/Converters/PageBuilderStripStylesTest.php

@@ -51,10 +51,10 @@ public function testConvert(string $htmlString, int $expectedStyleTags)
         libxml_clear_errors();
 
         // Check Inline Styles Were Removed
-        $this->assertEquals(0, sizeof($xpathAfter->query('//*[@data-content-type][@style]|//*[@data-content-type]/*[@style]')));
+        $this->assertEquals(0, count($xpathAfter->query(PageBuilderStripStyles::XPATH_SELECTOR)));
 
         // Check Expected Internal Styles
-        $this->assertEquals($expectedStyleTags, sizeof($xpathAfter->query('//style')));
+        $this->assertEquals($expectedStyleTags, count($xpathAfter->query('//style')));
     }
 
     /**