Skip to content

Commit f1d6808

Browse files
davemacaulaydavemacaulay
committed
PB-267: Fix all broken Map related tests in Page Builder Component
1 parent 4cbedec commit f1d6808

10 files changed

+127
-1
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/CmsConfigData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<data key="row">row_cms_pagebuilder_google_maps_api_key</data>
1414
<data key="label">Google Maps API Key</data>
1515
<data key="default"/>
16-
<data key="valid">AIzaSyA7TbgpW4U9yKFNzJmHPwLUh_bWt9nXBl4</data>
16+
<data key="valid">Valid API Key tests are currently not running</data>
1717
<data key="invalidOneCharacter">a</data>
1818
<data key="invalidOneCharacterOffOfValid">aIzaSyA7TbgpW4U9yKFNzJmHPwLUh_bWt9nXBl4</data>
1919
<data key="empty"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Suite/PageBuilderRequiresValidGoogleMapsAPIKeySuite.xml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<suites xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Suite/etc/suiteSchema.xsd">
9+
<suite name="PageBuilderRequiresValidGoogleMapsAPIKeySuite">
10+
<before>
11+
<magentoCLI command="config:set cms/pagebuilder/enabled 1" stepKey="enablePageBuilder"/>
12+
<magentoCLI command="config:set cms/wysiwyg/enabled enabled" stepKey="enableWYSIWYG"/>
13+
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4"/>
14+
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key ''" stepKey="setEmptyGoogleMapsAPIKey"/>
15+
<magentoCLI command="config:set web/default_layouts/default_cms_layout cms-full-width" stepKey="setPageBuilderDefaultCmsLayout"/>
16+
<magentoCLI command="config:set web/default_layouts/default_category_layout category-full-width" stepKey="setPageBuilderDefaultCategoryLayout"/>
17+
<magentoCLI command="config:set web/default_layouts/default_product_layout product-full-width" stepKey="setPageBuilderDefaultProductLayout"/>
18+
</before>
19+
<after>
20+
<magentoCLI command="config:set cms/pagebuilder/enabled 1" stepKey="enablePageBuilder"/>
21+
<magentoCLI command="config:set cms/wysiwyg/editor mage/adminhtml/wysiwyg/tiny_mce/tinymce4Adapter" stepKey="enableTinyMCE4"/>
22+
<magentoCLI command="config:set cms/wysiwyg/enabled disabled" stepKey="disableWYSIWYG"/>
23+
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key ''" stepKey="setEmptyGoogleMapsAPIKey"/>
24+
</after>
25+
<include>
26+
<group name="pagebuilder-requiresValidMapAPIKey"/>
27+
</include>
28+
</suite>
29+
</suites>

‎app/code/Magento/PageBuilder/Test/Mftf/Suite/PageBuilderSuite.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,8 @@
2222
<include>
2323
<group name="pagebuilder"/>
2424
</include>
25+
<exclude>
26+
<group name="pagebuilder-requiresValidMapAPIKey"/>
27+
</exclude>
2528
</suite>
2629
</suites>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTests.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2032,6 +2032,9 @@
20322032
<group value="pagebuilder-map"/>
20332033
<group value="pagebuilder-mapMapSettings"/>
20342034
<group value="pagebuilder-requiresValidMapAPIKey"/>
2035+
<skip>
2036+
<issueId value="MTS-657"/>
2037+
</skip>
20352038
</annotations>
20362039
<before>
20372040
<createData entity="_emptyCmsPage" stepKey="createCMSPage"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapCommonComponentTest.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
<group value="pagebuilder"/>
2121
<group value="pagebuilder-map"/>
2222
<group value="pagebuilder-mapCommon"/>
23+
<group value="pagebuilder-requiresValidMapAPIKey"/>
24+
<skip>
25+
<issueId value="MTS-657"/>
26+
</skip>
2327
</annotations>
2428
<before>
2529
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -533,6 +537,9 @@
533537
<group value="pagebuilder-map"/>
534538
<group value="pagebuilder-mapCommon"/>
535539
<group value="pagebuilder-requiresValidMapAPIKey"/>
540+
<skip>
541+
<issueId value="MTS-657"/>
542+
</skip>
536543
</annotations>
537544
<before>
538545
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapLocationAttributeTests.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
<group value="pagebuilder-mapLocation"/>
2323
<group value="pagebuilder-mapLocationAttributes"/>
2424
<group value="pagebuilder-requiresValidMapAPIKey"/>
25+
<skip>
26+
<issueId value="MTS-657"/>
27+
</skip>
2528
</annotations>
2629
<before>
2730
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -220,6 +223,9 @@
220223
<group value="pagebuilder-mapLocation"/>
221224
<group value="pagebuilder-mapLocationAttributes"/>
222225
<group value="pagebuilder-requiresValidMapAPIKey"/>
226+
<skip>
227+
<issueId value="MTS-657"/>
228+
</skip>
223229
</annotations>
224230
<before>
225231
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -343,6 +349,9 @@
343349
<group value="pagebuilder-mapLocation"/>
344350
<group value="pagebuilder-mapLocationAttributes"/>
345351
<group value="pagebuilder-requiresValidMapAPIKey"/>
352+
<skip>
353+
<issueId value="MTS-657"/>
354+
</skip>
346355
</annotations>
347356
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterCoordinate">
348357
<argument name="property" value="PageBuilderMapLatitude_Positive39_74"/>
@@ -406,6 +415,9 @@
406415
<group value="pagebuilder-mapLocation"/>
407416
<group value="pagebuilder-mapLocationAttributes"/>
408417
<group value="pagebuilder-requiresValidMapAPIKey"/>
418+
<skip>
419+
<issueId value="MTS-657"/>
420+
</skip>
409421
</annotations>
410422
<before>
411423
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -601,6 +613,9 @@
601613
<group value="pagebuilder-mapLocation"/>
602614
<group value="pagebuilder-mapLocationAttributes"/>
603615
<group value="pagebuilder-requiresValidMapAPIKey"/>
616+
<skip>
617+
<issueId value="MTS-657"/>
618+
</skip>
604619
</annotations>
605620
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterPhoneNumber1">
606621
<argument name="property" value="PageBuilderMapStreetAddress_CommonCharacters"/>
@@ -669,6 +684,9 @@
669684
<group value="pagebuilder-mapLocation"/>
670685
<group value="pagebuilder-mapLocationAttributes"/>
671686
<group value="pagebuilder-requiresValidMapAPIKey"/>
687+
<skip>
688+
<issueId value="MTS-657"/>
689+
</skip>
672690
</annotations>
673691
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterPhoneNumber1">
674692
<argument name="property" value="PageBuilderMapCity_CommonCharacters"/>
@@ -737,6 +755,9 @@
737755
<group value="pagebuilder-mapLocation"/>
738756
<group value="pagebuilder-mapLocationAttributes"/>
739757
<group value="pagebuilder-requiresValidMapAPIKey"/>
758+
<skip>
759+
<issueId value="MTS-657"/>
760+
</skip>
740761
</annotations>
741762
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterPhoneNumber1">
742763
<argument name="property" value="PageBuilderMapState_CommonCharacters"/>
@@ -805,6 +826,9 @@
805826
<group value="pagebuilder-mapLocation"/>
806827
<group value="pagebuilder-mapLocationAttributes"/>
807828
<group value="pagebuilder-requiresValidMapAPIKey"/>
829+
<skip>
830+
<issueId value="MTS-657"/>
831+
</skip>
808832
</annotations>
809833
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterPhoneNumber1">
810834
<argument name="property" value="PageBuilderMapZipCode_CommonCharacters"/>
@@ -873,6 +897,9 @@
873897
<group value="pagebuilder-mapLocation"/>
874898
<group value="pagebuilder-mapLocationAttributes"/>
875899
<group value="pagebuilder-requiresValidMapAPIKey"/>
900+
<skip>
901+
<issueId value="MTS-657"/>
902+
</skip>
876903
</annotations>
877904
<before>
878905
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -966,6 +993,9 @@
966993
<group value="pagebuilder-mapLocation"/>
967994
<group value="pagebuilder-mapLocationAttributes"/>
968995
<group value="pagebuilder-requiresValidMapAPIKey"/>
996+
<skip>
997+
<issueId value="MTS-657"/>
998+
</skip>
969999
</annotations>
9701000
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterPhoneNumber1">
9711001
<argument name="property" value="PageBuilderMapComment_CommonCharacters"/>
@@ -1012,6 +1042,9 @@
10121042
<group value="pagebuilder-mapLocation"/>
10131043
<group value="pagebuilder-mapLocationAttributes"/>
10141044
<group value="pagebuilder-requiresValidMapAPIKey"/>
1045+
<skip>
1046+
<issueId value="MTS-657"/>
1047+
</skip>
10151048
</annotations>
10161049
<before>
10171050
<createData entity="_defaultCmsPage" stepKey="createCMSPage" />

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapLocationTests.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1409,6 +1409,9 @@
14091409
<group value="pagebuilder-map"/>
14101410
<group value="pagebuilder-mapLocation"/>
14111411
<group value="pagebuilder-requiresValidMapAPIKey"/>
1412+
<skip>
1413+
<issueId value="MTS-657"/>
1414+
</skip>
14121415
</annotations>
14131416
<before>
14141417
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapMapSettingsAttributesTest.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
<group value="pagebuilder-map"/>
2222
<group value="pagebuilder-mapMapSettings"/>
2323
<group value="pagebuilder-requiresValidMapAPIKey"/>
24+
<skip>
25+
<issueId value="MTS-657"/>
26+
</skip>
2427
</annotations>
2528
<before>
2629
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -205,6 +208,9 @@
205208
<group value="pagebuilder-map"/>
206209
<group value="pagebuilder-mapMapSettings"/>
207210
<group value="pagebuilder-requiresValidMapAPIKey"/>
211+
<skip>
212+
<issueId value="MTS-657"/>
213+
</skip>
208214
</annotations>
209215
<before>
210216
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderMapPinTest.xml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
<group value="pagebuilder-map"/>
2222
<group value="pagebuilder-mapPinTests"/>
2323
<group value="pagebuilder-requiresValidMapAPIKey"/>
24+
<skip>
25+
<issueId value="MTS-657"/>
26+
</skip>
2427
</annotations>
2528
<before>
2629
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -178,6 +181,9 @@
178181
<group value="pagebuilder-map"/>
179182
<group value="pagebuilder-mapPinTests"/>
180183
<group value="pagebuilder-requiresValidMapAPIKey"/>
184+
<skip>
185+
<issueId value="MTS-657"/>
186+
</skip>
181187
</annotations>
182188
<before>
183189
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -305,6 +311,9 @@
305311
<group value="pagebuilder-map"/>
306312
<group value="pagebuilder-mapPinTests"/>
307313
<group value="pagebuilder-requiresValidMapAPIKey"/>
314+
<skip>
315+
<issueId value="MTS-657"/>
316+
</skip>
308317
</annotations>
309318
<before>
310319
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -449,6 +458,9 @@
449458
<group value="pagebuilder-map"/>
450459
<group value="pagebuilder-mapPinTests"/>
451460
<group value="pagebuilder-requiresValidMapAPIKey"/>
461+
<skip>
462+
<issueId value="MTS-657"/>
463+
</skip>
452464
</annotations>
453465
<before>
454466
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -579,6 +591,9 @@
579591
<group value="pagebuilder-map"/>
580592
<group value="pagebuilder-mapPinTests"/>
581593
<group value="pagebuilder-requiresValidMapAPIKey"/>
594+
<skip>
595+
<issueId value="MTS-657"/>
596+
</skip>
582597
</annotations>
583598
<before>
584599
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -707,6 +722,9 @@
707722
<group value="pagebuilder-map"/>
708723
<group value="pagebuilder-mapPinTests"/>
709724
<group value="pagebuilder-requiresValidMapAPIKey"/>
725+
<skip>
726+
<issueId value="MTS-657"/>
727+
</skip>
710728
</annotations>
711729
<before>
712730
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -835,6 +853,9 @@
835853
<group value="pagebuilder-map"/>
836854
<group value="pagebuilder-mapPinTests"/>
837855
<group value="pagebuilder-requiresValidMapAPIKey"/>
856+
<skip>
857+
<issueId value="MTS-657"/>
858+
</skip>
838859
</annotations>
839860
<before>
840861
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -908,6 +929,9 @@
908929
<group value="pagebuilder-map"/>
909930
<group value="pagebuilder-mapPinTests"/>
910931
<group value="pagebuilder-requiresValidMapAPIKey"/>
932+
<skip>
933+
<issueId value="MTS-657"/>
934+
</skip>
911935
</annotations>
912936
<before>
913937
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -1004,6 +1028,9 @@
10041028
<group value="pagebuilder-map"/>
10051029
<group value="pagebuilder-mapPinTests"/>
10061030
<group value="pagebuilder-requiresValidMapAPIKey"/>
1031+
<skip>
1032+
<issueId value="MTS-657"/>
1033+
</skip>
10071034
</annotations>
10081035
<before>
10091036
<magentoCLI command="config:set cms/pagebuilder/google_maps_api_key {{googleMapsAPIKey.valid}}" stepKey="setValidGoogleMapsAPIKey"/>
@@ -1126,6 +1153,9 @@
11261153
<group value="pagebuilder-map"/>
11271154
<group value="pagebuilder-mapPinTests"/>
11281155
<group value="pagebuilder-requiresValidMapAPIKey"/>
1156+
<skip>
1157+
<issueId value="MTS-657"/>
1158+
</skip>
11291159
</annotations>
11301160
<before>
11311161
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -1216,6 +1246,9 @@
12161246
<group value="pagebuilder-map"/>
12171247
<group value="pagebuilder-mapPinTests"/>
12181248
<group value="pagebuilder-requiresValidMapAPIKey"/>
1249+
<skip>
1250+
<issueId value="MTS-657"/>
1251+
</skip>
12191252
</annotations>
12201253
<before>
12211254
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminStoreConfigurationPageBuilderGoogleMapsAPIKeyTests.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
<group value="pagebuilder-store-configuration"/>
2222
<group value="pagebuilder-googleMapsAPIKey"/>
2323
<group value="pagebuilder-requiresValidMapAPIKey"/>
24+
<skip>
25+
<issueId value="MTS-657"/>
26+
</skip>
2427
</annotations>
2528
<before>
2629
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -153,6 +156,9 @@
153156
<group value="pagebuilder-store-configuration"/>
154157
<group value="pagebuilder-googleMapsAPIKey"/>
155158
<group value="pagebuilder-requiresValidMapAPIKey"/>
159+
<skip>
160+
<issueId value="MTS-657"/>
161+
</skip>
156162
</annotations>
157163
<before>
158164
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
@@ -228,6 +234,9 @@
228234
<group value="pagebuilder-store-configuration"/>
229235
<group value="pagebuilder-googleMapsAPIKey"/>
230236
<group value="pagebuilder-requiresValidMapAPIKey"/>
237+
<skip>
238+
<issueId value="MTS-657"/>
239+
</skip>
231240
</annotations>
232241
<before>
233242
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

0 commit comments

Comments
 (0)