MC-5810: Improve naming of the critical variables/parameters in the code and configuration

Hwashiang Yu · Hwashiang Yu · commit f1b43bf93a75 · 2019-02-08T11:15:37.000-06:00
- Resolved MHI failure by changing variable scope in reader
diff --git a/app/code/Magento/PageBuilder/Model/Config/MenuSection/Reader.php b/app/code/Magento/PageBuilder/Model/Config/MenuSection/Reader.php
@@ -18,7 +18,7 @@ class Reader extends \Magento\Framework\Config\Reader\Filesystem
      *
      * @var array
      */
-    protected $_idAttributes = [
+    private $_idAttributes = [
         '/config/menu_section' => 'name'
     ];
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class Reader extends \Magento\Framework\Config\Reader\Filesystem`
`18`	`18`	`*`
`19`	`19`	`* @var array`
`20`	`20`	`*/`
`21`		`- protected $_idAttributes = [`
	`21`	`+ private $_idAttributes = [`
`22`	`22`	`'/config/menu_section' => 'name'`
`23`	`23`	`];`
`24`	`24`