Skip to content

Commit f06ac24

Browse files
dhaeckerdhaecker
committed
MC-15297: Selecting "Conditions Combination" For Product List Condition Will Throw 500 Error & Redirect User To Broken Page
 - Fixing multiple conditions product test - Creating shared action groups for product conditions - Updating/adding supporting data & sections - Updating affected tests
1 parent bc65cde commit f06ac24

File tree

6 files changed

+136
-145
lines changed

6 files changed

+136
-145
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup.xml

Lines changed: 28 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -74,56 +74,40 @@
7474
<grabMultiple selector="{{page.product(index)}}" stepKey="grabProducts"/>
7575
<assertCount stepKey="assertCount" expected="{{count}}" expectedType="int" actualType="variable" actual="grabProducts"/>
7676
</actionGroup>
77-
<actionGroup name="addCategoryConditionToProductsBlock">
77+
<actionGroup name="addConditionToProductConditions">
7878
<arguments>
79-
<argument name="page" defaultValue=""/>
80-
<argument name="category" defaultValue="" type="string"/>
81-
<argument name="conditionIndex" defaultValue="1" type="string"/>
82-
</arguments>
83-
<waitForElementVisible selector="{{page.conditionsList}}" stepKey="waitForConditionsToLoad"/>
84-
<click selector="{{page.conditionsListAddButton}}" stepKey="addCondition"/>
85-
<selectOption selector="{{page.conditionsListAddTypeSelect}}" userInput="Magento\CatalogWidget\Model\Rule\Condition\Product|category_ids" stepKey="selectCategoryOption"/>
86-
<waitForLoadingMaskToDisappear stepKey="waitForCategoriesToLoad"/>
87-
<click selector="{{page.conditionsListConditionPlaceholder}}" stepKey="revealCategoryInput"/>
88-
<fillField selector="{{page.conditionsListConditionInput}}" userInput="{{category}}" stepKey="fillCategoryField"/>
89-
</actionGroup>
90-
<actionGroup name="addSKUConditionToProductsBlock">
91-
<arguments>
92-
<argument name="page" defaultValue=""/>
93-
<argument name="SKU" defaultValue="" type="string"/>
94-
<argument name="conditionIndex" defaultValue="1" type="string"/>
79+
<argument name="conditionType" defaultValue="PageBuilderProductsConditionCategory"/>
80+
<argument name="conditionInput" defaultValue="1" type="string"/>
81+
<argument name="index" defaultValue="1" type="string"/>
9582
</arguments>
96-
<waitForElementVisible selector="{{page.conditionsList}}" stepKey="waitForConditionsToLoad"/>
97-
<click selector="{{page.conditionsListAddButton}}" stepKey="addCondition"/>
98-
<selectOption selector="{{page.conditionsListAddTypeSelect}}" userInput="Magento\CatalogWidget\Model\Rule\Condition\Product|sku" stepKey="selectSKUOption"/>
99-
<waitForLoadingMaskToDisappear stepKey="waitForCategoriesToLoad"/>
100-
<click selector="{{page.conditionsListConditionPlaceholder}}" stepKey="revealSKUInput"/>
101-
<fillField selector="{{page.conditionsListConditionInput}}" userInput="{{SKU}}" stepKey="fillSKUField"/>
83+
<comment userInput="addConditionToProductConditions" stepKey="comment"/>
84+
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsList}}" stepKey="waitForConditionsToLoad"/>
85+
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="waitForAddConditionButton"/>
86+
<click selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="clickAddConditionButton"/>
87+
<selectOption selector="{{ProductsContentTypeForm.conditionsListAddTypeSelect(index)}}" userInput="{{conditionType.value}}" stepKey="selectConditionType"/>
88+
<waitForPageLoad stepKey="waitForConditionFieldsToLoad"/>
89+
<click selector="{{ProductsContentTypeForm.conditionsListConditionPlaceholder}}" stepKey="revealCategoryInput"/>
90+
<fillField selector="{{ProductsContentTypeForm.conditionsListConditionInput}}" userInput="{{conditionInput}}" stepKey="fillCategoryField"/>
10291
</actionGroup>
103-
<actionGroup name="addCategoryConditionViaConditionsCombinationToProducts">
92+
<actionGroup name="addConditionsCombinationToProductsAndSetAggregateParameters">
10493
<arguments>
105-
<argument name="page" defaultValue="ProductsContentTypeForm"/>
106-
<argument name="category" defaultValue="" type="string"/>
10794
<argument name="aggregatorType" defaultValue="all" type="string"/>
10895
<argument name="booleanValueForAggregator" defaultValue="1" type="string"/>
109-
<argument name="depth" defaultValue="2" type="string"/>
96+
<argument name="index" defaultValue="1" type="string"/>
11097
</arguments>
111-
<waitForElementVisible selector="{{page.conditionsList}}" stepKey="waitForConditionsToLoad"/>
112-
<click selector="{{page.conditionsListAddButton}}" stepKey="addCondition"/>
113-
<selectOption selector="{{page.conditionsListAddTypeSelect}}" userInput="Magento\CatalogWidget\Model\Rule\Condition\Combine" stepKey="selectCombineOption"/>
114-
<waitForLoadingMaskToDisappear stepKey="waitForConditionsCombinationTemplateToLoad"/>
115-
<click selector="{{page.conditionsCombinationAggregateSelector(depth)}}" stepKey="addAggregateType"/>
116-
<selectOption selector="{{page.conditionsCombinationAggregateSelectorSelect(depth)}}" userInput="{{aggregatorType}}" stepKey="selectAggregateType"/>
117-
<waitForLoadingMaskToDisappear stepKey="waitForAggregateTypeToLoad"/>
118-
<click selector="{{page.conditionsListText}}" stepKey="clearOptions"/>
119-
<click selector="{{page.conditionsCombinationAggregateBooleanSelector(depth)}}" stepKey="addBooleanAggregateType"/>
120-
<selectOption selector="{{page.conditionsCombinationAggregateBooleanSelectorSelect(depth)}}" userInput="{{booleanValueForAggregator}}" stepKey="selectBooleanAggregateType"/>
121-
<waitForLoadingMaskToDisappear stepKey="waitForBooleanAggregateTypeToLoad"/>
122-
<click selector="{{page.conditionsListText}}" stepKey="clearOptions2"/>
123-
<click selector="{{page.conditionsListAddButton}}" stepKey="addCategoryCondition"/>
124-
<selectOption selector="{{page.conditionsListAddTypeSelect}}" userInput="Magento\CatalogWidget\Model\Rule\Condition\Product|category_ids" stepKey="selectCategoryOption"/>
125-
<waitForLoadingMaskToDisappear stepKey="waitForCategoriesToLoad"/>
126-
<click selector="{{page.conditionsListConditionPlaceholder}}" stepKey="revealCategoryInput"/>
127-
<fillField selector="{{page.conditionsListConditionInput}}" userInput="{{category}}" stepKey="fillCategoryField"/>
98+
<comment userInput="addConditionsCombinationToProductsAndSetAggregateParameters" stepKey="comment"/>
99+
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsList}}" stepKey="waitForConditionsToLoad"/>
100+
<waitForElementVisible selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="waitForAddConditionButton"/>
101+
<click selector="{{ProductsContentTypeForm.conditionsListAddButton(index)}}" stepKey="clickAddConditionButton"/>
102+
<selectOption selector="{{ProductsContentTypeForm.conditionsListAddTypeSelect(index)}}" userInput="{{PageBuilderProductsConditionCombination.value}}" stepKey="selectCombinationOption"/>
103+
<waitForPageLoad stepKey="waitForConditionsCombinationTemplateToLoad"/>
104+
<click selector="{{ProductsContentTypeForm.conditionsCombinationAggregateSelector(index)}}" stepKey="clickAggregateType"/>
105+
<selectOption selector="{{ProductsContentTypeForm.conditionsCombinationAggregateSelectorSelect(index)}}" userInput="{{aggregatorType}}" stepKey="selectAggregateType"/>
106+
<waitForPageLoad stepKey="waitForAggregateTypeToLoad"/>
107+
<click selector="{{ProductsContentTypeForm.conditionsListText}}" stepKey="clearOptions"/>
108+
<click selector="{{ProductsContentTypeForm.conditionsCombinationAggregateBooleanSelector(index)}}" stepKey="clickAggregateTypeBoolean"/>
109+
<selectOption selector="{{ProductsContentTypeForm.conditionsCombinationAggregateBooleanSelectorSelect(index)}}" userInput="{{booleanValueForAggregator}}" stepKey="selectAggregateTypeBoolean"/>
110+
<waitForPageLoad stepKey="waitForAggregateTypeBooleanToLoad"/>
111+
<click selector="{{ProductsContentTypeForm.conditionsListText}}" stepKey="clearOptions2"/>
128112
</actionGroup>
129113
</actionGroups>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/ProductAttributeSetData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
1111
<entity name="AddToDefaultSetSortOrder2" type="ProductAttributeSet">
12+
<!-- This goes in CE repo -->
1213
<var key="attributeCode" entityKey="attribute_code" entityType="ProductAttribute"/>
1314
<data key="attributeSetId">4</data>
1415
<data key="attributeGroupId">7</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/ProductsData.xml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,23 @@
88

99
<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
11+
<!-- Conditions -->
12+
<entity name="PageBuilderProductsConditionCombination" type="pagebuilder_products_condition_types">
13+
<data key="name">Conditions Combination</data>
14+
<data key="value">Magento\CatalogWidget\Model\Rule\Condition\Combine</data>
15+
</entity>
16+
<entity name="PageBuilderProductsConditionCategory" type="pagebuilder_products_condition_types">
17+
<data key="name">Category</data>
18+
<data key="value">Magento\CatalogWidget\Model\Rule\Condition\Product|category_ids</data>
19+
</entity>
20+
<entity name="PageBuilderProductsConditionPrice" type="pagebuilder_products_condition_types">
21+
<data key="name">Price</data>
22+
<data key="value">Magento\CatalogWidget\Model\Rule\Condition\Product|price</data>
23+
</entity>
24+
<entity name="PageBuilderProductsConditionSKU" type="pagebuilder_products_condition_types">
25+
<data key="name">SKU</data>
26+
<data key="value">Magento\CatalogWidget\Model\Rule\Condition\Product|sku</data>
27+
</entity>
1128
<entity name="PageBuilderProductsCountPropertyOne" type="pagebuilder_content_type">
1229
<data key="name">Number of Products to Display</data>
1330
<data key="section">general</data>
@@ -26,7 +43,6 @@
2643
<data key="fieldName">products_count</data>
2744
<data key="value">999</data>
2845
</entity>
29-
3046
<entity name="PageBuilderProductsInvalidMinCountProperty" type="pagebuilder_content_type">
3147
<data key="name">Number of Products to Display</data>
3248
<data key="section">general</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderProductsSection.xml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,16 @@
4040
<section name="ProductsContentTypeForm">
4141
<element name="conditionsListText" type="text" selector="//label[contains(@class,'admin__field-label')]//span[text()='Condition']"/>
4242
<element name="conditionsList" type="text" selector=".rule-param-children"/>
43-
<element name="conditionsListAddButton" type="button" selector=".rule-param-new-child img"/>
44-
<element name="conditionsListAddTypeSelect" type="select" selector=".rule-param-new-child select"/>
43+
<element name="conditionsListAddButton" type="button" selector="(//*[contains(@class,'rule-param-new-child')]//img)[{{arg1}}]" parameterized="true"/>
44+
<element name="conditionsListAddTypeSelect" type="select" selector="(//*[contains(@class,'rule-param-new-child')]//select)[{{arg1}}]" parameterized="true"/>
4545
<element name="conditionsListConditionPlaceholder" type="button" selector="//ul[contains(@class,'rule-param-children')]//a[text()='...']"/>
4646
<element name="conditionsListConditionInput" type="button" selector=".rule-param-edit input"/>
47-
<element name="conditionsListConditionApply" type="button" selector=".rule-param-apply img"/>
4847
<element name="conditionsListSavedValue" type="text" selector="//ul[contains(@class,'rule-param-children')]//li[{{arg1}}]//span[@class='rule-param'][{{arg2}}]/a" parameterized="true"/>
49-
<element name="productsCountInput" type="input" selector="input[name='products_count']"/>
5048
<element name="conditionsCombinationAggregateSelector" type="button" selector="//ul[contains(@class,'rule-param-children')]//span[contains(@class,'rule-param')]//select[contains(@id,'1--{{arg1}}__aggregator')]/ancestor::span[contains(@class,'rule-param')]//a" parameterized="true"/>
51-
<element name="conditionsCombinationAggregateBooleanSelector" type="button" selector="//ul[contains(@class,'rule-param-children')]//span[contains(@class,'rule-param')]//select[contains(@id,'1--{{arg1}}__value')]/ancestor::span[contains(@class,'rule-param')]//a" parameterized="true"/>
5249
<element name="conditionsCombinationAggregateSelectorSelect" type="button" selector="//ul[contains(@class,'rule-param-children')]//span[contains(@class,'rule-param')]//select[contains(@id,'1--{{arg1}}__aggregator')]" parameterized="true"/>
50+
<element name="conditionsCombinationAggregateBooleanSelector" type="button" selector="//ul[contains(@class,'rule-param-children')]//span[contains(@class,'rule-param')]//select[contains(@id,'1--{{arg1}}__value')]/ancestor::span[contains(@class,'rule-param')]//a" parameterized="true"/>
5351
<element name="conditionsCombinationAggregateBooleanSelectorSelect" type="button" selector="//ul[contains(@class,'rule-param-children')]//span[contains(@class,'rule-param')]//select[contains(@id,'1--{{arg1}}__value')]" parameterized="true"/>
52+
<element name="productsCountInput" type="input" selector="input[name='products_count']"/>
5453
</section>
5554
<section name="ProductsOnStorefront">
5655
<element name="base" type="text" selector="(//div[contains(@data-content-type,'products')])[{{arg1}}]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1914,9 +1914,8 @@
19141914
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditAfterDrop">
19151915
<argument name="contentType" value="PageBuilderProductsContentType"/>
19161916
</actionGroup>
1917-
<actionGroup ref="addCategoryConditionToProductsBlock" stepKey="addCategory">
1918-
<argument name="page" value="ProductsContentTypeForm"/>
1919-
<argument name="category" value="$$createCategory.id$$"/>
1917+
<actionGroup ref="addConditionToProductConditions" stepKey="addCategory">
1918+
<argument name="conditionInput" value="$$createCategory.id$$"/>
19201919
</actionGroup>
19211920
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
19221921
<actionGroup ref="validateProductCountInProducts" stepKey="validateProductsCountStage">

0 commit comments

Comments
 (0)