PB-173: Add Carousel Settings to Product Appearance

- Fixing failing tests

Author: dhaecker

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup.xml

@@ -429,31 +429,35 @@
             <argument name="page" defaultValue="ProductsCarouselOnStage"/>
             <argument name="productGroupIndex" defaultValue="1" type="string"/>
             <argument name="centerProductIndex" defaultValue="3" type="string"/>
+            <argument name="acceptableOffset" defaultValue="2" type="string"/>
         </arguments>
         <executeJS function="return document.evaluate(&quot;{{page.productInCarouselNotClonedBySlickByIndex(productGroupIndex, centerProductIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().right" stepKey="rightPositionOfMiddleProduct"/>
         <executeJS function="return document.evaluate(&quot;{{page.productInCarouselNotClonedBySlickByIndex(productGroupIndex, centerProductIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().width" stepKey="widthOfMiddleProduct"/>
         <executeJS function="return Math.abs({$rightPositionOfMiddleProduct} - ({$widthOfMiddleProduct} / 2))" stepKey="centerPositionOfMiddleProduct"/>
         <executeJS function="return document.evaluate(&quot;{{page.base(productGroupIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().right" stepKey="rightPositionOfProductGroup"/>
         <executeJS function="return document.evaluate(&quot;{{page.base(productGroupIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().width" stepKey="widthOfProductGroup"/>
         <executeJS function="return Math.abs({$rightPositionOfProductGroup} - ({$widthOfProductGroup} / 2))" stepKey="centerPositionOfProductGroup"/>
-        <assertEquals stepKey="assertProductsAreCentered">
-            <expectedResult type="variable">centerPositionOfProductGroup</expectedResult>
-            <actualResult type="variable">centerPositionOfMiddleProduct</actualResult>
-        </assertEquals>
+        <executeJS function="return Math.abs({$centerPositionOfProductGroup} - {$centerPositionOfMiddleProduct})" stepKey="differenceBetweenCenterPositions"/>
+        <assertLessThanOrEqual stepKey="assertCenterPositionAcceptable">
+            <expectedResult type="int">{{acceptableOffset}}</expectedResult>
+            <actualResult type="variable">differenceBetweenCenterPositions</actualResult>
+        </assertLessThanOrEqual>
     </actionGroup>
     <actionGroup name="validateProductsInProductCarouselAreCenteredForEvenNumberOfProducts">
         <arguments>
             <argument name="page" defaultValue="ProductsCarouselOnStage"/>
             <argument name="productGroupIndex" defaultValue="1" type="string"/>
             <argument name="adjacentLeftOfCenterProductIndex" defaultValue="1" type="string"/>
+            <argument name="acceptableOffset" defaultValue="2" type="string"/>
         </arguments>
         <executeJS function="return document.evaluate(&quot;{{page.productInCarouselNotClonedBySlickByIndex(productGroupIndex, adjacentLeftOfCenterProductIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().right" stepKey="rightPositionOfAdjacentLeftOfCenterProduct"/>
         <executeJS function="return document.evaluate(&quot;{{page.base(productGroupIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().right" stepKey="rightPositionOfProductGroup"/>
         <executeJS function="return document.evaluate(&quot;{{page.base(productGroupIndex)}}&quot;, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue.getBoundingClientRect().width" stepKey="widthOfProductGroup"/>
         <executeJS function="return Math.abs({$rightPositionOfProductGroup} - ({$widthOfProductGroup} / 2))" stepKey="centerPositionOfProductGroup"/>
-        <assertEquals stepKey="assertProductsAreCentered">
-            <expectedResult type="variable">centerPositionOfProductGroup</expectedResult>
-            <actualResult type="variable">rightPositionOfAdjacentLeftOfCenterProduct</actualResult>
-        </assertEquals>
+        <executeJS function="return Math.abs({$centerPositionOfProductGroup} - {$rightPositionOfAdjacentLeftOfCenterProduct})" stepKey="differenceBetweenCenterPositions"/>
+        <assertLessThanOrEqual stepKey="assertCenterPositionAcceptable">
+            <expectedResult type="int">{{acceptableOffset}}</expectedResult>
+            <actualResult type="variable">differenceBetweenCenterPositions</actualResult>
+        </assertLessThanOrEqual>
     </actionGroup>
 </actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Data/ProductsData.xml

@@ -177,7 +177,7 @@
     </entity>
     <entity name="PageBuilderProductsCarouselCountPropertyThree" type="pagebuilder_products_carousel_number_of_products">
         <data key="name">Number of Products to Display</data>
-        <data key="section">general</data>
+        <data key="section">appearance_fieldset</data>
         <data key="fieldName">carousel_products_count</data>
         <data key="value">3</data>
     </entity>
@@ -189,7 +189,7 @@
     </entity>
     <entity name="PageBuilderProductsCarouselCountPropertyFive" type="pagebuilder_products_carousel_number_of_products">
         <data key="name">Number of Products to Display</data>
-        <data key="section">general</data>
+        <data key="section">appearance_fieldset</data>
         <data key="fieldName">carousel_products_count</data>
         <data key="value">5</data>
     </entity>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCarouselTests.xml

@@ -2334,7 +2334,7 @@
             <argument name="product" value="$$createProduct6$$"/>
         </actionGroup>
         <!-- Validate Stage: Verify Autoplay Occurs -->
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel"/>
         <wait time="12" stepKey="waitForAutoplayStage"/>
         <actionGroup ref="validateProductCarouselNavigationDots" stepKey="validateProductCarouselNavigationDotsStage2">
             <argument name="activeNavigationDot" value="2"/>
@@ -2361,7 +2361,7 @@
             <argument name="product" value="$$createProduct6$$"/>
         </actionGroup>
         <!-- Validate Stage: Verify Autoplay Reoccurs -->
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel2"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel2"/>
         <wait time="12" stepKey="waitForAutoplayStage2"/>
         <actionGroup ref="validateProductCarouselNavigationDots" stepKey="validateProductCarouselNavigationDotsStage4">
             <argument name="activeNavigationDot" value="2"/>
@@ -2389,7 +2389,7 @@
             <argument name="product" value="$$createProduct6$$"/>
         </actionGroup>
         <!-- Validate Stage: Verify Autoplay Reoccurs Again -->
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel3"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel3"/>
         <wait time="12" stepKey="waitForAutoplayStage3"/>
         <actionGroup ref="validateProductCarouselNavigationDots" stepKey="validateProductCarouselNavigationDotsStage6">
             <argument name="activeNavigationDot" value="2"/>
@@ -2577,14 +2577,14 @@
         <actionGroup ref="clickProductCarouselNavigationDot" stepKey="clickFirstNavigationDotStage3">
             <argument name="navigationDotIndex" value="2"/>
         </actionGroup>
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel4" after="clickFirstNavigationDotStage3"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel4" after="clickFirstNavigationDotStage3"/>
         <wait time="12" stepKey="waitForAutoplayStage4" after="clickLeftPanel4"/>
         <actionGroup ref="validateProductCarouselPreviousNavigationArrowEnabled" stepKey="validateProductCarouselPreviousNavigationArrowDisabledStage3"/>
         <actionGroup ref="validateProductCarouselNextNavigationArrowEnabled" stepKey="validateProductCarouselNextNavigationArrowDisabledStage4"/>
         <actionGroup ref="clickProductCarouselNavigationDot" stepKey="clickPreviousNavigationArrowStage5">
             <argument name="navigationDotIndex" value="2"/>
         </actionGroup>
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel5" after="clickPreviousNavigationArrowStage5"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel5" after="clickPreviousNavigationArrowStage5"/>
         <wait time="12" stepKey="waitForAutoplayStage5" after="clickLeftPanel5"/>
         <actionGroup ref="validateProductCarouselPreviousNavigationArrowEnabled" stepKey="validateProductCarouselPreviousNavigationArrowDisabledStage5"/>
         <actionGroup ref="validateProductCarouselNextNavigationArrowEnabled" stepKey="validateProductCarouselNextNavigationArrowDisabledStage6"/>
@@ -2749,7 +2749,7 @@
             <argument name="productItemIndex" value="4"/>
         </actionGroup>
         <!-- Validate Stage: Verify Autoplay Occurs -->
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel"/>
         <wait time="12" stepKey="waitForAutoplayStage"/>
         <actionGroup ref="validateProductCarouselNavigationDots" stepKey="validateProductCarouselNavigationDotsStage2">
             <argument name="navigationDotCount" value="6"/>
@@ -2784,7 +2784,7 @@
             <argument name="productItemIndex" value="1"/>
         </actionGroup>
         <!-- Validate Stage: Verify Autoplay Reoccurs -->
-        <click selector="{{PageBuilderPanel.leftPanel}}" stepKey="clickLeftPanel2"/>
+        <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="clickLeftPanel2"/>
         <wait time="12" stepKey="waitForAutoplayStage2"/>
         <actionGroup ref="validateProductCarouselNavigationDots" stepKey="validateProductCarouselNavigationDotsStage4">
             <argument name="navigationDotCount" value="6"/>