Skip to content

Commit eaf9a27

Browse files
author
Hwashiang Yu
committed
MC-843: Heading live edit should become unfocused on drag action
- Added index to toolbar selector - Added inline comments to test - Updated test severity
1 parent 08502be commit eaf9a27

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHeadingSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<element name="headingOnStage" type="text" selector="(//{{arg1}}[contains(@data-bind,'heading_text')])[{{arg2}}]" parameterized="true"/>
1818
<element name="headingType" type="button" selector="(//{{arg1}})[{{arg2}}]" parameterized="true"/>
1919
<element name="headingEditableText" type="button" selector="(//div[contains(@class, 'pagebuilder-heading')])[{{arg1}}]//h2[contains(@contenteditable, 'true')]" parameterized="true"/>
20-
<element name="headingToolbar" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])//div[contains(@class, 'pagebuilder-toolbar-options')]"/>
20+
<element name="headingToolbar" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])//div[contains(@class, 'pagebuilder-toolbar-options')][{{arg1}}]" parameterized="true"/>
2121
<element name="headingTypeToolbar" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//span[text()='{{arg2}}']" parameterized="true"/>
2222
<element name="headingTypeToolbarSelected" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//a[contains(@class, 'toolbar-active')]//span[text()='{{arg2}}']" parameterized="true"/>
2323
<element name="headingTextAlignToolbar" type="button" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]//i[contains(@class,'icon-pagebuilder-align-{{arg2}}')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingEditOnStageTest.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1580,7 +1580,7 @@
15801580
<stories value="Heading"/>
15811581
<title value="Stage Edit - Heading Toolbar should hide on drag action"/>
15821582
<description value="Heading live edit should become unfocused on drag action"/>
1583-
<severity value="CRITICAL"/>
1583+
<severity value="MINOR"/>
15841584
<useCaseId value="MC-843"/>
15851585
<testCaseId value="MC-3540"/>
15861586
<group value="pagebuilder"/>
@@ -1600,16 +1600,18 @@
16001600
<actionGroup ref="dragContentTypeToStage" stepKey="dragHeadingIntoStage">
16011601
<argument name="contentType" value="PageBuilderHeadingContentType"/>
16021602
</actionGroup>
1603-
<waitForPageLoad stepKey="waitForAnimation" time="30"/>
1603+
<!-- Validate Heading edit toolbar shows after dragging in -->
16041604
<comment userInput="Validate Heading edit toolbar" stepKey="CommentHeadingEditToolbar"/>
1605-
<seeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="seeHeadingToolbar"/>
1605+
<seeElement selector="{{HeadingOnStage.headingToolbar('1')}}" stepKey="seeHeadingToolbar"/>
1606+
<!-- Check if clicking on draggable content, the heading input loses focus and the toolbar hides -->
16061607
<comment userInput="When click on draggable content, heading input loses focus, toolbar disappears, and placeholder displays Enter Heading Text" stepKey="commentClickOnDraggable"/>
16071608
<click selector="{{PageBuilderPanel.draggableContentTypeInPanel(PageBuilderHeadingContentType.name)}}" stepKey="clickDraggableInPanel"/>
1608-
<dontSeeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="dontSeeHeadingToolbar"/>
1609+
<dontSeeElement selector="{{HeadingOnStage.headingToolbar('1')}}" stepKey="dontSeeHeadingToolbar"/>
1610+
<!-- Check if heading toolbar shows after focusing on heading content type -->
16091611
<comment userInput="When click inside heading see heading input gain focus, placeholder disappears and WYSIWYG toolbar appears" stepKey="commentClickInsideHeading"/>
16101612
<actionGroup ref="clickInsideLiveEditHeading" stepKey="clickInsideLiveEditHeading">
16111613
<argument name="index" value="1"/>
16121614
</actionGroup>
1613-
<seeElement selector="{{HeadingOnStage.headingToolbar}}" stepKey="seeHeadingToolbar2"/>
1615+
<seeElement selector="{{HeadingOnStage.headingToolbar('1')}}" stepKey="seeHeadingToolbar2"/>
16141616
</test>
16151617
</tests>

0 commit comments

Comments
 (0)