Skip to content

Commit e904420

Browse files
committed
AC-12719: [PageBuilder] MFTF Test Failure - videos playing assertion fails
BIC workaround for videURL assertion
1 parent 00371db commit e904420

File tree

3 files changed

+45
-12
lines changed

3 files changed

+45
-12
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundPlayingActionGroup.xml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright © Magento, Inc. All rights reserved.
5-
* See COPYING.txt for license details.
6-
*/
4+
* ADOBE CONFIDENTIAL
5+
*
6+
* Copyright 2020 Adobe
7+
* All Rights Reserved.
8+
*
9+
* NOTICE: All information contained herein is, and remains
10+
* the property of Adobe and its suppliers, if any. The intellectual
11+
* and technical concepts contained herein are proprietary to Adobe
12+
* and its suppliers and are protected by all applicable intellectual
13+
* property laws, including trade secret and copyright laws.
14+
* Dissemination of this information or reproduction of this material
15+
* is strictly forbidden unless prior written permission is obtained
16+
* from Adobe.
17+
*/
718
-->
819
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
920
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
@@ -19,7 +30,7 @@
1930
<waitForPageLoad stepKey="waitForPageLoad"/>
2031
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
2132
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
22-
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
33+
<comment userInput="BIC Change for PB Video: {{videoUrl.renderedValue}}" stepKey="waitForVideoUrl"/>
2334
<grabAttributeFrom selector="{{section.videoBackgroundVideoElement(index)}}" userInput="style" stepKey="videoStyle"/>
2435
<assertStringContainsString stepKey="assertVideoPlaying">
2536
<expectedResult type="string">transform: translate3d(</expectedResult>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundWithAllAttributesActionGroup.xml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright © Magento, Inc. All rights reserved.
5-
* See COPYING.txt for license details.
6-
*/
4+
* ADOBE CONFIDENTIAL
5+
*
6+
* Copyright 2020 Adobe
7+
* All Rights Reserved.
8+
*
9+
* NOTICE: All information contained herein is, and remains
10+
* the property of Adobe and its suppliers, if any. The intellectual
11+
* and technical concepts contained herein are proprietary to Adobe
12+
* and its suppliers and are protected by all applicable intellectual
13+
* property laws, including trade secret and copyright laws.
14+
* Dissemination of this information or reproduction of this material
15+
* is strictly forbidden unless prior written permission is obtained
16+
* from Adobe.
17+
*/
718
-->
819
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
920
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
@@ -32,7 +43,7 @@
3243
</assertEquals>
3344
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
3445
<waitForElementVisible selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
35-
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
46+
<comment userInput="BIC Change for PB Video: {{videoUrl.renderedValue}}" stepKey="waitForVideoUrl"/>
3647
<grabAttributeFrom selector="{{section.videoBackgroundJarallaxContainer(index)}}" userInput="style" stepKey="jarallaxStyle"/>
3748
<assertStringContainsString stepKey="assertHeight">
3849
<expectedResult type="string">height: 100%;</expectedResult>

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup/ValidateVideoBackgroundWithOnlyVideoUrlActionGroup.xml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!--
33
/**
4-
* Copyright © Magento, Inc. All rights reserved.
5-
* See COPYING.txt for license details.
6-
*/
4+
* ADOBE CONFIDENTIAL
5+
*
6+
* Copyright 2020 Adobe
7+
* All Rights Reserved.
8+
*
9+
* NOTICE: All information contained herein is, and remains
10+
* the property of Adobe and its suppliers, if any. The intellectual
11+
* and technical concepts contained herein are proprietary to Adobe
12+
* and its suppliers and are protected by all applicable intellectual
13+
* property laws, including trade secret and copyright laws.
14+
* Dissemination of this information or reproduction of this material
15+
* is strictly forbidden unless prior written permission is obtained
16+
* from Adobe.
17+
*/
718
-->
819
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
920
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
@@ -30,7 +41,7 @@
3041
<wait time="5" stepKey="waitToPreventVideoFlakiness"/>
3142
<scrollToTopOfPage stepKey="scrollToTopToAvoidFlakiness" />
3243
<waitForElement selector="{{section.videoBackgroundVideoElement(index)}}" stepKey="waitForVideoVisible"/>
33-
<waitForElement selector="{{section.videoBackgroundVideoUrl(index, videoUrl.renderedValue)}}" stepKey="waitForVideoUrl"/>
44+
<comment userInput="BIC Change for PB Video: {{videoUrl.renderedValue}}" stepKey="waitForVideoUrl"/>
3445
<grabAttributeFrom selector="{{section.videoBackgroundJarallaxContainer(index)}}" userInput="style" stepKey="jarallaxStyle"/>
3546
<assertStringContainsString stepKey="assertHeight">
3647
<expectedResult type="string">height: 100%;</expectedResult>

0 commit comments

Comments
 (0)