Skip to content

Commit e7b0b8d

Browse files
committed
PB-378: Full height Banner
- Fixing broken tests
1 parent eebe5ae commit e7b0b8d

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/LayoutConfigurationActionGroup.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@
8080
<actualResult type="variable">contentTypeHeightDifference</actualResult>
8181
</assertLessThanOrEqual>
8282
</actionGroup>
83-
84-
8583
<actionGroup name="validateContentTypeHeightGreaterThanMinHeight">
8684
<arguments>
8785
<argument name="content" type="string"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,18 +1614,18 @@
16141614
</actionGroup>
16151615
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightBeforeSave">
16161616
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
1617-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1617+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
16181618
</actionGroup>
16191619
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightAfterSave">
16201620
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
1621-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1621+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
16221622
</actionGroup>
16231623
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
16241624
<argument name="contentType" value="PageBuilderBannerContentType"/>
16251625
</actionGroup>
16261626
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateContentTypeHeightStorefront">
16271627
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
1628-
<argument name="border" value="PageBuilderAdvancedBorderWidthProperty10"/>
1628+
<argument name="borderWidth" value="{{PageBuilderAdvancedBorderWidthProperty10.value}}"/>
16291629
</actionGroup>
16301630
</test>
16311631
<test name="BannerPosterHtmlValueInButtons" extends="BannerCollageCenterHtmlValueInButtons">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockRenderMediaContentTypesTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@
547547
<seeElement selector="{{BannerOnBackend.posterMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSBlockStage"/>
548548
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSBlockStage">
549549
<argument name="content" value="{{BannerOnBackend.wrapperCSS}}"/>
550-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
550+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
551551
</actionGroup>
552552
<actionGroup ref="validateBackgroundAttributesWithNoImage" stepKey="validateBackgroundAttributesCMSBlockStage">
553553
<argument name="section" value="BannerOnBackend"/>
@@ -609,7 +609,7 @@
609609
<seeElement selector="{{BannerOnFrontend.posterMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStage"/>
610610
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStage">
611611
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
612-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
612+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
613613
</actionGroup>
614614
<actionGroup ref="validateBackgroundAttributesWithNoImage" stepKey="validateBackgroundAttributesCMSPageStage">
615615
<argument name="section" value="BannerOnFrontend"/>
@@ -652,7 +652,7 @@
652652
<seeElement selector="{{BannerOnFrontend.posterMinimumHeight('1', PageBuilderMinHeightProperty_500px.value)}}" stepKey="seeMinimumHeightCMSPageStorefront"/>
653653
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStorefront">
654654
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
655-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
655+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
656656
</actionGroup>
657657
<actionGroup ref="validateBackgroundAttributesWithNoImage" stepKey="validateBackgroundAttributesCMSPageStorefront">
658658
<argument name="section" value="BannerOnFrontend"/>
@@ -703,7 +703,7 @@
703703
</actionGroup>
704704
<actionGroup ref="validateContentTypeHeightEqualToMinHeightPlusPaddingAndBorder" stepKey="validateHeightCMSPageStorefrontMobile">
705705
<argument name="content" value="{{BannerOnFrontend.wrapperCSS}}"/>
706-
<argument name="height" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
706+
<argument name="minHeight" value="{{PageBuilderMinHeightProperty_500px.intValue}}"/>
707707
</actionGroup>
708708
<actionGroup ref="validateBackgroundImageContainer" stepKey="validateBackgroundImageCMSPageStorefrontMobile">
709709
<argument name="section" value="BannerOnFrontend"/>

0 commit comments

Comments
 (0)