Skip to content

Commit e6988c0

Browse files
author
Hwashiang Yu
committed
MC-4075: Alignment attribute not working as expected for product, map, divider, video
- Reverted video data to use advancedData
1 parent 4d05752 commit e6988c0

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/VideoData.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,4 @@
5050
<data key="fieldName">max_width</data>
5151
<data key="value">500</data>
5252
</entity>
53-
<!-- Advanced -->
54-
<entity name="PageBuilderVideoAdvancedAlignmentPropertyRight" type="pagebuilder_video_advanced_alignment_property">
55-
<data key="name">Alignment</data>
56-
<data key="section">advanced</data>
57-
<data key="fieldName">text_align</data>
58-
<data key="value">right</data>
59-
</entity>
6053
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@
414414
<!-- Update Values -->
415415
<comment userInput="Update Values" stepKey="commentUpdateValues"/>
416416
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAlignment">
417-
<argument name="property" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
417+
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
418418
</actionGroup>
419419
<actionGroup ref="selectSlideOutPanelField" stepKey="enterBorder">
420420
<argument name="property" value="PageBuilderAdvancedBorderPropertyDouble"/>
@@ -442,7 +442,7 @@
442442
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
443443
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStage">
444444
<argument name="page" value="VideoOnStage"/>
445-
<argument name="alignment" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
445+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyRight"/>
446446
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
447447
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>
448448
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
@@ -458,7 +458,7 @@
458458
<!-- Validate Edit Panel -->
459459
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
460460
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment">
461-
<argument name="property" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
461+
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
462462
</actionGroup>
463463
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBorder">
464464
<argument name="property" value="PageBuilderAdvancedBorderPropertyDouble"/>
@@ -488,7 +488,7 @@
488488
<comment userInput="Validate Stage After Save" stepKey="commentValidateStage2"/>
489489
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStage2">
490490
<argument name="page" value="VideoOnStage"/>
491-
<argument name="alignment" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
491+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyRight"/>
492492
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
493493
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>
494494
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
@@ -504,7 +504,7 @@
504504
<!-- Validate Edit Panel After Save -->
505505
<comment userInput="Validate Edit Panel After Save" stepKey="commentValidateEditPanel2"/>
506506
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateAlignment2">
507-
<argument name="property" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
507+
<argument name="property" value="PageBuilderAdvancedAlignmentPropertyRight"/>
508508
</actionGroup>
509509
<actionGroup ref="seeOptionIsSelectedSlideOutProperty" stepKey="validateBorder2">
510510
<argument name="property" value="PageBuilderAdvancedBorderPropertyDouble"/>
@@ -534,7 +534,7 @@
534534
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
535535
<actionGroup ref="validateAdvancedStyleWithAllUpdated" stepKey="validateAllAdvancedStorefront">
536536
<argument name="page" value="VideoOnStorefront"/>
537-
<argument name="alignment" value="PageBuilderVideoAdvancedAlignmentPropertyRight"/>
537+
<argument name="alignment" value="PageBuilderAdvancedAlignmentPropertyRight"/>
538538
<argument name="border" value="PageBuilderAdvancedBorderPropertyDouble"/>
539539
<argument name="borderColor" value="PageBuilderAdvancedBorderColorProperty_green"/>
540540
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>

0 commit comments

Comments
 (0)