Skip to content

Commit e69228e

Browse files
committed
MC-35402: [Page Builder] New top-level Full-Width and Full-Bleed components are always nested in a Contained component
- Fixing MFTF CR feedback
1 parent 99529e6 commit e69228e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StorefrontActionGroup/ValidateCategoryDescriptionAppearanceStorefrontActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="validateCategoryDescriptionAppearanceStorefrontActionGroup">
10+
<actionGroup name="StorefrontValidateCategoryDescriptionAppearanceActionGroup">
1111
<annotations>
12-
<description>Validates data-appearance attribute value for the category-description first direct child row.</description>
12+
<description>Validates the data-appearance attribute value for the category-description first direct child row.</description>
1313
</annotations>
1414
<arguments>
1515
<argument name="dataAppearance" defaultValue="contained" type="string"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogCategoryPageBuilderTest/PageBuilderCatalogCategoryCreateCategoryWithPageBuilderDescriptionAppearanceTest.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Catalog Category"/>
14-
<title value="Category description should be properly displayed with a selected appearance type"/>
15-
<description value="Validate the proper value of Category description top-level row's data-appearance on storefront"/>
14+
<title value="Validate Category Description Row Appearance"/>
15+
<description value="Validates the proper value of Category description top-level row's data-appearance on storefront"/>
1616
<severity value="CRITICAL"/>
1717
<useCaseId value="MC-35402"/>
1818
<testCaseId value="MC-37710"/>
@@ -33,6 +33,7 @@
3333
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/>
3434
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3535
</after>
36+
<!-- Set Category Description Row to Full-Width -->
3637
<actionGroup ref="openPageBuilderForAttribute" stepKey="enablePageBuilderOnCatalog"/>
3738
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
3839
<argument name="contentType" value="PageBuilderRowContentType"/>
@@ -41,26 +42,28 @@
4142
<argument name="property" value="PageBuilderRowAppearance_FullWidth"/>
4243
</actionGroup>
4344
<actionGroup ref="saveEditPanelSettingsFullScreen" stepKey="saveEditPanelSettings"/>
45+
<!-- Add Heading to Row -->
4446
<actionGroup ref="expandPageBuilderPanelMenuSection" stepKey="expandPageBuilderPanelMenuSection">
4547
<argument name="contentType" value="PageBuilderHeadingContentType"/>
4648
</actionGroup>
4749
<actionGroup ref="dragContentTypeToStage" stepKey="dragHeadingOntoStage">
4850
<argument name="contentType" value="PageBuilderHeadingContentType"/>
4951
</actionGroup>
50-
<comment userInput="Add heading to stage" stepKey="commentAddHeadingToStage"/>
5152
<actionGroup ref="enterHeadingOnStage" stepKey="enterHeadingOnStage">
5253
<argument name="headingText" value="PageBuilderHeadingTextProperty"/>
5354
</actionGroup>
5455
<actionGroup ref="exitPageBuilderFullScreen" stepKey="exitPageBuilderFullScreen"/>
56+
<!-- Set Category Layout and Save -->
5557
<actionGroup ref="SetLayoutActionGroup" stepKey="setFullWidthLayout">
5658
<argument name="designSection" value="CategoryDesignSection"/>
5759
<argument name="layoutOption" value="PageBuilderFullWidthLayout.category"/>
5860
</actionGroup>
5961
<actionGroup ref="saveCatalogCategory" stepKey="saveCatalogCategory"/>
62+
<!-- Validate Storefront Category Description Row Appearance -->
6063
<actionGroup ref="NavigateToStorefrontForCreatedPageActionGroup" stepKey="navigateToStorefront">
6164
<argument name="page" value="$createPreReqCategory.name$.html"/>
6265
</actionGroup>
63-
<actionGroup ref="validateCategoryDescriptionAppearanceStorefrontActionGroup" stepKey="validateDataAppearance">
66+
<actionGroup ref="StorefrontValidateCategoryDescriptionAppearanceActionGroup" stepKey="validateDataAppearance">
6467
<argument name="dataAppearance" value="full-width"/>
6568
</actionGroup>
6669
</test>

0 commit comments

Comments
 (0)