Skip to content

Commit e452651

Browse files
author
Hwashiang Yu
committed
MC-5810: Improve naming of the critical variables/parameters in the code and configuration
- Contextualized constructor parent variable
1 parent b0d460a commit e452651

File tree

12 files changed

+34
-34
lines changed

12 files changed

+34
-34
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type-factory.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/heading/preview.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/row/preview.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/slider/preview.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type-factory.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import loadModule from "./utils/loader";
1818
* Create new content type
1919
*
2020
* @param {ContentTypeConfigInterface} config
21-
* @param {ContentTypeInterface} parent
21+
* @param {ContentTypeInterface} containerContentType
2222
* @param {number} stageId
2323
* @param {object} data
2424
* @param {number} childrenLength
@@ -27,7 +27,7 @@ import loadModule from "./utils/loader";
2727
*/
2828
export default function createContentType(
2929
config: ContentTypeConfigInterface,
30-
parent: ContentTypeCollectionInterface,
30+
containerContentType: ContentTypeCollectionInterface,
3131
stageId: string,
3232
data: object = {},
3333
childrenLength: number = 0,
@@ -39,7 +39,7 @@ export default function createContentType(
3939
loadModule([config.component], (contentTypeComponent: typeof ContentType) => {
4040
try {
4141
const contentType = new contentTypeComponent(
42-
parent,
42+
containerContentType,
4343
config,
4444
stageId,
4545
);

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ export default class Preview extends BasePreview {
3737
* @inheritdoc
3838
*/
3939
constructor(
40-
parent: ContentTypeInterface,
40+
master: ContentTypeInterface,
4141
config: ContentTypeConfigInterface,
4242
observableUpdater: ObservableUpdater,
4343
) {
44-
super(parent, config, observableUpdater);
44+
super(master, config, observableUpdater);
4545
this.placeholderText = ko.observable(this.messages.NOT_SELECTED);
4646
}
4747

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/heading/preview.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ export default class Preview extends BasePreview {
2424
private element: Element;
2525

2626
/**
27-
* @param {ContentTypeInterface} parent
27+
* @param {ContentTypeInterface} master
2828
* @param {ContentTypeConfigInterface} config
2929
* @param {ObservableUpdater} observableUpdater
3030
*/
3131
constructor(
32-
parent: ContentTypeInterface,
32+
master: ContentTypeInterface,
3333
config: ContentTypeConfigInterface,
3434
observableUpdater: ObservableUpdater,
3535
) {
36-
super(parent, config, observableUpdater);
36+
super(master, config, observableUpdater);
3737
this.toolbar = new Toolbar(
3838
this,
3939
this.getToolbarOptions(),

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/products/preview.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ export default class Preview extends BasePreview {
3131
* @inheritdoc
3232
*/
3333
constructor(
34-
parent: ContentTypeInterface,
34+
master: ContentTypeInterface,
3535
config: ContentTypeConfigInterface,
3636
observableUpdater: ObservableUpdater,
3737
) {
38-
super(parent, config, observableUpdater);
38+
super(master, config, observableUpdater);
3939
this.placeholderText = ko.observable(this.messages.EMPTY);
4040
}
4141

0 commit comments

Comments
 (0)