Skip to content

Commit e3df199

Browse files
committed
MC-1438: Editing Text Content Block from the Stage with WYSIWYG turned off completely or by default
1 parent f9c76a9 commit e3df199

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/TextData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<data key="fieldName">text</data>
1616
<data key="cmsPageLinkName" unique="suffix">cms-page-link-</data>
1717
<data key="value">test string</data>
18+
<data key="minHeight">50px</data>
1819
</entity>
1920
<entity name="PageBuilderTextContentTypeDefault" type="pagebuilder_text_property">
2021
<data key="name">Text</data>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010
<section name="TextOnStage">
1111
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div" parameterized="true"/>
12-
<element name="textAreaText" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//div[.='{{arg2}}']" parameterized="true"/>
12+
<element name="textAreaText" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]//*[.='{{arg2}}']" parameterized="true"/>
1313
<element name="textAreaTextContains" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div[contains(.,'{{arg2}}')]" parameterized="true"/>
1414
<element name="text" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[contains(.,'{{arg2}}')]" parameterized="true"/>
1515
<element name="mcePlaceholder" type="text" selector="(//div[contains(@class,'pagebuilder-text')])[{{arg1}}]/div//*[starts-with(@id, '{{arg2}}')]" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
<executeJS function="return jQuery('.inline-wysiwyg-textarea').css('min-height');" stepKey="height"/>
4747
<assertEquals stepKey="assertMinHeight">
4848
<actualResult type="variable">height</actualResult>
49-
<expectedResult type="string">50px</expectedResult>
49+
<expectedResult type="string">{{PageBuilderTextProperty.minHeight}}</expectedResult>
5050
</assertEquals>
5151
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>
5252
<!--Verify empty content type on storefront-->
@@ -94,9 +94,10 @@
9494
<click selector="{{TextOnStage.textareaPlaceholder('1')}}" stepKey="focusOnEditorArea"/>
9595
<fillField selector="{{TextOnStage.textareaPlaceholder('1')}}" userInput="{{PageBuilderTextProperty.value}}" stepKey="fillTextToTextarea"/>
9696
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="lostFocusFromTextarea"/>
97-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
97+
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
9898
<!-- Validate Stage -->
9999
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
100+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
100101
<waitForElementVisible selector="{{TextOnStage.textAreaText('1', PageBuilderTextProperty.value)}}" stepKey="waitForTextStage1"/>
101102
<!--Verify inputed text on slideout-->
102103
<comment userInput="Verify inputed text on slideout" stepKey="commentVerifyTextOnSlideout"/>
@@ -106,7 +107,7 @@
106107
<executeJS function="return document.getElementById('{{TextOnConfiguration.textAreaId}}').value;" stepKey="getText"/>
107108
<assertContains stepKey="assertEquals1" message="pass">
108109
<expectedResult type="string">{{PageBuilderTextProperty.value}}</expectedResult>
109-
<actualResult type="variable">getText</actualResult>
110+
<actualResult type="variable">$getText</actualResult>
110111
</assertContains>
111112
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
112113
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage2"/>

0 commit comments

Comments
 (0)