Skip to content

Commit e349cd0

Browse files
committed
MC-5405: Column Minimum Height Issues
- make default column height same as row - remove row margins preview converter from row to resolve 1px height difference
1 parent a4e0bf4 commit e349cd0

File tree

2 files changed

+3
-3
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml

2 files changed

+3
-3
lines changed

app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/column.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
<style name="justify_content" source="justify_content" persistence_mode="read"/>
4848
<style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
4949
<style name="width" source="width"/>
50-
<style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins" preview_converter="Magento_PageBuilder/js/content-type/row/converter/style/margins"/>
51-
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings" preview_converter="Magento_PageBuilder/js/content-type/row/converter/style/paddings"/>
50+
<style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
51+
<style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
5252
<static_style source="align_self" value="stretch"/>
5353
<attribute name="name" source="data-role"/>
5454
<attribute name="appearance" source="data-appearance"/>

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/column/_default.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
min-height: inherit;
2525

2626
&.empty-container {
27-
min-height: 190px;
27+
min-height: 300px;
2828
}
2929

3030
.pagebuilder-column-resize-handle {

0 commit comments

Comments
 (0)