Skip to content

Commit e2d3654

Browse files
committed
#609: Content Type Toolbar hidden under PageBuilder header in Full screen - Code Review fixes
1 parent 25fd0a9 commit e2d3654

File tree

2 files changed

+24
-8
lines changed

2 files changed

+24
-8
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/pagebuilder-header-height.js

Lines changed: 14 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/utils/pagebuilder-header-height.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,19 @@
66
import $ from "jquery";
77

88
/**
9-
* Checks if PageBuilder has header and return it's height
9+
* Checks if PageBuilder has header and returns it's height
1010
*
1111
* @param {string} stageId
12+
* @param {string} stageWrapper
13+
* @param {string} pageBuilderHeader
1214
* @returns {number}
1315
*/
14-
export default function pageBuilderHeaderHeight(stageId: string): number {
15-
const $stageWrapper = $("#" + stageId).closest('.pagebuilder-stage-wrapper');
16-
const $pageBuilderHeader = $stageWrapper.find('.pagebuilder-header');
16+
export default function pageBuilderHeaderHeight(
17+
stageId: string,
18+
stageWrapper: string = ".pagebuilder-stage-wrapper",
19+
pageBuilderHeader: string = ".pagebuilder-header"
20+
): number {
21+
const $stageWrapper = $("#" + stageId).closest(stageWrapper);
22+
const $pageBuilderHeader = $stageWrapper.find(pageBuilderHeader);
1723
return (!!$pageBuilderHeader.length) ? $pageBuilderHeader.height() : 0;
1824
}

0 commit comments

Comments
 (0)