Skip to content

Commit e2c30c6

Browse files
PB-265: Video background for Banner
- fix safari z-index - fix inline edit
1 parent 57df0cb commit e2c30c6

File tree

6 files changed

+24
-12
lines changed

6 files changed

+24
-12
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/content-type/banner/_default.less

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@
116116
.pagebuilder-banner-wrapper {
117117
.pagebuilder-overlay {
118118
padding: 30px;
119+
position: relative;
120+
}
121+
122+
.video-overlay {
123+
z-index: 0;
119124
}
120125
}
121126

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/banner/collage-centered/preview.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
class="video-overlay"
2020
attr="data.video_overlay.attributes"
2121
ko-style="data.video_overlay.style" />
22+
<scope args="getUploader().getUiComponent()">
23+
<render />
24+
</scope>
2225
<div class="pagebuilder-overlay" css="data.overlay.css" attr="data.overlay.attributes" ko-style="data.overlay.style">
23-
<scope args="getUploader().getUiComponent()">
24-
<render />
25-
</scope>
2626
<div class="pagebuilder-collage-content" event="mousedown: activateEditor">
2727
<div class="pagebuilder-banner-text-content">
2828
<div if="isWysiwygSupported()"

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/banner/collage-left/preview.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
class="video-overlay"
2020
attr="data.video_overlay.attributes"
2121
ko-style="data.video_overlay.style" />
22+
<scope args="getUploader().getUiComponent()">
23+
<render />
24+
</scope>
2225
<div class="pagebuilder-overlay" css="data.overlay.css" attr="data.overlay.attributes" ko-style="data.overlay.style">
23-
<scope args="getUploader().getUiComponent()">
24-
<render />
25-
</scope>
2626
<div class="pagebuilder-collage-content" event="mousedown: activateEditor">
2727
<div class="pagebuilder-banner-text-content">
2828
<div if="isWysiwygSupported()"

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/banner/collage-right/preview.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
class="video-overlay"
2020
attr="data.video_overlay.attributes"
2121
ko-style="data.video_overlay.style" />
22+
<scope args="getUploader().getUiComponent()">
23+
<render />
24+
</scope>
2225
<div class="pagebuilder-overlay" attr="data.overlay.attributes" ko-style="data.overlay.style" css="data.overlay.css">
23-
<scope args="getUploader().getUiComponent()">
24-
<render />
25-
</scope>
2626
<div class="pagebuilder-collage-content" event="mousedown: activateEditor">
2727
<div class="pagebuilder-banner-text-content">
2828
<div if="isWysiwygSupported()"

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/banner/poster/preview.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
class="video-overlay"
2020
attr="data.video_overlay.attributes"
2121
ko-style="data.video_overlay.style" />
22+
<scope args="getUploader().getUiComponent()">
23+
<render />
24+
</scope>
2225
<div class="pagebuilder-overlay pagebuilder-poster-overlay" attr="data.overlay.attributes" ko-style="data.overlay.style" css="data.overlay.css" event="mousedown: activateEditor">
23-
<scope args="getUploader().getUiComponent()">
24-
<render />
25-
</scope>
2626
<div class="pagebuilder-poster-content">
2727
<div class="pagebuilder-banner-text-content">
2828
<div if="isWysiwygSupported()"

app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/banner/_default.less

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
-webkit-transition: background-color 500ms ease;
3333
box-sizing: border-box;
3434
padding: 30px;
35+
position: relative;
3536
transition: background-color 500ms ease;
3637

3738
&.pagebuilder-poster-overlay {
@@ -45,6 +46,12 @@
4546
}
4647
}
4748

49+
&.jarallax {
50+
.video-overlay {
51+
z-index: 0;
52+
}
53+
}
54+
4855
[data-element='content'] {
4956
min-height: 50px;
5057
overflow: auto;

0 commit comments

Comments
 (0)