Skip to content

Commit e2c116f

Browse files
author
Michael Yu
committed
MC-3031: MFTF Test Updates
- Added missing tests - Moved tests to logical files - Updated test comments - Fixed test titles
1 parent 6662480 commit e2c116f

20 files changed

+274
-182
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAccordionTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@
165165
<argument name="contentType" value="PageBuilderAccordionContentType"/>
166166
<argument name="containerTargetType" value="PageBuilderStage"/>
167167
</actionGroup>
168-
<dontSeeElement selector="{{AccordionOnStage.all}}" stepKey="dontSeeAccordion"/>
168+
<dontSeeElementInDOM selector="{{AccordionOnStage.all}}" stepKey="dontSeeAccordion"/>
169169
</test>
170170
<test name="AccordionCanAddToColumn">
171171
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAnchorTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@
803803
<argument name="contentType" value="PageBuilderAnchorContentType"/>
804804
<argument name="containerTargetType" value="PageBuilderStage"/>
805805
</actionGroup>
806-
<dontSeeElement selector="{{AnchorOnStage.base('1')}}" stepKey="dontSeeAnchor"/>
806+
<dontSeeElementInDOM selector="{{AnchorOnStage.base('1')}}" stepKey="dontSeeAnchor"/>
807807
</test>
808808
<test name="AnchorCanAddToColumn">
809809
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1359,7 +1359,7 @@
13591359
<argument name="contentType" value="PageBuilderBannerContentType"/>
13601360
<argument name="containerTargetType" value="PageBuilderStage"/>
13611361
</actionGroup>
1362-
<dontSeeElement selector="{{BannerOnBackend.base('1')}}" stepKey="dontSeeBanner"/>
1362+
<dontSeeElementInDOM selector="{{BannerOnBackend.base('1')}}" stepKey="dontSeeBanner"/>
13631363
</test>
13641364
<test name="BannerCanAddToColumn">
13651365
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@
438438
<argument name="contentType" value="PageBuilderBlockContentType"/>
439439
<argument name="containerTargetType" value="PageBuilderStage"/>
440440
</actionGroup>
441-
<dontSeeElement selector="{{BlockOnStage.base('1')}}" stepKey="dontSeeBlock"/>
441+
<dontSeeElementInDOM selector="{{BlockOnStage.base('1')}}" stepKey="dontSeeBlock"/>
442442
</test>
443443
<test name="BlockCanAddToColumn">
444444
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonGroupTests.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,7 +1447,7 @@
14471447
<annotations>
14481448
<features value="PageBuilder"/>
14491449
<stories value="Buttons"/>
1450-
<title value="Cannot add Buttons to Stage"/>
1450+
<title value="Button Group - Cannot add Buttons to Stage"/>
14511451
<description value="If user drags Buttons to Stage, it should have no effect"/>
14521452
<severity value="CRITICAL"/>
14531453
<useCaseId value="MC-515"/>
@@ -1472,13 +1472,13 @@
14721472
<argument name="contentType" value="PageBuilderButtonsContentType"/>
14731473
<argument name="containerTargetType" value="PageBuilderStage"/>
14741474
</actionGroup>
1475-
<dontSeeElement selector="{{ButtonGroupOnStage.base('1')}}" stepKey="dontSeeButtonGroup"/>
1475+
<dontSeeElementInDOM selector="{{ButtonGroupOnStage.base('1')}}" stepKey="dontSeeButtonGroup"/>
14761476
</test>
14771477
<test name="ButtonsCanAddToColumn">
14781478
<annotations>
14791479
<features value="PageBuilder"/>
14801480
<stories value="Buttons"/>
1481-
<title value="Add Buttons to Column container and view on Admin and Storefront"/>
1481+
<title value="Button Group - Add Buttons to Column container and view on Admin and Storefront"/>
14821482
<description value="As a Content Manager I want column to be a container so that I can add Buttons inside"/>
14831483
<severity value="CRITICAL"/>
14841484
<useCaseId value="MC-515"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnContentTest.xml

Lines changed: 0 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -194,83 +194,6 @@
194194
<actualResult type="variable">actualStageRowHeightWithColumnsAndTabs</actualResult>
195195
</assertGreaterThanOrEqual>
196196
</test>
197-
<test name="MapAddToColumn">
198-
<annotations>
199-
<features value="PageBuilder"/>
200-
<stories value="Column"/>
201-
<title value="Add Map to Column container and view on Admin and Storefront"/>
202-
<description value="As a Content Manager I want column to be a container so that I can add Map inside"/>
203-
<severity value="CRITICAL"/>
204-
<useCaseId value="MC-964"/>
205-
<testCaseId value="MAGETWO-89961"/>
206-
<group value="pagebuilder"/>
207-
<group value="pagebuilder-column"/>
208-
<group value="pagebuilder-map"/>
209-
</annotations>
210-
<before>
211-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
212-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
213-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
214-
</before>
215-
<after>
216-
<actionGroup ref="logout" stepKey="logout"/>
217-
</after>
218-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
219-
<argument name="contentType" value="PageBuilderMapContentType"/>
220-
</actionGroup>
221-
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
222-
<argument name="contentType" value="PageBuilderColumnContentType"/>
223-
</actionGroup>
224-
<!-- Add Tabs to Stage -->
225-
<comment userInput="Add Tabs to Stage" stepKey="addTabsToStage"/>
226-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupInteractive">
227-
<argument name="group" value="PageBuilderMapContentType"/>
228-
</actionGroup>
229-
<actionGroup ref="dragContentTypeToContainerAndExpectEditPanel" stepKey="dragMapOntoColumnAndExpectEditPanel">
230-
<argument name="contentType" value="PageBuilderMapContentType"/>
231-
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
232-
<argument name="containerTargetIndex" value="2" />
233-
</actionGroup>
234-
<!-- Update Edit Panel -->
235-
<comment userInput="Update Edit Panel" stepKey="commentEdit"/>
236-
<actionGroup ref="clickAddLocationButton" stepKey="clickAddLocationButton"/>
237-
<actionGroup ref="clickMapToAddOrMovePin" stepKey="addMapPin"/>
238-
<!-- Add Fill Required Fields -->
239-
<comment userInput="Add Fill Required Fields" stepKey="commentAddFillRequiredFields"/>
240-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterLocationName">
241-
<argument name="property" value="PageBuilderMapLocationName_TestLocation"/>
242-
</actionGroup>
243-
<actionGroup ref="saveLocationForm" stepKey="saveLocationForm"/>
244-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
245-
<!-- Validate Stage -->
246-
<comment userInput="User sees map displayed in column on Stage" stepKey="confirmMapOnStage"/>
247-
<actionGroup ref="validateContentTypeInsideContainerStage" stepKey="checkContentTypeInContainerStage">
248-
<argument name="contentType" value="PageBuilderMapContentType"/>
249-
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
250-
<argument name="contentTypeIndex" value="1"/>
251-
<argument name="containerTargetIndex" value="2"/>
252-
</actionGroup>
253-
<actionGroup ref="validateMapSettings" stepKey="validateMapStage">
254-
<argument name="page" value="MapOnStage"/>
255-
<argument name="height" value="PageBuilderMapHeightDefaultProperty"/>
256-
</actionGroup>
257-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
258-
<!-- Validate Storefront -->
259-
<comment userInput="View Map inside column on storefront" stepKey="viewMapOnStorefront"/>
260-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
261-
<argument name="contentType" value="PageBuilderMapContentType"/>
262-
</actionGroup>
263-
<actionGroup ref="validateContentTypeInsideContainerStorefront" stepKey="checkContentTypeInContainerStorefront">
264-
<argument name="contentType" value="PageBuilderMapContentType"/>
265-
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
266-
<argument name="contentTypeIndex" value="1"/>
267-
<argument name="containerTargetIndex" value="2"/>
268-
</actionGroup>
269-
<actionGroup ref="validateMapSettings" stepKey="validateMapStoreFront">
270-
<argument name="page" value="MapOnStorefront"/>
271-
<argument name="height" value="PageBuilderMapHeightDefaultProperty"/>
272-
</actionGroup>
273-
</test>
274197
<test name="ColumnsMoveContentBetweenColumns">
275198
<annotations>
276199
<features value="PageBuilder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

Lines changed: 4 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -1409,71 +1409,6 @@
14091409
<!-- We validate for 6 columns as each group automatically creates 2 columns -->
14101410
<seeNumberOfElements selector="{{PageBuilderColumnSection.allColumns}}" userInput="6" stepKey="validateColumnsAdded"/>
14111411
</test>
1412-
<test name="CanAddVideoToColumn">
1413-
<annotations>
1414-
<features value="PageBuilder"/>
1415-
<stories value="Column"/>
1416-
<title value="Add Video to Column container and view on Admin and Storefront"/>
1417-
<description value="As a Content Manager I want column to be a container so that I can add video inside the column"/>
1418-
<useCaseId value="MAGETWO-87081"/>
1419-
<testCaseId value="MAGETWO-92791"/>
1420-
<severity value="CRITICAL"/>
1421-
<group value="pagebuilder"/>
1422-
<group value="pagebuilder-column"/>
1423-
<group value="pagebuilder-video"/>
1424-
</annotations>
1425-
<before>
1426-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1427-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1428-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1429-
</before>
1430-
<after>
1431-
<actionGroup ref="logout" stepKey="logout"/>
1432-
</after>
1433-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1434-
<argument name="contentType" value="PageBuilderVideoContentType"/>
1435-
</actionGroup>
1436-
<!-- Add Column to Stage -->
1437-
<comment userInput="Add Column to Stage" stepKey="addColumnToStage"/>
1438-
<actionGroup ref="dragContentTypeToStage" stepKey="dragColumnIntoStage">
1439-
<argument name="contentType" value="PageBuilderColumnContentType"/>
1440-
</actionGroup>
1441-
<!-- Add Video to Column -->
1442-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup2">
1443-
<argument name="group" value="PageBuilderVideoContentType"/>
1444-
</actionGroup>
1445-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragVideoOntoColumn">
1446-
<argument name="contentType" value="PageBuilderVideoContentType"/>
1447-
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
1448-
<argument name="containerTargetIndex" value="1" />
1449-
</actionGroup>
1450-
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear"/>
1451-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoUrlProperty">
1452-
<argument name="property" value="PageBuilderVideoUrl_YouTube"/>
1453-
</actionGroup>
1454-
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterVideoWidthProperty">
1455-
<argument name="property" value="PageBuilderVideoWidth_500"/>
1456-
</actionGroup>
1457-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1458-
<!-- Verify Video in Tab on stage -->
1459-
<comment userInput="View video on stage" stepKey="viewTabOnStage"/>
1460-
<actionGroup ref="validateVideo" stepKey="validateStage">
1461-
<argument name="page" value="VideoOnStage"/>
1462-
<argument name="url" value="PageBuilderVideoUrl_YouTube"/>
1463-
<argument name="width" value="PageBuilderVideoWidth_500"/>
1464-
</actionGroup>
1465-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1466-
<!-- Verify Video in Tab on storefront -->
1467-
<comment userInput="View Video on Storefront" stepKey="viewTabOnStorefront"/>
1468-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1469-
<argument name="contentType" value="PageBuilderVideoContentType"/>
1470-
</actionGroup>
1471-
<actionGroup ref="validateVideo" stepKey="validateStorefront">
1472-
<argument name="page" value="VideoOnStorefront"/>
1473-
<argument name="url" value="PageBuilderVideoUrl_YouTube"/>
1474-
<argument name="width" value="PageBuilderVideoWidth_500"/>
1475-
</actionGroup>
1476-
</test>
14771412
<test name="DuplicatingColumnWillDivideSourceColumn">
14781413
<annotations>
14791414
<features value="PageBuilder"/>
@@ -1585,13 +1520,13 @@
15851520
<argument name="contentType" value="PageBuilderColumnContentType"/>
15861521
<argument name="containerTargetType" value="PageBuilderStage"/>
15871522
</actionGroup>
1588-
<dontSeeElement selector="{{PageBuilderColumnSection.column}}" stepKey="dontSeeColumn"/>
1589-
<dontSeeElement selector="{{PageBuilderColumnSection.columnGroup}}" stepKey="dontSeeColumnGroup"/>
1523+
<dontSeeElementInDOM selector="{{PageBuilderColumnSection.column}}" stepKey="dontSeeColumn"/>
1524+
<dontSeeElementInDOM selector="{{PageBuilderColumnSection.columnGroup}}" stepKey="dontSeeColumnGroup"/>
15901525
</test>
15911526
<test name="ColumnCannotAddToColumns">
15921527
<annotations>
15931528
<features value="PageBuilder"/>
1594-
<stories value="Row"/>
1529+
<stories value="Column"/>
15951530
<title value="Cannot drag a column into a column"/>
15961531
<description value="If user drags column into a column, it should have no effect"/>
15971532
<severity value="CRITICAL"/>
@@ -1610,7 +1545,6 @@
16101545
<after>
16111546
<actionGroup ref="logout" stepKey="logout"/>
16121547
</after>
1613-
<waitForElementVisible selector="{{PageBuilderPanel.draggableContentTypeInPanel(PageBuilderRowContentType.name)}}" stepKey="waitForRowToBeVisible"/>
16141548
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandGroupInteractive">
16151549
<argument name="group" value="PageBuilderColumnContentType"/>
16161550
</actionGroup>
@@ -1619,11 +1553,10 @@
16191553
</actionGroup>
16201554
<!-- Add row to Column -->
16211555
<actionGroup ref="dragContentTypeToContainer" stepKey="dragRowOntoColumn">
1622-
<argument name="contentType" value="PageBuilderRowContentType"/>
1556+
<argument name="contentType" value="PageBuilderColumnContentType"/>
16231557
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
16241558
<argument name="containerTargetIndex" value="2" />
16251559
</actionGroup>
1626-
<waitForPageLoad stepKey="waitForAnimation" time="30"/>
16271560
<seeNumberOfElements selector="{{PageBuilderColumnSection.allColumns}}" userInput="2" stepKey="seeOnlyTwoElementColumns"/>
16281561
</test>
16291562
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderDividerTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@
792792
<argument name="contentType" value="PageBuilderDividerContentType"/>
793793
<argument name="containerTargetType" value="PageBuilderStage"/>
794794
</actionGroup>
795-
<dontSeeElement selector="{{DividerOnStage.allDividers}}" stepKey="dontSeeDivider"/>
795+
<dontSeeElementInDOM selector="{{DividerOnStage.allDividers}}" stepKey="dontSeeDivider"/>
796796
</test>
797797
<test name="DividerCanAddToColumn">
798798
<annotations>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1107,6 +1107,6 @@
11071107
<argument name="contentType" value="PageBuilderHeadingContentType"/>
11081108
<argument name="containerTargetType" value="PageBuilderStage"/>
11091109
</actionGroup>
1110-
<dontSeeElement selector="{{HeadingOnStage.all}}" stepKey="dontSeeHeading"/>
1110+
<dontSeeElementInDOM selector="{{HeadingOnStage.all}}" stepKey="dontSeeHeading"/>
11111111
</test>
11121112
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHtmlTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@
792792
<argument name="contentType" value="PageBuilderHtmlContentType"/>
793793
<argument name="containerTargetType" value="PageBuilderStage"/>
794794
</actionGroup>
795-
<dontSeeElement selector="{{HtmlOnStage.base('1')}}" stepKey="dontSeeHTML"/>
795+
<dontSeeElementInDOM selector="{{HtmlOnStage.base('1')}}" stepKey="dontSeeHTML"/>
796796
</test>
797797
<test name="HTMLCanAddToColumn">
798798
<annotations>

0 commit comments

Comments
 (0)