Skip to content

Commit e1d6c8f

Browse files
committed
MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin
Change string literal to PageBuilder*LinkURL_Empty.value (bug in MFTF)
1 parent 3f22fde commit e1d6c8f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,8 +1041,8 @@
10411041
</actionGroup>
10421042
<!-- Validate Storefront -->
10431043
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1044-
<seeElement selector="{{BannerOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="seeBannerLinkElementIsADiv"/>
1045-
<click selector="{{BannerOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="clickLinkElement"/>
1044+
<seeElement selector="{{BannerOnFrontendEmptyLink.linkUrl('1', PageBuilderBannerLinkUrlProperty_Empty.value)}}" stepKey="seeBannerLinkElementIsADiv"/>
1045+
<click selector="{{BannerOnFrontendEmptyLink.linkUrl('1', PageBuilderBannerLinkUrlProperty_Empty.value)}}" stepKey="clickLinkElement"/>
10461046
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccur" />
10471047
<seeCurrentUrlEquals url="{{_ENV.MAGENTO_BASE_URL}}{{PageBuilderBannerContentType.pageNamePrefix}}{{PageBuilderPageTitle.pageName}}" stepKey="seeThatCurrentUrlIsUnchanged" />
10481048
</test>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@
387387
</actionGroup>
388388
<seeElementInDOM selector="{{SlideOnFrontend.noMessageContent('1')}}" stepKey="seeInDOMMessageContentStorefront"/>
389389
<dontSeeElement selector="{{SlideOnFrontend.noMessageContent('1')}}" stepKey="dontSeeMessageContentStorefront"/>
390-
<seeElement selector="{{SlideOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="seeLinkStorefront"/>
390+
<seeElement selector="{{SlideOnFrontendEmptyLink.linkUrl('1', PageBuilderSlideItemLinkURL_Empty.value)}}" stepKey="seeLinkStorefront"/>
391391
<seeElement selector="{{SlideOnFrontend.showButton('1', PageBuilderSlideItemShowButton_Never.value)}}" stepKey="seeButtonStateStorefront"/>
392392
<seeElement selector="{{SlideOnFrontend.noButton('1')}}" stepKey="seeNoButtonTextStorefront"/>
393393
<seeElement selector="{{SlideOnFrontend.showOverlay('1', PageBuilderSlideItemShowOverlay_Never.value)}}" stepKey="seeOverlayStateStorefront"/>
@@ -411,7 +411,7 @@
411411
<resizeWindow width="375" height="667" stepKey="resizeWindowToMobile"/>
412412
<seeElementInDOM selector="{{SlideOnFrontend.noMessageContent('1')}}" stepKey="seeInDOMMessageContentStorefrontMobile"/>
413413
<dontSeeElement selector="{{SlideOnFrontend.noMessageContent('1')}}" stepKey="dontSeeMessageContentStorefrontMobile"/>
414-
<seeElement selector="{{SlideOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="seeLinkStorefrontMobile"/>
414+
<seeElement selector="{{SlideOnFrontendEmptyLink.linkUrl('1', PageBuilderSlideItemLinkURL_Empty.value)}}" stepKey="seeLinkStorefrontMobile"/>
415415
<seeElement selector="{{SlideOnFrontend.showButton('1', PageBuilderSlideItemShowButton_Never.value)}}" stepKey="seeButtonStateStorefrontMobile"/>
416416
<seeElement selector="{{SlideOnFrontend.noButton('1')}}" stepKey="seeNoButtonTextStorefrontMobile"/>
417417
<seeElement selector="{{SlideOnFrontend.showOverlay('1', PageBuilderSlideItemShowOverlay_Never.value)}}" stepKey="seeOverlayStateStorefrontMobile"/>
@@ -1068,8 +1068,8 @@
10681068
</actionGroup>
10691069
<!-- Validate Storefront -->
10701070
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1071-
<seeElementInDOM selector="{{SlideOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="seeSlideEmptyLinkUrl"/>
1072-
<click selector="{{SlideOnFrontendEmptyLink.linkUrl('1', '')}}" stepKey="clickEmptyLinkUrl"/>
1071+
<seeElementInDOM selector="{{SlideOnFrontendEmptyLink.linkUrl('1', PageBuilderSlideItemLinkURL_Empty.value)}}" stepKey="seeSlideEmptyLinkUrl"/>
1072+
<click selector="{{SlideOnFrontendEmptyLink.linkUrl('1', PageBuilderSlideItemLinkURL_Empty.value)}}" stepKey="clickEmptyLinkUrl"/>
10731073
<wait time="3" stepKey="waitArbitraryTimeForPotentialNavigationToOccur" />
10741074
<seeCurrentUrlEquals url="{{_ENV.MAGENTO_BASE_URL}}{{PageBuilderSliderContentType.pageNamePrefix}}{{PageBuilderPageTitle.pageName}}" stepKey="seeThatCurrentUrlIsUnchanged" />
10751075
</test>

0 commit comments

Comments
 (0)