Skip to content

Commit e0a95f5

Browse files
committed
#544: Configurable Page Builder Full Screen Mode
- Code Review Feedback/Amends
1 parent a68225a commit e0a95f5

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/VerifyFullScreenActionGroup.xml renamed to app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup/ClickEditWithPageBuilderButtonActionGroup.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
*/
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9-
<actionGroup name="VerifyFullScreenActionGroup">
9+
<actionGroup name="ClickEditWithPageBuilderButtonActionGroup">
10+
<annotations>
11+
<description>Validates that Page Builder opens (full screen) using the "Edit with Page Builder" button.</description>
12+
</annotations>
1013
<waitForElementVisible selector="{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="waitForEditWithPageBuilderButton"/>
1114
<click selector="{{PageBuilderStage.editWithPageBuilderButton}}" stepKey="clickEditWithPageBuilderButton"/>
1215
<waitForPageLoad stepKey="waitForFullScreenAnimation"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogCategoryDisablePageBuilderTest/PageBuilderCategoryDisablePageBuilderContentPreviewTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<actionGroup ref="NavigateToCreatedCategoryActionGroup" stepKey="navigateToCreatedCategory">
2424
<argument name="Category" value="$$createCategory$$"/>
2525
</actionGroup>
26-
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
26+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandContentSection"/>
2727
</before>
2828
<after>
2929
<actionGroup ref="AdminSetPageBuilderContentPreviewActionGroup" stepKey="resetPageBuilderContentPreview"/>
@@ -39,9 +39,8 @@
3939
<actionGroup ref="NavigateToCreatedCategoryActionGroup" stepKey="navigateToCreatedCategory">
4040
<argument name="Category" value="$$createCategory$$"/>
4141
</actionGroup>
42-
<waitForPageLoad stepKey="waitForPageLoad"/>
43-
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
42+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandContentSection"/>
4443
<dontSeeElementInDOM selector="{{PageBuilderStage.stageSnapshot}}" stepKey="dontSeeStageSnapshot"/>
45-
<actionGroup ref="VerifyFullScreenActionGroup" stepKey="verifyFullScreen"/>
44+
<actionGroup ref="ClickEditWithPageBuilderButtonActionGroup" stepKey="clickEditWithPageBuilderButtonActionGroup"/>
4645
</test>
4746
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCatalogProductDisablePageBuilderTest/PageBuilderProductDisablePageBuilderContentPreviewTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<actionGroup ref="NavigateToCreatedProductEditPageActionGroup" stepKey="navigateToCreatedProductEditPage">
2727
<argument name="product" value="$$createProduct$$"/>
2828
</actionGroup>
29-
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
29+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandContentSection"/>
3030
</before>
3131
<after>
3232
<actionGroup ref="AdminSetPageBuilderContentPreviewActionGroup" stepKey="resetPageBuilderContentPreview"/>
@@ -43,9 +43,8 @@
4343
<actionGroup ref="NavigateToCreatedProductEditPageActionGroup" stepKey="navigateToCreatedProductEditPage">
4444
<argument name="product" value="$$createProduct$$"/>
4545
</actionGroup>
46-
<waitForPageLoad stepKey="waitForPageLoad"/>
47-
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandAdminProductSection"/>
46+
<actionGroup ref="ExpandAdminProductSectionActionGroup" stepKey="expandContentSection"/>
4847
<dontSeeElementInDOM selector="{{PageBuilderStage.stageSnapshot}}" stepKey="dontSeeStageSnapshot"/>
49-
<actionGroup ref="VerifyFullScreenActionGroup" stepKey="verifyFullScreen"/>
48+
<actionGroup ref="ClickEditWithPageBuilderButtonActionGroup" stepKey="clickEditWithPageBuilderButtonActionGroup"/>
5049
</test>
5150
</tests>

0 commit comments

Comments
 (0)