Skip to content

Commit df94740

Browse files
committed
MC-5423: Scheduled Update slide out issues
- Enable GPU acceleration - Tidy up animation code
1 parent 51ed17b commit df94740

File tree

4 files changed

+17
-10
lines changed

4 files changed

+17
-10
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_page-builder.less

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434
}
3535

3636
&.stage-full-screen {
37+
-webkit-transform: translateZ(0);
38+
-moz-transform: translateZ(0);
3739
background: @color-white;
3840
height: 100%;
3941
left: 0;
@@ -42,6 +44,7 @@
4244
padding: 0;
4345
position: fixed;
4446
top: 0;
47+
transform: translateZ(0);
4548
width: 100%;
4649
z-index: 800;
4750

@@ -128,14 +131,14 @@
128131
-moz-transition: .175s ease-in-out;
129132
-webkit-transition: .175s ease-in-out;
130133
opacity: 0;
131-
transform: scale(.8);
134+
transform: scale(.8) translateZ(0);
132135
transition: .175s ease-in-out;
133136
visibility: hidden;
134137
}
135138

136139
&.trigger-transition .pagebuilder-stage-wrapper {
137140
opacity: 1;
138-
transform: scale(1);
141+
transform: scale(1) translateZ(0);
139142
visibility: visible;
140143
}
141144
}

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_panel.less

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,14 @@
110110
}
111111

112112
.pagebuilder-panel {
113-
-moz-transition: .4s ease-in-out;
113+
-moz-transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
114114
-moz-user-select: none;
115115
-ms-user-select: none;
116116
-o-user-select: none;
117-
-webkit-transition: .4s ease-in-out;
117+
-webkit-transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
118118
-webkit-user-select: none;
119119
background: @color-very-dark-grayish-orange;
120-
transition: .4s ease-in-out;
120+
transition: .35s ease-in-out opacity, .35s ease-in-out visibility, .35s ease-in-out height;
121121
user-select: none;
122122

123123
.search-results-empty {

app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/page-builder.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,13 @@ export default class PageBuilder implements PageBuilderInterface {
6868
* Fix the stage in the exact place it is when it's part of the content and allow it to transition to full
6969
* screen.
7070
*/
71+
const xPosition = parseInt(stageWrapper.offset().top.toString(), 10) -
72+
parseInt($(window).scrollTop().toString(), 10);
73+
const yPosition = stageWrapper.offset().left;
7174
this.previousWrapperStyles = {
7275
'position': 'fixed',
73-
'top': parseInt(stageWrapper.offset().top.toString(), 10) -
74-
parseInt($(window).scrollTop().toString(), 10) + 'px',
75-
'left': stageWrapper.offset().left + 'px',
76+
'top': `${xPosition}px`,
77+
'left': `${yPosition}px`,
7678
'zIndex': '800',
7779
'width': stageWrapper.outerWidth().toString() + 'px'
7880
};

0 commit comments

Comments
 (0)