Skip to content

Commit dda474b

Browse files
authored
Merge pull request #83 from magento-lynx/jquery-upgrade
[Lynx] JQuery upgrade preparation
2 parents 6b38176 + 805d33b commit dda474b

File tree

9 files changed

+12
-10
lines changed

9 files changed

+12
-10
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/binding/focus.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/html.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ define([
4242
this.elements.push(el);
4343
$(el).on('change', this.updateValue.bind(this));
4444
$(el).nextAll('.rule-param-apply').on('click', function () {
45-
$(el).change();
45+
$(el).trigger('change');
4646
});
4747
$(el).closest('li').find('.rule-param-remove').on('click', function () {
48-
$(el).val('').change();
48+
$(el).val('').trigger('change');
4949
});
5050
this.updateValue(this);
5151
}.bind(this));

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/product-totals.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ define([
6262
* @param {Object} jqXHR
6363
*/
6464
callSuperError: function (jqXHR) {
65+
// eslint-disable-next-line jquery-no-bind-unbind
6566
var superError = $.ajaxSettings.error.bind(window, jqXHR);
6667

6768
superError();

app/code/Magento/PageBuilder/view/adminhtml/web/js/panel.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/system/config/switch-attribute-type.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ define([
6161
*/
6262
cancel: function () {
6363
$attributeDropDownEl.val('pagebuilder');
64-
$attributeDropDownEl.change();
64+
$attributeDropDownEl.trigger('change');
6565
}
6666
}
6767
});

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/nesting-link-dialog.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/utils/nesting-widget-dialog.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/base/web/js/content-type/buttons/appearance/inline/widget.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ define([
3333

3434
if ($element.data('sameWidth')) {
3535
equalizeButtonWidth($element.find(buttonSelector));
36-
$(window).resize(function () {
36+
$(window).on('resize', function () {
3737
equalizeButtonWidth($element.find(buttonSelector));
3838
});
3939
events.on('contentType:redrawAfter', function (eventData) {

app/code/Magento/PageBuilder/view/base/web/js/content-type/slider/appearance/default/widget.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ define([
3535
$element.slick('setPosition');
3636
}
3737
});
38+
// eslint-disable-next-line jquery-no-bind-unbind
3839
events.on('stage:viewportChangeAfter', $element.slick.bind($element, 'setPosition'));
3940
};
4041
});

0 commit comments

Comments
 (0)