MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin

Update data converter and its tests

Author: danmooney2

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/AdvancedSliderItem.php

@@ -121,9 +121,10 @@ public function render(array $itemData, array $additionalData = []) : string
 
         // mobile wrapper div
         $linkNodeName = isset($eavData['link_url']) ? 'a' : 'div';
+        $linkDataElementName = isset($eavData['link_url']) ? 'link' : 'empty_link';
 
         $rootElementHtml = '<div' . $this->printAttributes($rootElementAttributes) . '>';
-        $rootElementHtml .= '<' . $linkNodeName . ' data-element="link"';
+        $rootElementHtml .= '<' . $linkNodeName . ' data-element="' . $linkDataElementName . '"';
         $rootElementHtml .= isset($eavData['link_url']) ? ' href="' . $eavData['link_url'] . '">' : '>';
         $rootElementHtml .= '<div'
             . $this->printAttributes($wrapperDivElementAttributes)

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/ButtonItem.php

@@ -68,8 +68,9 @@ public function render(array $itemData, array $additionalData = []) : string
         }
 
         $linkNodeName = isset($eavData['link_url']) ? 'a' : 'div';
+        $linkDataElementName = isset($eavData['link_url']) ? 'link' : 'empty_link';
 
-        $rootElementHtml .= '><' . $linkNodeName . ' data-element="link"'
+        $rootElementHtml .= '><' . $linkNodeName . ' data-element="' . $linkDataElementName . '"'
             . (isset($eavData['link_url']) ? ' href="' . $eavData['link_url'] . '"' : '')
             . $buttonStyleAttribute
             . ' class="pagebuilder-button-primary"><span data-element="link_text">'

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Driver.php

@@ -85,16 +85,17 @@ public function render(array $itemData, array $additionalData = []) : string
         }
         $rootElementAttributes['style'] .= $margin;
 
-        $linkAttributes = [
-            'data-element' => 'link',
-        ];
-
         // if link_url is present, add href and target attribute
         if (isset($eavData['link_url'])) {
-            $linkAttributes = array_merge($linkAttributes, [
+            $linkAttributes = [
+                'data-element' => 'link',
                 'href' => $eavData['link_url'],
                 'target' => isset($eavData['target_blank']) && $eavData['target_blank'] ? '_blank' : '',
-            ]);
+            ];
+        } else {
+            $linkAttributes = [
+                'data-element' => 'empty_link',
+            ];
         }
 
         $imageAttributes = [

dev/tests/integration/testsuite/Magento/PageBuilder/_files/buttons_no_link_url.html

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="buttons" data-appearance="inline" style="display: inline-block; text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="button-item" data-appearance="default" style="display: inline-block;"><div data-element="link" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span data-element="link_text">Domain.com</span></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="buttons" data-appearance="inline" style="display: inline-block; text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="button-item" data-appearance="default" style="display: inline-block;"><div data-element="empty_link" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span data-element="link_text">Domain.com</span></div></div></div></div></div>

dev/tests/integration/testsuite/Magento/PageBuilder/_files/slider_no_link_url.html

@@ -1 +1 @@
-<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Title</h3><div></div></div></div></div></div></div></div></div></div></div>
+<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="empty_link"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Title</h3><div></div></div></div></div></div></div></div></div></div></div>