#787: Moved attributes to different level

Stanislav Idolov · Stanislav Idolov · commit dbf8e0e81446 · 2021-11-23T15:10:15.000-06:00
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml b/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/banner.xml
@@ -153,12 +153,12 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="overlay">
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="message" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -241,12 +241,12 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="overlay">
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="message" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -328,15 +328,15 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="overlay">
                         <style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/overlay-border-radius" persistence_mode="write"/>
                         <style name="min_height" source="min_height" converter="Magento_PageBuilder/js/converter/style/min-height"/>
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/banner/converter/style/overlay-background-color" persistence_mode="write"/>
                         <style name="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/banner/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="message" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
diff --git a/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/slide.xml b/app/code/Magento/PageBuilder/view/adminhtml/pagebuilder/content_type/slide.xml
@@ -50,6 +50,8 @@
                     <element name="overlay">
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/slide/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/slide/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="wrapper">
                         <style name="background_color" source="background_color"/>
@@ -71,8 +73,6 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -137,6 +137,8 @@
                     <element name="overlay">
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/slide/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/slide/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="wrapper">
                         <style name="background_color" source="background_color"/>
@@ -158,8 +160,6 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -224,6 +224,8 @@
                     <element name="overlay">
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/slide/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/slide/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="wrapper">
                         <style name="background_color" source="background_color"/>
@@ -245,8 +247,6 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -314,6 +314,8 @@
                         <style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/content-type/slide/converter/style/paddings"/>
                         <style name="overlay_color" source="background_color" converter="Magento_PageBuilder/js/content-type/slide/converter/style/overlay-background-color" persistence_mode="write"/>
                         <attribute name="overlay_color_attribute" storage_key="overlay_color" source="data-overlay-color" converter="Magento_PageBuilder/js/content-type/slide/converter/attribute/overlay-color"/>
+                        <attribute name="alt" source="aria-label"/>
+                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="wrapper">
                         <style name="background_color" source="background_color"/>
@@ -334,8 +336,6 @@
                         <attribute name="video_play_only_visible" source="data-video-play-only-visible"/>
                         <attribute name="video_lazy_load" source="data-video-lazy-load"/>
                         <attribute name="video_fallback_image" source="data-video-fallback-src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
-                        <attribute name="alt" source="aria-label"/>
-                        <attribute name="title_attribute" source="title"/>
                     </element>
                     <element name="content">
                         <html name="content" preview_converter="Magento_PageBuilder/js/converter/html/directive"/>
@@ -412,5 +412,5 @@
                 </item>
             </item>
         </additional_data>
-    </type>
+    </type>Magento\AcceptanceTest\_PageBuilderWithWYSIWYG\Backend\SlideItemContentSectionDefaultsTestCest.SlideItemContentSectionDefaultsTest
 </config>
