Skip to content

Commit d8f01dd

Browse files
PB-166: Page Builder doesn't implement destroy method
1 parent ebdbfda commit d8f01dd

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/buttons/preview.js

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,8 @@ define([
213213

214214
/** @inheritdoc */
215215
destroy: function () {
216+
this.pageBuilder && this.pageBuilder.destroy();
216217
this._super();
217-
this.pageBuilder.destroy();
218218
}
219219
});
220220
});

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/buttons/preview.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,11 @@ export default class Preview extends PreviewCollection {
5050
super(contentType, config, observableUpdater);
5151

5252
// Keeps track of number of button item to disable sortable if there is only 1.
53-
this.contentType.children.subscribe(() => {
53+
this.contentType.children.subscribe((args) => {
5454
const sortableElement = $(this.wrapperElement).find(".buttons-container");
55+
if (!sortableElement.data("sortable")) {
56+
return;
57+
}
5558
if (this.contentType.children().length <= 1) {
5659
sortableElement.sortable("disable");
5760
} else {

0 commit comments

Comments
 (0)