Skip to content

Commit d7311c6

Browse files
krissyhiserotekrissyhiserote
committed
MC-849: Button On Frontend Has HTML Binding
- update tests and change name of converter file
1 parent 57e6ea7 commit d7311c6

15 files changed

+53
-338
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/SlideData.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@
3737
<data key="value">poster</data>
3838
<data key="optionsList">Poster, Collage left, Collage centered, Collage right</data>
3939
</entity>
40+
<entity name="PageBuilderSlidePosterProperty" type="pagebuilder_appearance_property">
41+
<data key="name">Appearance</data>
42+
<data key="section">appearance_fieldset</data>
43+
<data key="fieldName">appearance</data>
44+
<data key="value">poster</data>
45+
</entity>
4046
<entity name="PageBuilderSlideCollageLeftProperty" type="pagebuilder_appearance_property">
4147
<data key="name">Appearance</data>
4248
<data key="section">appearance_fieldset</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,8 +1202,8 @@
12021202
<annotations>
12031203
<features value="PageBuilder"/>
12041204
<stories value="Banner"/>
1205-
<title value="Collage Center - Html Value In Buttons"/>
1206-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1205+
<title value="Collage Center - HTML Value In Buttons Does Not Render As HTML"/>
1206+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12071207
<severity value="MAJOR"/>
12081208
<useCaseId value="MC-849"/>
12091209
<testCaseId value="MC-3654"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 3 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,72 +1198,21 @@
11981198
<switchToNextTab stepKey="switchToNextTab"/>
11991199
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="seeCurrentUrlEquals"/>
12001200
</test>
1201-
<test name="BannerCollageLeftHtmlValueInButtons">
1201+
<test name="BannerCollageLeftHtmlValueInButtons" extends="BannerCollageCenterHtmlValueInButtons">
12021202
<annotations>
12031203
<features value="PageBuilder"/>
12041204
<stories value="Banner"/>
1205-
<title value="Banner Collage Left - Html Value In Buttons"/>
1206-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1205+
<title value="Banner Collage Left - HTML Value In Buttons Does Not Render As HTML"/>
1206+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12071207
<severity value="MAJOR"/>
12081208
<useCaseId value="MC-849"/>
12091209
<testCaseId value="MC-3655"/>
12101210
<group value="pagebuilder"/>
12111211
<group value="pagebuilder-banner"/>
12121212
<group value="pagebuilder-bannerCollageLeft"/>
12131213
</annotations>
1214-
<before>
1215-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1216-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1217-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1218-
</before>
1219-
<after>
1220-
<actionGroup ref="logout" stepKey="logout"/>
1221-
</after>
1222-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1223-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1224-
</actionGroup>
1225-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1226-
<argument name="group" value="PageBuilderBannerContentType"/>
1227-
</actionGroup>
1228-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
1229-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1230-
</actionGroup>
1231-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
1232-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1233-
</actionGroup>
1234-
<!-- Fill Out Edit Panel -->
1235-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
12361214
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
12371215
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
12381216
</actionGroup>
1239-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButtonAlwaysProperty">
1240-
<argument name="property" value="PageBuilderBannerShowButtonAlwaysProperty"/>
1241-
</actionGroup>
1242-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterButtonText">
1243-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1244-
</actionGroup>
1245-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1246-
<!-- Validate Stage -->
1247-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1248-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage"/>
1249-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1250-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1251-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
1252-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1253-
</actionGroup>
1254-
<!-- Validate Edit Panel -->
1255-
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
1256-
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeButtonTextOnForm">
1257-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1258-
</actionGroup>
1259-
<!-- Validate Stage After Save -->
1260-
<comment userInput="Validate Stage After Save" stepKey="commentValidateStageAfterSave"/>
1261-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage2"/>
1262-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1263-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1264-
</actionGroup>
1265-
<!-- Validate Storefront -->
1266-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1267-
<seeElement selector="{{BannerOnFrontend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStorefront"/>
12681217
</test>
12691218
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 3 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,72 +1198,21 @@
11981198
<switchToNextTab stepKey="switchToNextTab"/>
11991199
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="seeCurrentUrlEquals"/>
12001200
</test>
1201-
<test name="BannerCollageRightHtmlValueInButtons">
1201+
<test name="BannerCollageRightHtmlValueInButtons" extends="BannerCollageCenterHtmlValueInButtons">
12021202
<annotations>
12031203
<features value="PageBuilder"/>
12041204
<stories value="Banner"/>
1205-
<title value="Banner Collage Right - Html Value In Buttons"/>
1206-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1205+
<title value="Banner Collage Right - HTML Value In Buttons Does Not Render As HTML"/>
1206+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12071207
<severity value="MAJOR"/>
12081208
<useCaseId value="MC-849"/>
12091209
<testCaseId value="MC-3656"/>
12101210
<group value="pagebuilder"/>
12111211
<group value="pagebuilder-banner"/>
12121212
<group value="pagebuilder-bannerCollageRight"/>
12131213
</annotations>
1214-
<before>
1215-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1216-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1217-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1218-
</before>
1219-
<after>
1220-
<actionGroup ref="logout" stepKey="logout"/>
1221-
</after>
1222-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1223-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1224-
</actionGroup>
1225-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1226-
<argument name="group" value="PageBuilderBannerContentType"/>
1227-
</actionGroup>
1228-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
1229-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1230-
</actionGroup>
1231-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
1232-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1233-
</actionGroup>
1234-
<!-- Fill Out Edit Panel -->
1235-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
12361214
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
12371215
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
12381216
</actionGroup>
1239-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButtonAlwaysProperty">
1240-
<argument name="property" value="PageBuilderBannerShowButtonAlwaysProperty"/>
1241-
</actionGroup>
1242-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterButtonText">
1243-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1244-
</actionGroup>
1245-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1246-
<!-- Validate Stage -->
1247-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1248-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage"/>
1249-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1250-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1251-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
1252-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1253-
</actionGroup>
1254-
<!-- Validate Edit Panel -->
1255-
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
1256-
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeButtonTextOnForm">
1257-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1258-
</actionGroup>
1259-
<!-- Validate Stage After Save -->
1260-
<comment userInput="Validate Stage After Save" stepKey="commentValidateStageAfterSave"/>
1261-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage2"/>
1262-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1263-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1264-
</actionGroup>
1265-
<!-- Validate Storefront -->
1266-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1267-
<seeElement selector="{{BannerOnFrontend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStorefront"/>
12681217
</test>
12691218
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 5 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,69 +1260,21 @@
12601260
<switchToNextTab stepKey="switchToNextTab"/>
12611261
<seeCurrentUrlEquals url="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="seeCurrentUrlEquals"/>
12621262
</test>
1263-
<test name="BannerPosterHtmlValueInButtons">
1263+
<test name="BannerPosterHtmlValueInButtons" extends="BannerCollageCenterHtmlValueInButtons">
12641264
<annotations>
12651265
<features value="PageBuilder"/>
12661266
<stories value="Banner"/>
1267-
<title value="Banner Poster - Html Value In Buttons"/>
1268-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1267+
<title value="Banner Poster - HTML Value In Buttons Does Not Render As HTML"/>
1268+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
12691269
<severity value="MAJOR"/>
12701270
<useCaseId value="MC-849"/>
12711271
<testCaseId value="MC-3657"/>
12721272
<group value="pagebuilder"/>
12731273
<group value="pagebuilder-banner"/>
12741274
<group value="pagebuilder-bannerPoster"/>
12751275
</annotations>
1276-
<before>
1277-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1278-
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1279-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1280-
</before>
1281-
<after>
1282-
<actionGroup ref="logout" stepKey="logout"/>
1283-
</after>
1284-
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1285-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1286-
</actionGroup>
1287-
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1288-
<argument name="group" value="PageBuilderBannerContentType"/>
1289-
</actionGroup>
1290-
<actionGroup ref="dragContentTypeToStage" stepKey="dragBannerIntoStage">
1291-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1292-
</actionGroup>
1293-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
1294-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1295-
</actionGroup>
1296-
<!-- Fill Out Edit Panel -->
1297-
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
1298-
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButtonAlwaysProperty">
1299-
<argument name="property" value="PageBuilderBannerShowButtonAlwaysProperty"/>
1300-
</actionGroup>
1301-
<actionGroup ref="fillSlideOutPanelField" stepKey="enterButtonText">
1302-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1303-
</actionGroup>
1304-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1305-
<!-- Validate Stage -->
1306-
<comment userInput="Validate Stage" stepKey="commentValidateStage"/>
1307-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage"/>
1308-
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
1309-
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1310-
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
1311-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1312-
</actionGroup>
1313-
<!-- Validate Edit Panel -->
1314-
<comment userInput="Validate Edit Panel" stepKey="commentValidateEditPanel"/>
1315-
<actionGroup ref="seeInFieldSlideOutProperty" stepKey="seeButtonTextOnForm">
1316-
<argument name="property" value="PageBuilderBannerButtonTextProperty_Html"/>
1317-
</actionGroup>
1318-
<!-- Validate Stage After Save -->
1319-
<comment userInput="Validate Stage After Save" stepKey="commentValidateStageAfterSave"/>
1320-
<seeElement selector="{{BannerOnBackend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStage2"/>
1321-
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
1322-
<argument name="contentType" value="PageBuilderBannerContentType"/>
1276+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1277+
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
13231278
</actionGroup>
1324-
<!-- Validate Storefront -->
1325-
<comment userInput="Validate Storefront" stepKey="commentValidateStorefront"/>
1326-
<seeElement selector="{{BannerOnFrontend.buttonText('1', PageBuilderBannerButtonTextProperty_Html.value)}}" stepKey="seeButtonTextStorefront"/>
13271279
</test>
13281280
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonItemTests.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,8 +1176,8 @@
11761176
<annotations>
11771177
<features value="PageBuilder"/>
11781178
<stories value="Buttons"/>
1179-
<title value="Button Item - Html Value In Buttons"/>
1180-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1179+
<title value="Button Item - HTML Value In Buttons Does Not Render As HTML"/>
1180+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
11811181
<severity value="MAJOR"/>
11821182
<useCaseId value="MC-849"/>
11831183
<testCaseId value="MC-3658"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideAppearanceCollageCenterTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,8 +1094,8 @@
10941094
<annotations>
10951095
<features value="PageBuilder"/>
10961096
<stories value="Slider"/>
1097-
<title value="Collage Center - Html Value In Buttons"/>
1098-
<description value="Validate that html can be entered into the button and that it shows the same on stage and storefront."/>
1097+
<title value="Collage Center - HTML Value In Buttons Does Not Render As HTML"/>
1098+
<description value="Validate that html can be entered into the button and that the html doesn't render on stage and storefront."/>
10991099
<severity value="MAJOR"/>
11001100
<useCaseId value="MC-849"/>
11011101
<testCaseId value="MC-3659"/>
@@ -1122,7 +1122,7 @@
11221122
</actionGroup>
11231123
<!-- Fill Out Edit Panel -->
11241124
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
1125-
<actionGroup ref="chooseVisualSelectOption" stepKey="enterCollageCenterAppearance">
1125+
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearance">
11261126
<argument name="property" value="PageBuilderSlideCollageCenteredProperty"/>
11271127
</actionGroup>
11281128
<actionGroup ref="selectSlideOutPanelField" stepKey="selectShowButtonAlwaysProperty">

0 commit comments

Comments
 (0)