Skip to content

Commit d64379e

Browse files
committed
MC-3053: Automate MFTF for MC-2294
1 parent 532ab47 commit d64379e

File tree

4 files changed

+9
-14
lines changed

4 files changed

+9
-14
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<element name="computedWidthOnStage" type="text" selector="return parseInt(window.getComputedStyle(document.querySelector('.pagebuilder-{{arg1}}:nth-of-type({{arg2}})')).width)" parameterized="true"/>
3434
<element name="uploadLocalImageBtn" type="button" selector="//div[contains(@class,'pagebuilder-image-uploader-container')]//input[@name='background_image']"/>
3535
<element name="uploadNewImageBtn" type="button" selector="//label[text()='Upload Image']" />
36-
<element name="selectFromGalleryImageBtn" type="button" selector="//div[@data-index='{{arg1}}']//input[@name='{{arg2}}']//following-sibling::label[text()='Select from Gallery']" parameterized="true"/>
36+
<element name="selectFromGalleryImageBtn" type="button" selector="//ul[contains(@class,'pagebuilder-options-links')]//label[text()='Select from Gallery']" parameterized="true"/>
3737
</section>
3838
<section name="PageBuilderPanel">
3939
<element name="searchField" type="input" selector='//*[@id="pagebuilder-panel"]/div[1]/a'/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1944,7 +1944,8 @@
19441944
</actionGroup>
19451945
<click selector="{{MediaGallerySection.CancelBtn}}" stepKey="closeSlideOut1"/>
19461946
<comment userInput="Assert not to see deleted image on stage" stepKey="assertNotToSeeImage1"/>
1947-
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="dontSeeImageOnStage1"/>
1947+
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeBannerPlaceholder1"/>
1948+
<dontSeeElementInDOM selector="{{ImageOnConfigurationPanel.imageSource(PageBuilderBackgroundImage_JPG.fileName)}}" stepKey="dontSeeImageInDOM1"/>
19481949
<!-- Attach image C to Image slideout form -->
19491950
<comment userInput="Attach image C to Image slideout form" stepKey="attachImageToSlideOut"/>
19501951
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
@@ -1967,6 +1968,7 @@
19671968
<!--<conditionalClick selector=".modals-overlay" dependentSelector=".modals-overlay" stepKey="clickOverlay" visible="true"/>-->
19681969
<dontSeeElementInDOM selector="{{EditPanelForm.editFormUploadedImageSource(PageBuilderBackgroundImage_JPG.section, PageBuilderBackgroundImage_JPG.fieldName, PageBuilderBackgroundImage_JPG.fileName, PageBuilderBackgroundImage_JPG.extension)}}" stepKey="dontSeeImage"/>
19691970
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
1970-
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="dontSeeImageOnStage2"/>
1971+
<seeElement selector="{{BannerOnBackend.emptyBanner(PageBuilderBannerMessageDefaultProperty.placeholder)}}" stepKey="seeBannerPlaceholder2"/>
1972+
<dontSeeElementInDOM selector="{{ImageOnConfigurationPanel.imageSource(PageBuilderBackgroundImage_JPG.fileName)}}" stepKey="dontSeeImageInDOM2"/>
19711973
</test>
19721974
</tests>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
<!-- Assert don't see deleted image on stage -->
5858
<comment userInput="Assert don't see deleted image on stage" stepKey="assertNotToSeeImage"/>
5959
<seeElementInDOM selector="{{ImageOnStage.imageEmptyPreview}}" stepKey="dontSeeImageOnStage1"/>
60+
<dontSeeElementInDOM selector="{{ImageOnStage.imageSourceOnStage(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM1"/>
6061
<!-- Attach image C to Image slideout form -->
6162
<comment userInput="Attach image C to Image slideout form" stepKey="attachImageToSlideOut"/>
6263
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage1">
@@ -76,7 +77,6 @@
7677
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteImageFromStorage3">
7778
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
7879
</actionGroup>
79-
<!--<conditionalClick selector=".modals-overlay" dependentSelector=".modals-overlay" stepKey="clickOverlay" visible="true"/>-->
8080
<click selector="{{MediaGallerySection.CancelBtn}}" stepKey="closeSlideOut3"/>
8181
<dontSeeElementInDOM selector="{{ImageOnConfigurationPanel.imageSource(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeMainImageSource"/>
8282
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings"/>
@@ -86,7 +86,7 @@
8686
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
8787
<argument name="contentType" value="PageBuilderImageContentType"/>
8888
</actionGroup>
89-
<click selector="{{PageBuilderStage.selectFromGalleryImageBtn(PageBuilderImageProperty_JPG2.section,PageBuilderImageProperty_JPG2.fieldName)}}" stepKey="clickSelectfromGallery"/>
89+
<click selector="{{PageBuilderStage.selectFromGalleryImageBtn}}" stepKey="clickSelectfromGallery"/>
9090
<waitForPageLoad stepKey="waitForPageLoad"/>
9191
<actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
9292
<argument name="ImageFolder" value="ImageFolder"/>
@@ -106,10 +106,10 @@
106106
<actionGroup ref="DeleteImageFromStorageActionGroup" stepKey="DeleteImageFromStorage4">
107107
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
108108
</actionGroup>
109-
<conditionalClick selector=".modals-overlay" dependentSelector=".modals-overlay" stepKey="clickOverlay2" visible="true"/>
110109
<dontSeeElementInDOM selector="{{ImageOnConfigurationPanel.imageSource(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeMainImageSource2"/>
111110
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings2"/>
112111
<seeElementInDOM selector="{{ImageOnStage.imageEmptyPreview}}" stepKey="dontSeeImageOnStage3"/>
112+
<dontSeeElementInDOM selector="{{ImageOnStage.imageSourceOnStage(PageBuilderImageProperty_StageJPG.fileName)}}" stepKey="dontSeeImageInDOM2"/>
113113
</test>
114114
<test name="ImageAddImageIntoPageBuilderStage">
115115
<annotations>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1910,21 +1910,14 @@
19101910
</actionGroup>
19111911
<click selector="{{MediaGallerySection.CancelBtn}}" stepKey="closeStorage"/>
19121912
<actionGroup ref="closeEditPanelSettings" stepKey="closeEditPanelSettings1"/>
1913-
<!--<conditionalClick selector=".modals-overlay" dependentSelector=".modals-overlay" stepKey="clickOverlay1" visible="true"/>-->
19141913
<dontSeeElementInDOM selector="{{SlideOnBackend.slideBackgroundImage('0',PageBuilderSlideBackgroundImageProperty1.path, PageBuilderSlideBackgroundImageProperty1.extension)}}" stepKey="dontSeeImageNameOnPreview1"/>
19151914
<!--Upload image from local machine -->
19161915
<comment userInput="Upload image from local machine to stage" stepKey="commentUploadImageToStage"/>
19171916
<actionGroup ref="attachFileSlideOutProperty" stepKey="attachImageFile1">
19181917
<argument name="property" value="PageBuilderSlideBackgroundImageProperty1"/>
19191918
</actionGroup>
1920-
<!--<waitForElementVisible selector="{{SlideOnBackend.slideBackgroundImage('0',PageBuilderSlideBackgroundImageProperty1.path, PageBuilderSlideBackgroundImageProperty1.extension)}}" stepKey="waitForMainImageSource1"/>-->
1921-
<!--<click selector="{{SliderInAdmin.slideWrapper}}" stepKey="clickSliderInStage"/>-->
1922-
<!--<waitForElementVisible selector="{{ImageOnStage.selectFromGalleryImageBtn}}" stepKey="seeSelectFromGalleryBtn2" />-->
1923-
<!--<click selector="{{ImageOnStage.selectFromGalleryImageBtn}}" stepKey="clickSelectFromGallery" />-->
1924-
<!--<waitForPageLoad stepKey="waitForPageLoad2" />-->
1925-
<!--<waitForLoadingMaskToDisappear stepKey="waitForLoading2" />-->
19261919
<actionGroup ref="goToMediaStorageFromStage" stepKey="goToMediaStorageFromStage1" >
1927-
<argument name="contentType" value="PageBuildersSliderContentType"/>
1920+
<argument name="contentType" value="PageBuilderSliderContentType"/>
19281921
<argument name="section" value="ImageOnStage"/>
19291922
</actionGroup>
19301923
<!-- Delete image A -->

0 commit comments

Comments
 (0)