Merge branch 'fix-readiness-failures' of github.com:magento-obsessive-owls/magento2-page-builder into MC-3735

Author: omiroshnichenko

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeButtonActionGroup.xml

@@ -52,7 +52,8 @@
         <waitForElementVisible selector="{{ButtonItemOnStage.base(index)}}" stepKey="waitForButton"/>
         <waitForElementVisible selector="{{ButtonItemOnStage.editableButtonItemElement(index)}}" stepKey="waitForButtonEditable"/>
         <fillField selector="{{ButtonItemOnStage.editableButtonItemElement(index)}}" userInput="{{text.value}}" stepKey="enterButtonText"/>
-        <waitForElementVisible selector="{{ButtonItemOnStage.buttonItemText(index, text.value)}}" stepKey="waitForButtonText"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
+        <seeElement selector="{{ButtonItemOnStage.buttonItemText(index, text.value)}}" stepKey="seeButtonText"/>
         <click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusLiveEdit"/>
         <waitForPageLoad stepKey="waitForUnFocus"/>
     </actionGroup>
@@ -163,6 +164,7 @@
         <waitForElementVisible selector="{{buttonGroupPage.base(buttonGroupIndex)}}" stepKey="waitForButtonGroup"/>
         <seeElement selector="{{buttonGroupPage.sameSizeValue(buttonGroupIndex, PageBuilderButtonGroupSameSize_Enabled.value)}}" stepKey="seeButtonSameSizeValue"/>
         <waitForElementVisible selector="{{buttonItemPage.base(firstButtonIndex)}}" stepKey="waitForButton1"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <executeJS function="return parseInt(window.getComputedStyle({{buttonItemPage.jsButtonSelector(firstButtonIndex)}}).width)" stepKey="button1Width"/>
         <waitForElementVisible selector="{{buttonItemPage.base(secondButtonIndex)}}" stepKey="waitForButton2"/>
         <executeJS function="return parseInt(window.getComputedStyle({{buttonItemPage.jsButtonSelector(secondButtonIndex)}}).width)" stepKey="button2Width"/>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderTextSection.xml

@@ -60,7 +60,7 @@
         <element name="textArea" type="text" selector="#pagebuilder_text_form_content"/>
         <element name="textAreaId" type="text" selector="pagebuilder_text_form_content"/>
         <element name="insertWidgetButton" type="text" selector="//button[contains(@class,'action-add-widget')][.='Insert Widget...']"/>
-        <element name="insertImageButton" type="text" selector="//button[contains(@class,'action-add-image')][.='Insert Image...']"/>
+        <element name="insertImageButton" type="text" selector="//button[contains(@class,'action-add-image')][.='Insert Image...']" timeout="10"/>
         <element name="insertVariableButton" type="text" selector="//button[contains(@class,'add-variable')][.='Insert Variable...']"/>
     </section>
     <section name="TextOnStorefront">

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest.xml

@@ -1116,6 +1116,8 @@
         <actionGroup ref="clickSelectFromGallerySlideOut" stepKey="clickSelectFromGallerySlideOut">
             <argument name="property" value="PageBuilderBackgroundImage_JPG"/>
         </actionGroup>
+        <click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickStorageRoot"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
             <argument name="ImageFolder" value="ImageFolder"/>
         </actionGroup>
@@ -1186,6 +1188,8 @@
         <click selector="{{ImageOnStage.selectFromGalleryImageBtn}}" stepKey="clickSelectFromGallery" />
         <waitForPageLoad stepKey="waitForPageLoad2" />
         <waitForLoadingMaskToDisappear stepKey="waitForLoading2" />
+        <click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickStorageRoot"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
             <argument name="ImageFolder" value="ImageFolder"/>
         </actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderButtonGroupAppearanceTests.xml

@@ -559,6 +559,7 @@
         <comment userInput="Validate Storefront" stepKey="commentValidateStorefront2"/>
         <switchToNextTab stepKey="switchToNextTab"/>
         <reloadPage stepKey="reloadPage2"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <waitForElementVisible selector="{{ButtonItemOnStorefront.buttonItemText('1', PageBuilderButtonItemText_First.value)}}" stepKey="waitForButton1Storefront2"/>
         <waitForElementVisible selector="{{ButtonItemOnStorefront.buttonItemText('2', PageBuilderButtonItemText_Second.value)}}" stepKey="waitForButton2Storefront2"/>
         <actionGroup ref="validateButtonGroupInlineAppearance" stepKey="seeAppearanceOnStorefront2">
@@ -964,6 +965,7 @@
         <comment userInput="Edit Button: Make Largest Button Larger" stepKey="commentEdit1"/>
         <switchToPreviousTab stepKey="switchToPreviousTab"/>
         <reloadPage stepKey="reloadPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
         <actionGroup ref="inlineEditButton" stepKey="inlineEditButton3">
             <argument name="text" value="PageBuilderButtonItemText_FiveCharacters"/>
@@ -985,6 +987,7 @@
         <comment userInput="Validate Storefront: Make Largest Button Larger" stepKey="commentValidateStorefront2"/>
         <switchToNextTab stepKey="switchToNextTab"/>
         <reloadPage stepKey="reloadPage2"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront2">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -998,6 +1001,7 @@
         <comment userInput="Edit Button: Make Largest Button Smallest" stepKey="commentEdit2"/>
         <switchToPreviousTab stepKey="switchToPreviousTab2"/>
         <reloadPage stepKey="reloadPage3"/>
+        <waitForPageLoad stepKey="waitForPageLoad3"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
         <actionGroup ref="inlineEditButton" stepKey="inlineEditButton4">
             <argument name="text" value="PageBuilderButtonItemText_TwoCharacters"/>
@@ -1019,6 +1023,7 @@
         <comment userInput="Validate Storefront: Make Largest Button Smallest" stepKey="commentValidateStorefront3"/>
         <switchToNextTab stepKey="switchToNextTab2"/>
         <reloadPage stepKey="reloadPage4"/>
+        <waitForPageLoad stepKey="waitForPageLoad4"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront3">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1032,6 +1037,7 @@
         <comment userInput="Edit Button: Make Smallest Button Smaller" stepKey="commentEdit3"/>
         <switchToPreviousTab stepKey="switchToPreviousTab3"/>
         <reloadPage stepKey="reloadPage5"/>
+        <waitForPageLoad stepKey="waitForPageLoad5"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage4"/>
         <actionGroup ref="inlineEditButton" stepKey="inlineEditButton5">
             <argument name="text" value="PageBuilderButtonItemText_OneCharacter"/>
@@ -1053,6 +1059,7 @@
         <comment userInput="Validate Storefront: Make Smallest Button Smaller" stepKey="commentValidateStorefront4"/>
         <switchToNextTab stepKey="switchToNextTab3"/>
         <reloadPage stepKey="reloadPage6"/>
+        <waitForPageLoad stepKey="waitForPageLoad6"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront4">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1066,6 +1073,7 @@
         <comment userInput="Edit Button: Make Smallest Button Largest" stepKey="commentEdit4"/>
         <switchToPreviousTab stepKey="switchToPreviousTab4"/>
         <reloadPage stepKey="reloadPage7"/>
+        <waitForPageLoad stepKey="waitForPageLoad7"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage5"/>
         <actionGroup ref="inlineEditButton" stepKey="inlineEditButton6">
             <argument name="text" value="PageBuilderButtonItemText_FourCharacters"/>
@@ -1087,6 +1095,7 @@
         <comment userInput="Validate Storefront: Make Smallest Button Largest" stepKey="commentValidateStorefront5"/>
         <switchToNextTab stepKey="switchToNextTab4"/>
         <reloadPage stepKey="reloadPage8"/>
+        <waitForPageLoad stepKey="waitForPageLoad8"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront5">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1171,6 +1180,7 @@
         <comment userInput="Add New Longest Button" stepKey="commentAddNewButton"/>
         <switchToPreviousTab stepKey="switchToPreviousTab"/>
         <reloadPage stepKey="reloadPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
         <actionGroup ref="addButton" stepKey="addButton2"/>
         <actionGroup ref="inlineEditButton" stepKey="inlineEditButton3">
@@ -1198,6 +1208,7 @@
         <comment userInput="Validate Storefront: New Longest Button" stepKey="commentValidateStorefront2"/>
         <switchToNextTab stepKey="switchToNextTab"/>
         <reloadPage stepKey="reloadPage2"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront2">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1287,6 +1298,7 @@
         <comment userInput="Update Button Border Width" stepKey="commentUpdateButton"/>
         <switchToPreviousTab stepKey="switchToPreviousTab"/>
         <reloadPage stepKey="reloadPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
         <actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage">
             <argument name="section" value="ButtonItemOnStage"/>
@@ -1312,6 +1324,7 @@
         <comment userInput="Validate Storefront: Updated Border Width" stepKey="commentValidateStorefront2"/>
         <switchToNextTab stepKey="switchToNextTab"/>
         <reloadPage stepKey="reloadPage2"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront2">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1325,6 +1338,7 @@
         <comment userInput="Update Button Padding Left" stepKey="commentUpdateButton2"/>
         <switchToPreviousTab stepKey="switchToPreviousTab2"/>
         <reloadPage stepKey="reloadPage3"/>
+        <waitForPageLoad stepKey="waitForPageLoad3"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage3"/>
         <actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage2">
             <argument name="section" value="ButtonItemOnStage"/>
@@ -1348,6 +1362,7 @@
         <comment userInput="Validate Storefront: Updated Padding Left" stepKey="commentValidateStorefront4"/>
         <switchToNextTab stepKey="switchToNextTab2"/>
         <reloadPage stepKey="reloadPage4"/>
+        <waitForPageLoad stepKey="waitForPageLoad4"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront3">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1361,6 +1376,7 @@
         <comment userInput="Update Button Padding Right" stepKey="commentUpdateButton3"/>
         <switchToPreviousTab stepKey="switchToPreviousTab3"/>
         <reloadPage stepKey="reloadPage5"/>
+        <waitForPageLoad stepKey="waitForPageLoad5"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage4"/>
         <actionGroup ref="openPageBuilderEditPanelSmallByIndex" stepKey="openEditMenuOnStage3">
             <argument name="section" value="ButtonItemOnStage"/>
@@ -1384,6 +1400,7 @@
         <comment userInput="Validate Storefront: Updated Padding Right" stepKey="commentValidateStorefront5"/>
         <switchToNextTab stepKey="switchToNextTab3"/>
         <reloadPage stepKey="reloadPage6"/>
+        <waitForPageLoad stepKey="waitForPageLoad6"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront4">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1731,6 +1748,7 @@
         <comment userInput="Resize Column: Large" stepKey="commentResize1"/>
         <switchToPreviousTab stepKey="switchToPreviousTab"/>
         <reloadPage stepKey="reloadPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
         <executeJS function="return document.querySelector('{{ColumnOnBackend.columnResizeGridLine('1')}}').clientWidth" stepKey="guideWidth"/>
         <dragAndDrop selector1="{{ColumnOnBackend.columnX('1')}} {{ColumnOnBackend.columnResizeHandle}}" selector2="{{ColumnOnBackend.columnResizeGridLine('11')}}" x="$guideWidth" stepKey="dragColumn1"/>
@@ -1758,6 +1776,7 @@
         <comment userInput="Validate Storefront: Large Column" stepKey="commentValidateStorefront2"/>
         <switchToNextTab stepKey="switchToNextTab2"/>
         <reloadPage stepKey="reloadPage2"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront2">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>
@@ -1786,6 +1805,7 @@
         <comment userInput="Move Buttons to Small Column" stepKey="moveButtons"/>
         <switchToPreviousTab stepKey="switchToPreviousTab2"/>
         <reloadPage stepKey="reloadPage3"/>
+        <waitForPageLoad stepKey="waitForPageLoad3"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
         <actionGroup ref="moveContentTypeToContainer" stepKey="moveButtonsToRightColumn">
             <argument name="contentType" value="PageBuilderButtonsContentType"/>
@@ -1809,6 +1829,7 @@
         <comment userInput="Validate Storefront: Small Column" stepKey="commentValidateStorefront3"/>
         <switchToNextTab stepKey="switchToNextTab3"/>
         <reloadPage stepKey="reloadPage4"/>
+        <waitForPageLoad stepKey="waitForPageLoad4"/>
         <actionGroup ref="validateButtonItemsSameSize" stepKey="validateButtonsSameSizeStorefront3">
             <argument name="buttonGroupPage" value="ButtonGroupOnStorefront"/>
             <argument name="buttonItemPage" value="ButtonItemOnStorefront"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml

@@ -899,6 +899,7 @@
         <seeElement selector="{{ColumnOnFrontend.column3BackgroundColorGrey}}"  stepKey="seeColumn3BackgroundColorApplied"/>
         <switchToPreviousTab stepKey="switchToPreviousTab"/>
         <reloadPage stepKey="reloadPage"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
         <actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditPanelForSecondColumn1">
             <argument name="contentType" value="PageBuilderColumnContentType"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageCatalogTest.xml

@@ -62,6 +62,8 @@
         <!--Overwrite uploaded image by selecting image from Media Gallery Storage-->
         <click selector="{{CategoryContentSection.SelectFromGalleryBtn}}" stepKey="clickSelectFromGalleryBtn"/>
         <waitForPageLoad stepKey="waitForPageLoad1" />
+        <click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickStorageRoot"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
             <argument name="ImageFolder" value="ImageFolder"/>
         </actionGroup>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml

@@ -93,6 +93,8 @@
         </actionGroup>
         <click selector="{{PageBuilderStage.selectFromGalleryImageBtn}}" stepKey="clickSelectfromGallery"/>
         <waitForPageLoad stepKey="waitForPageLoad"/>
+        <click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickStorageRoot"/>
+        <waitForPageLoad stepKey="waitForPageLoad2"/>
         <actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
             <argument name="ImageFolder" value="ImageFolder"/>
         </actionGroup>
@@ -280,6 +282,8 @@
         <actionGroup ref="clickSelectFromGallerySlideOut" stepKey="clickSelectFromGallerySlideOut">
             <argument name="property" value="PageBuilderImageProperty_JPG2"/>
         </actionGroup>
+        <click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickStorageRoot"/>
+        <waitForPageLoad stepKey="waitForPageLoad"/>
         <actionGroup ref="CreateImageFolder" stepKey="createImageFolder">
             <argument name="ImageFolder" value="ImageFolder"/>
         </actionGroup>