Skip to content

Commit d2db601

Browse files
bdenhambdenham
committed
MC-5927: Beta 2 release notes
commit d4d31a7 Merge: ac1eae1 ccc8775 Author: Dave Macaulay <daavem@googlemail.com> Date: Mon Dec 10 16:14:01 2018 +0000 Merge pull request #180 from magento-obsessive-owls/cms-team-1-delivery [Owls] Beta Release #2 commit ccc8775 Author: Dan Mooney <dmooney@adobe.com> Date: Thu Dec 6 18:10:20 2018 -0600 MC-4278: Hard Coded Padding On Button Groups & On Text Fix static alphabetization failure commit 64d5ad3 Merge: cbb7a73 003b736 Author: David Haecker <dhaecker@magento.com> Date: Thu Dec 6 11:01:03 2018 -0600 Merge branch 'MC-3238' into cms-team-1-delivery commit cbb7a73 Merge: 42c2e49 ed085b3 Author: Hwashiang Yu <hwyu@adobe.com> Date: Thu Dec 6 10:45:46 2018 -0600 Merge remote-tracking branch 'origin/MC-4959-need-to-remove-is-hideable' into cms-team-1-delivery commit 42c2e49 Merge: b686987 4f9cab3 Author: Dan Mooney <dmooney@adobe.com> Date: Thu Dec 6 10:27:52 2018 -0600 Merge remote-tracking branch 'remotes/origin/MC-5443' into cms-team-1-delivery commit b686987 Merge: 6466781 7af1105 Author: Cari Spruiell <spruiell@adobe.com> Date: Wed Dec 5 13:55:02 2018 -0600 Merge remote-tracking branch 'origin/cms-team-1-delivery' into MC-3818-Saving-Slide-Button-Type commit 7af1105 Merge: 1165702 ee9657d Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:16:35 2018 -0600 Merge remote-tracking branch 'origin/MC-5790-remove-reset-button' into cms-team-1-delivery commit 1165702 Merge: d2335b9 3ae4714 Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:15:28 2018 -0600 Merge remote-tracking branch 'origin/MC-4278-hard-coded-padding-on-buttons-and-text' into cms-team-1-delivery commit d2335b9 Merge: e04091f 7cfe111 Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:14:51 2018 -0600 Merge remote-tracking branch 'origin/MC-4130-review-information-covered-by-add-to-cart-button-on-stage' into cms-team-1-delivery commit e04091f Merge: 011c085 25359d2 Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:14:08 2018 -0600 Merge remote-tracking branch 'origin/MC-3992-column-width-are-not-consistent' into cms-team-1-delivery commit 011c085 Merge: 9fb17d5 d14f45a Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:13:32 2018 -0600 Merge remote-tracking branch 'origin/MC-3713-paddding-is-not-respected-on-text' into cms-team-1-delivery commit 9fb17d5 Merge: cc784c2 b22a295 Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Dec 5 12:12:25 2018 -0600 Merge remote-tracking branch 'origin/MC-3509-Image-inside-text-content-type' into cms-team-1-delivery commit cc784c2 Merge: 73e9d4b 3519237 Author: David Haecker <dhaecker@magento.com> Date: Wed Dec 5 12:01:34 2018 -0600 Merge branch 'MC-5641' into cms-team-1-delivery commit 73e9d4b Merge: 696f853 13c014c Author: David Haecker <dhaecker@magento.com> Date: Wed Dec 5 12:00:19 2018 -0600 Merge branch 'MC-5684' into cms-team-1-delivery commit 4f9cab3 Author: Dan Mooney <dmooney@adobe.com> Date: Wed Dec 5 09:09:12 2018 -0600 MC-5443: IE11 - Cannot Use Slide Item Option Menu Fix static issues commit 98808a9 Author: Dan Mooney <dmooney@adobe.com> Date: Tue Dec 4 13:58:25 2018 -0600 MC-5443: IE11 - Cannot Use Slide Item Option Menu Force minimum interaction level to be 0 and trigger interaction stop if focused on another slide in slider commit 003b736 Author: Kieu Phan <kphan@adobe.com> Date: Tue Dec 4 11:53:46 2018 -0600 MC-3238: Add Missing P0-P1 MFTF Tests For HTML Code commit 77aa5b6 Author: Dan Mooney <dmooney@adobe.com> Date: Tue Dec 4 11:39:28 2018 -0600 MC-5443: IE11 - Cannot Use Slide Item Option Menu Support applying focus to slide in one click - relatedTarget is always null for these events in IE11, but document.activeElement can be used in its place commit 48d7cfc Author: Kieu Phan <kphan@adobe.com> Date: Tue Dec 4 11:37:19 2018 -0600 MC-3238: Add Missing P0-P1 MFTF Tests For HTML Code commit 7ff925b Author: Kieu Phan <kphan@adobe.com> Date: Tue Dec 4 11:34:39 2018 -0600 MC-3238: Add Missing P0-P1 MFTF Tests For HTML Code commit ed085b3 Author: Hwashiang Yu <hwyu@adobe.com> Date: Tue Dec 4 10:57:27 2018 -0600 MC-4959: Need to remove is_hideable option from content type configuration - Fixed test step selector commit ee9657d Author: Hwashiang Yu <hwyu@adobe.com> Date: Tue Dec 4 10:34:30 2018 -0600 MC-5790: Remove Reset Button From Slide Outs For All Content Types - Updated test severity commit 564dbde Author: Kieu Phan <kphan@adobe.com> Date: Tue Dec 4 09:49:36 2018 -0600 MC-3238: Add Missing P0-P1 MFTF Tests For HTML Code commit bac265a Author: Dan Mooney <dmooney@adobe.com> Date: Mon Dec 3 12:41:57 2018 -0600 MC-5443: IE11 - Cannot Use Slide Item Option Menu Set .navigation-dot.active .pagebuilder-options z-index to auto - IE11 does not support clicks on elements with negative z-index commit 369bd00 Author: Hwashiang Yu <hwyu@adobe.com> Date: Mon Dec 3 12:01:10 2018 -0600 MC-4959: Need to remove is_hideable option from content type configuration - Resolved minor typescript formatting issue - Updated button item test commit 696f853 Author: Kieu Phan <kphan@adobe.com> Date: Mon Dec 3 11:54:13 2018 -0600 MC-3996: MFTF "notHidden" Selectors Are Written Incorrectly Fixed notHidden selector on Block, Product, Video commit 3ae4714 Author: Hwashiang Yu <hwyu@adobe.com> Date: Fri Nov 30 22:43:04 2018 -0600 MC-4278: Hard Coded Padding On Button Groups & On Text - Stabilized button item test commit 669900a Author: Hwashiang Yu <hwyu@adobe.com> Date: Fri Nov 30 18:19:26 2018 -0600 MC-4959: Need to remove is_hideable option from content type configuration - Updated options logic to individual content type preview commit ec7f3f2 Author: Kieu Phan <kphan@adobe.com> Date: Fri Nov 30 16:16:43 2018 -0600 MC-3996: MFTF notHidden Selectors Are Written Incorrectly Changed ancestor to parent in selectors commit 13c014c Author: David Haecker <dhaecker@magento.com> Date: Fri Nov 30 15:17:36 2018 -0600 MC-5684: MFTF - Change expectedIndex to expectedCount in Duplication Action Groups - Fixing failing test commit fa51d04 Author: David Haecker <dhaecker@magento.com> Date: Fri Nov 30 13:14:38 2018 -0600 MC-5684: MFTF - Change expectedIndex to expectedCount in Duplication Action Groups - Fixing duplicate content type action group to prevent confusion commit 7a9dd92 Author: Hwashiang Yu <hwyu@adobe.com> Date: Thu Nov 29 16:51:00 2018 -0600 MC-5790: Remove Reset Button From Slide Outs For All Content Types - Removed reset button from form - Removed reset button block - Added test to check for reset button in row form commit 3519237 Author: Kieu Phan <kphan@adobe.com> Date: Thu Nov 29 16:35:06 2018 -0600 MC-5641: MFTF Test Has Incorrect Assertions: ButtonGroupValidateSameSizeForPrimaryButtonsInColumnResizing Fixed actual variable and expected variable for 2 assertions at stepKey assertButtonSmallerThanColumnStorefrontMobile2 & assertButtonSmallerThanColumnStorefrontMobile3 commit b6be4c9 Author: Kieu Phan <kphan@adobe.com> Date: Thu Nov 29 16:31:47 2018 -0600 MC-5641: MFTF Test Has Incorrect Assertions: ButtonGroupValidateSameSizeForPrimaryButtonsInColumnResizing Fixed actual variable and expected variable for 2 assertions at stepKey assertButtonSmallerThanColumnStorefrontMobile2 & assertButtonSmallerThanColumnStorefrontMobile3 commit cb70dc2 Author: Hwashiang Yu <hwyu@adobe.com> Date: Thu Nov 29 14:20:16 2018 -0600 MC-4959: Need to remove is_hideable option from content type configuration - Removed debugger from code commit 10ae961 Author: Hwashiang Yu <hwyu@adobe.com> Date: Thu Nov 29 14:16:57 2018 -0600 MC-4959: Need to remove is_hideable option from content type configuration - Removed is_hideable from configurations and documentation - Added test coverage for is_hideable content types commit be9b830 Author: Hwashiang Yu <hwyu@adobe.com> Date: Wed Nov 28 16:54:36 2018 -0600 MC-4278: Hard Coded Padding On Button Groups & On Text - Removed hard coded paddings on buttons and text commit 6466781 Author: Cari Spruiell <spruiell@adobe.com> Date: Tue Nov 27 15:35:52 2018 -0600 MC-3818: Saving Slide Button Type As Secondary Or Link Will Still Show As Primary On Edit Form - fix automated test targeting wrong value commit 7cfe111 Author: Hwashiang Yu <hwyu@adobe.com> Date: Tue Nov 27 14:33:23 2018 -0600 MC-4130: Review Information Covered By Add To Cart Button On Products On Stage - Added styling to product item review summary to match closer to the storefront commit ed15d2d Author: Cari Spruiell <spruiell@adobe.com> Date: Tue Nov 27 11:45:03 2018 -0600 MC-3818: Saving Slide Button Type As Secondary Or Link Will Still Show As Primary On Edit Form - updated automated test to cover bug scenario commit 25359d2 Author: Hwashiang Yu <hwyu@adobe.com> Date: Tue Nov 27 11:10:30 2018 -0600 MC-3992: Columns Widths Are Not Consistent Between Stage & Storefront - Added box-sizing style to column content type commit 3f37371 Author: Cari Spruiell <spruiell@adobe.com> Date: Mon Nov 26 22:14:39 2018 -0600 MC-3818: Saving Slide Button Type As Secondary Or Link Will Still Show As Primary On Edit Form - corrected class name of slide button commit d14f45a Author: Hwashiang Yu <hwyu@adobe.com> Date: Mon Nov 26 18:15:52 2018 -0600 MC-3713: Padding is not respected on Text - Added styling, css, and attribute to text area element when wysiwyg is diabled on stage - Added test coverage for text advanced configuration for both when wysiwyg is disabled completely and disbled by default commit b22a295 Author: Hwashiang Yu <hwyu@adobe.com> Date: Mon Nov 26 13:21:16 2018 -0600 MC-3509: Image inside Text Content Type is scaled on stage - Added styling banner, slider, and text to set image height to auto.
1 parent 6707e31 commit d2db601

File tree

87 files changed

+1080
-200
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+1080
-200
lines changed

‎app/code/Magento/PageBuilder/Block/Adminhtml/ContentType/Edit/ResetButton.php

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎app/code/Magento/PageBuilder/Model/Stage/Config.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ private function flattenContentTypeData(string $name, array $contentType)
179179
'label' => $contentType['label'],
180180
'icon' => $contentType['icon'],
181181
'form' => $contentType['form'],
182-
'is_hideable' =>
183-
isset($contentType['is_hideable']) && $contentType['is_hideable'] === 'false' ? false : true,
184182
'contentType' => '',
185183
'group' => $contentType['group'] ?? 'general',
186184
'fields' => $this->uiComponentConfig->getFields($contentType['form']),

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,21 @@
8383
<arguments>
8484
<argument name="contentType"/>
8585
<argument name="targetIndex" defaultValue="1" type="string"/>
86-
<argument name="expectedIndex" defaultValue="2" type="string"/>
8786
<argument name="contentTypeXCoordinate" defaultValue="null" type="string"/>
8887
<argument name="contentTypeYCoordinate" defaultValue="null" type="string"/>
8988
</arguments>
89+
<waitForElement selector="{{PageBuilderStage.contentTypeTotalInStage(contentType.role)}}" stepKey="waitForAllContentTypes"/>
90+
<executeJS function="return document.querySelectorAll('{{PageBuilderStage.contentTypeTotalInStage(contentType.role)}}').length+1" stepKey="expectedContentTypeCount"/>
9091
<waitForElementVisible selector="{{PageBuilderStage.contentTypeInStageByIndex(contentType.role, targetIndex)}}" stepKey="waitForContentTypeInStageVisible"/>
9192
<moveMouseOver selector="{{PageBuilderStage.contentTypeInStageByIndex(contentType.role, targetIndex)}}" x="{{contentTypeXCoordinate}}" y="{{contentTypeYCoordinate}}" stepKey="onMouseOverContentTypeStage"/>
9293
<waitForElementVisible selector="{{PageBuilderContentTypeOptionsMenu.contentTypeOptionsMenuByIndex(contentType.role, targetIndex)}}" stepKey="waitForOptionsMenu"/>
9394
<click selector="{{PageBuilderContentTypeOptionsMenu.contentTypeDuplicate(contentType.role, targetIndex)}}" stepKey="clickDuplicateContentType"/>
9495
<waitForPageLoad time="30" stepKey="waitForAnimation"/>
95-
<waitForElementVisible selector="{{PageBuilderStage.contentTypeInStageByIndex(contentType.role, expectedIndex)}}" stepKey="waitForDuplicateContentType"/>
96+
<executeJS function="return document.querySelectorAll('{{PageBuilderStage.contentTypeTotalInStage(contentType.role)}}').length" stepKey="resultingContentTypeCount"/>
97+
<assertEquals stepKey="assertContentTypeCount">
98+
<actualResult type="variable">$resultingContentTypeCount</actualResult>
99+
<expectedResult type="variable">$expectedContentTypeCount</expectedResult>
100+
</assertEquals>
96101
</actionGroup>
97102
<actionGroup name="duplicateSmallContentType">
98103
<arguments>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBannerSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<section name="BannerOnBackend">
6969
<element name="base" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]" parameterized="true"/>
7070
<element name="hidden" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
71-
<element name="notHidden" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
71+
<element name="notHidden" type="button" selector="(//div[contains(@class,'pagebuilder-banner') and contains(@class,'pagebuilder-content-type')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
7272
<element name="wrapperJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-banner-wrapper')[{{arg1}} - 1]" parameterized="true"/>
7373
<element name="overlay" type="button" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-banner')])[{{arg1}}]//div[@data-element='overlay']" parameterized="true"/>
7474
<element name="overlayJS" type="button" selector="document.querySelectorAll('[data-role=banner] div.pagebuilder-overlay')[{{arg1}} - 1]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBlockSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<element name="title" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@class,'pagebuilder-options-wrapper')]//div[contains(@class,'option-title') and text()='{{arg}}']" parameterized="true"/>
1616
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]" parameterized="true"/>
1717
<element name="hidden" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
18-
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
18+
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-block') and not(contains(@class,'placeholder'))])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1919
<element name="hr" type="button" selector="((//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[@data-identifier])[{{arg2}}]//hr" parameterized="true"/>
2020
<element name="content" type="text" selector="(//div[contains(@class,'pagebuilder-block')])[{{arg1}}]//div[contains(@class,'block-static-block')]" parameterized="true"/>
2121
<!-- Advanced Configuration -->

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderButtonsSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<element name="jsButtonGroupSelector" type="text" selector="document.querySelectorAll('.pagebuilder-buttons')[{{arg1}}-1]" parameterized="true"/>
1313
<element name="base" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]" parameterized="true"/>
1414
<element name="hidden" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
15-
<element name="notHidden" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
15+
<element name="notHidden" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1616
<element name="appearance" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]//div[@data-appearance='{{arg2}}']" parameterized="true"/>
1717
<element name="sameSizeValue" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]//div[@data-element='main'][@data-same-width='{{arg2}}']" parameterized="true"/>
1818
<element name="addNewButtonItemOption" type="button" selector="(//div[contains(@class,'pagebuilder-buttons')])[{{arg1}}]//a[contains(@title,'Add Button')]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderDividerSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<element name="allDividers" type="text" selector="//div[contains(@class,'pagebuilder-divider')]"/>
1313
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]" parameterized="true"/>
1414
<element name="hidden" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
15-
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
15+
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1616
<element name="color" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]//hr[contains(@style,'border-color: {{arg2}};')]" parameterized="true"/>
1717
<element name="noColor" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]//hr[not(contains(@style,'border-color:'))]" parameterized="true"/>
1818
<element name="thickness" type="text" selector="(//div[contains(@class,'pagebuilder-divider')])[{{arg1}}]//hr[contains(@style,'border-width: {{arg2}}px;')]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHeadingSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<element name="all" type="button" selector="//div[contains(@class,'pagebuilder-heading')]"/>
1313
<element name="base" type="text" selector="(//*[@data-role='heading'])[{{arg1}}]" parameterized="true"/>
1414
<element name="hidden" type="text" selector="(//*[@data-role='heading'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
15-
<element name="notHidden" type="text" selector="(//*[@data-role='heading'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
15+
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-heading')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1616
<element name="baseByTagName" type="text" selector="(//{{arg1}})[{{arg2}}]" parameterized="true"/>
1717
<element name="allHeadingsInContainer" type="button" selector="(//div[contains(@class, '{{arg1}}-container')])[{{arg2}}]//div[contains(@class,'pagebuilder-heading')]" parameterized="true"/>
1818
<element name="headingText" type="button" selector="(//{{arg1}}[.= '{{arg2}}'])[{{arg3}}]" parameterized="true"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderHtmlSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<section name="HtmlOnStage">
1111
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-html')]//div[contains(@data-bind,'text: data.main.html') or contains(@class,'placeholder-html-empty')])[{{arg1}}]" parameterized="true"/>
1212
<element name="hidden" type="text" selector="(//*[@data-role='html'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
13-
<element name="notHidden" type="text" selector="(//*[@data-role='html'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
13+
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-html')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1414
<element name="empty" type="text" selector="(//div[contains(@class,'placeholder-html-empty')])[{{arg1}}]" parameterized="true"/>
1515
<element name="html" type="text" selector="(//div[contains(@class,'pagebuilder-html')]//div[contains(@data-bind,'text: data.main.html')])[{{arg1}}]{{arg2}}" parameterized="true"/>
1616
<!-- Advanced Configuration -->

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderImageSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<section name="ImageOnStageWithoutImageUploaded">
1212
<element name="base" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]" parameterized="true"/>
1313
<element name="hidden" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
14-
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
14+
<element name="notHidden" type="text" selector="(//div[contains(@class,'pagebuilder-content-type') and contains(@class,'pagebuilder-image')])[{{arg1}}]/parent::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
1515
<element name="attachImageBtn" type="button" selector="//div[@class='pagebuilder-image-uploader-container']//input[@name='image']" />
1616
<element name="imageSourceByIndex" type="button" selector="(//div[contains(@class, 'pagebuilder-content-type') and contains(@class, 'pagebuilder-image')])[{{arg1}}]//img[contains(@src,'{{arg2}}')]" parameterized="true"/>
1717
<element name="imageEmptyPreview" type="text" selector="//div[contains(concat(' ', normalize-space(@class), ' '), ' pagebuilder-image-empty-preview ')]" />

0 commit comments

Comments
 (0)