AC-13306::Adobe Commerce 2.4.8 core code is compatible with PHP 8.4

Author: djadobe16

app/code/Magento/PageBuilder/Block/Adminhtml/Stage/Render.php

@@ -56,7 +56,7 @@ public function __construct(
         Config $config,
         Json $json,
         array $data = [],
-        Minification $minification = null
+        ?Minification $minification = null
     ) {
         parent::__construct($context, $data);
         $this->fileManager = $fileManager;

app/code/Magento/PageBuilder/Block/WysiwygSetup.php

@@ -49,7 +49,7 @@ public function __construct(
         Context $context,
         ConfigInterface $config,
         array $data = [],
-        FrontendInterface $cache = null,
+        ?FrontendInterface $cache = null,
         ?RandomKey $sessionRandomKey = null
     ) {
         $this->config = $config;

app/code/Magento/PageBuilder/Component/Form/Element/Wysiwyg.php

@@ -70,10 +70,10 @@ public function __construct(
         array $components = [],
         array $data = [],
         array $config = [],
-        PageBuilderConfig $pageBuilderConfig = null,
+        ?PageBuilderConfig $pageBuilderConfig = null,
         bool $overrideSnapshot = false,
-        Repository $assetRepo = null,
-        AuthorizationInterface $authorization = null
+        ?Repository $assetRepo = null,
+        ?AuthorizationInterface $authorization = null
     ) {
         $this->assetRepo = $assetRepo ?: ObjectManager::getInstance()->get(Repository::class);
         $this->authorization = $authorization ?: ObjectManager::getInstance()->get(AuthorizationInterface::class);

app/code/Magento/PageBuilder/Component/Form/HtmlCode.php

@@ -63,7 +63,7 @@ public function __construct(
         BackendUrlInterface $backendUrl,
         Images $imagesHelper,
         VariableConfig $variableConfig,
-        OpenDialogUrl $openDialogUrl = null,
+        ?OpenDialogUrl $openDialogUrl = null,
         $currentTreePath = 'wysiwyg',
         $components = [],
         array $data = []

app/code/Magento/PageBuilder/Controller/Adminhtml/ContentType/Image/Upload.php

@@ -71,7 +71,7 @@ public function __construct(
         \Magento\Framework\File\UploaderFactory $uploaderFactory,
         \Magento\Framework\Filesystem\DirectoryList $directoryList,
         \Magento\Cms\Helper\Wysiwyg\Images $cmsWysiwygImages,
-        Filesystem $filesystem = null
+        ?Filesystem $filesystem = null
     ) {
         parent::__construct($context);
         $this->resultJsonFactory = $resultJsonFactory;

app/code/Magento/PageBuilder/Controller/ContentType/Preview.php

@@ -43,7 +43,7 @@ class Preview extends \Magento\Framework\App\Action\Action implements HttpPostAc
     public function __construct(
         \Magento\Backend\App\Action\Context $context,
         \Magento\PageBuilder\Model\Stage\RendererPool $rendererPool,
-        \Magento\Backend\Model\Auth $auth = null
+        ?\Magento\Backend\Model\Auth $auth = null
     ) {
         parent::__construct($context);
 

app/code/Magento/PageBuilder/Model/Catalog/Sorting/SimpleOption.php

@@ -43,9 +43,9 @@ class SimpleOption implements OptionInterface
      */
     public function __construct(
         string $label,
-        string $sortDirection = null,
-        string $attributeField = null,
-        string $secondarySortDirection = null
+        ?string $sortDirection = null,
+        ?string $attributeField = null,
+        ?string $secondarySortDirection = null
     ) {
         $this->label = $label;
         $this->sortDirection = $sortDirection;

app/code/Magento/PageBuilder/Model/Dom/Adapter/DocumentInterface.php

@@ -38,7 +38,7 @@ public function createDocumentFragment(): DocumentFragmentInterface;
      * @param string $value [optional]
      * @return ElementInterface
      */
-    public function createElement(string $name, string $value = null);
+    public function createElement(string $name, ?string $value = null);
 
     /**
      * Returns the first element matching the specified selector.
@@ -62,7 +62,7 @@ public function querySelectorAll(string $selector): HtmlCollectionInterface;
      * @param DOMNode|null $node
      * @return string
      */
-    public function saveHTML(DOMNode $node = null): string;
+    public function saveHTML(?DOMNode $node = null): string;
 
     /**
      * Closes the stream and any underlying resources.

app/code/Magento/PageBuilder/Model/Dom/Document.php

@@ -73,7 +73,7 @@ public function createDocumentFragment(): DocumentFragmentInterface
     /**
      * @inheritDoc
      */
-    public function createElement(string $name, string $value = null): ElementInterface
+    public function createElement(string $name, ?string $value = null): ElementInterface
     {
         return $this->objectManager->create(
             ElementInterface::class,
@@ -106,7 +106,7 @@ public function querySelectorAll(string $selector): HtmlCollectionInterface
     /**
      * @inheritDoc
      */
-    public function saveHTML(DOMNode $node = null): string
+    public function saveHTML(?DOMNode $node = null): string
     {
         return $this->document->saveHTML($node);
     }

app/code/Magento/PageBuilder/Model/ResourceModel/Template/Grid/Collection.php

@@ -62,7 +62,7 @@ public function __construct(
         $resourceModel,
         $model = Document::class,
         $connection = null,
-        AbstractDb $resource = null
+        ?AbstractDb $resource = null
     ) {
         $this->resourceModel = $resourceModel;
         $this->model = $model;
@@ -128,7 +128,7 @@ public function getSearchCriteria()
      * @return $this
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function setSearchCriteria(SearchCriteriaInterface $searchCriteria = null)
+    public function setSearchCriteria(?SearchCriteriaInterface $searchCriteria = null)
     {
         return $this;
     }
@@ -162,7 +162,7 @@ public function setTotalCount($totalCount)
      * @return $this
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function setItems(array $items = null)
+    public function setItems(?array $items = null)
     {
         return $this;
     }