Skip to content

Commit d0f462d

Browse files
author
Michael Yu
committed
MC-3031: MFTF Test Updates
- Resolved block and product test failure - Added contenttype not in container action group to resolve row into column test
1 parent 0631211 commit d0f462d

File tree

5 files changed

+18
-3
lines changed

5 files changed

+18
-3
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/StageActionGroup.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,12 @@
4646
</arguments>
4747
<waitForElementVisible time="30" selector="{{PageBuilderStage.contentTypeInsideContainerStage(containerTargetType.role, containerTargetIndex, positionInContainer, contentType.role, contentTypeIndex)}}" stepKey="waitForContentTypeStage"/>
4848
</actionGroup>
49+
<actionGroup name="validateContentTypeNotInsideContainerStage">
50+
<arguments>
51+
<argument name="contentType"/>
52+
<argument name="containerTargetType"/>
53+
<argument name="containerTargetIndex" defaultValue="1" type="string"/>
54+
</arguments>
55+
<waitForElementVisible time="30" selector="{{PageBuilderStage.contentTypeNotInsideContainerStage(containerTargetType.role, containerTargetIndex, contentType.role)}}" stepKey="waitForContentTypeStage"/>
56+
</actionGroup>
4957
</actionGroups>

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderStageSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
<element name="contentTypeInStageByIndex" type="button" selector='(//div[contains(@class, "pagebuilder-content-type") and contains(@class, "pagebuilder-{{arg1}}")])[{{arg2}}]' parameterized="true"/>
2828
<element name="contentTypeContainer" type="button" selector='(//div[contains(@class, "pagebuilder-content-type") and contains(@class, "pagebuilder-{{arg1}}")])[{{arg2}}]/descendant::div[contains(@class, "element-children")]' parameterized="true"/>
2929
<element name="contentTypeInsideContainerStage" type="button" selector='(//div[contains(@class, "{{arg1}}-container")])[{{arg2}}]//div[contains(@class,"pagebuilder-content-type-wrapper")][{{arg3}}]//div[contains(@class,"pagebuilder-{{arg4}}")][{{arg5}}]' parameterized="true"/>
30+
<element name="contentTypeNotInsideContainerStage" type="button" selector='(//div[contains(@class, "{{arg1}}-container")])[{{arg2}}][not(.//div[contains(@class, "pagebuilder-{{arg3}}")])]' parameterized="true"/>
3031
<element name="contentTypePreviewInStage" type="button" selector="div.pagebuilder-{{arg1}}.pagebuilder-content-type" parameterized="true"/>
3132
<element name="computedHeightOnStage" type="text" selector="return parseInt(window.getComputedStyle(document.querySelector('.pagebuilder-{{arg1}}:nth-of-type({{arg2}})')).height)" parameterized="true"/>
3233
<element name="computedWidthOnStage" type="text" selector="return parseInt(window.getComputedStyle(document.querySelector('.pagebuilder-{{arg1}}:nth-of-type({{arg2}})')).width)" parameterized="true"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@
488488
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
489489
<argument name="contentType" value="PageBuilderBlockContentType"/>
490490
</actionGroup>
491-
<actionGroup ref="validateContentTypeInsideContainerStorefront" stepKey="checkContentTypeInContainerStorefront">
491+
<actionGroup ref="validateContentTypeInsideContainerStorefrontInDOM" stepKey="checkContentTypeInContainerStorefront">
492492
<argument name="contentType" value="PageBuilderBlockContentType"/>
493493
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
494494
<argument name="contentTypeIndex" value="1"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -836,7 +836,7 @@
836836
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
837837
<argument name="contentType" value="PageBuilderProductsContentType"/>
838838
</actionGroup>
839-
<actionGroup ref="validateContentTypeInsideContainerStorefront" stepKey="checkContentTypeInContainerStorefront">
839+
<actionGroup ref="validateContentTypeInsideContainerStorefrontInDOM" stepKey="checkContentTypeInContainerStorefront">
840840
<argument name="contentType" value="PageBuilderProductsContentType"/>
841841
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
842842
<argument name="contentTypeIndex" value="1"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,12 @@
11361136
<argument name="containerTargetIndex" value="2" />
11371137
</actionGroup>
11381138
<waitForPageLoad stepKey="waitForAnimation" time="30"/>
1139-
<seeNumberOfElements selector="{{RowOnStage.allRows}}" userInput="1" stepKey="seeOnlyOneElementRow"/>
1139+
<!-- Validate Stage -->
1140+
<comment userInput="User dont sees Row displayed in column on Stage" stepKey="confirmNoRowInColumn"/>
1141+
<actionGroup ref="validateContentTypeNotInsideContainerStage" stepKey="checkContentTypeNotInContainerStage">
1142+
<argument name="contentType" value="PageBuilderRowContentType"/>
1143+
<argument name="containerTargetType" value="PageBuilderColumnContentType"/>
1144+
<argument name="containerTargetIndex" value="2"/>
1145+
</actionGroup>
11401146
</test>
11411147
</tests>

0 commit comments

Comments
 (0)