Skip to content

Commit d0d1312

Browse files
committed
#419: Nested Links If User Adds Link Attribute & Link Widget to Banner/Slide, Banner, Slide MFTF test refactored.
1 parent 8905ad7 commit d0d1312

File tree

2 files changed

+32
-13
lines changed

2 files changed

+32
-13
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCommonTest/BannerCannotHaveInlineWysiwygWidgetAndLinkUrlTest.xml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,19 @@
2222
</annotations>
2323
<before>
2424
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
25+
<createData entity="simpleCmsPage" stepKey="createCMSPageA"/>
2526
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2627
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
27-
<createData entity="_defaultCmsPage" stepKey="createCMSPageA"/>
2828
</before>
2929
<after>
30-
<deleteData createDataKey="createCMSPageA" stepKey="deletePreReqCMSPageA"/>
30+
<deleteData createDataKey="createCMSPageA" stepKey="deleteCMSPageA"/>
31+
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
32+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="navigateToMediaGalleryNavigateToFolder">
33+
<argument name="FolderName" value="{{ImageFolder.name}}"/>
34+
</actionGroup>
35+
<actionGroup ref="DeleteFolderActionGroup" stepKey="deleteMediaGalleryFolder">
36+
<argument name="ImageFolder" value="ImageFolder"/>
37+
</actionGroup>
3138
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3239
</after>
3340
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -101,10 +108,10 @@
101108
<actionGroup ref="CreateImageFolderActionGroup" stepKey="createTinyMCESelectorBrowseModalStorageRootImageFolder">
102109
<argument name="ImageFolder" value="ImageFolder"/>
103110
</actionGroup>
104-
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromTinyMCESelectorBrowseModalStorageRootMediaStorage">
111+
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromTinyMCESelectorBrowseModalStorageRootImageFolder">
105112
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
106113
</actionGroup>
107-
<actionGroup ref="SaveImageActionGroup" stepKey="saveTinyMCESelectorBrowseModalStorageRootMediaStorageImage"/>
114+
<actionGroup ref="SaveImageActionGroup" stepKey="saveTinyMCESelectorBrowseModalStorageRootImageFolderImage"/>
108115
<fillField selector="{{WYSIWYGInsertLinkModal.textToDisplayInput}}" userInput="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="insertTinyMCELinkModalTextToDisplay"/>
109116
<click selector="{{WYSIWYGInsertLinkModal.okButton}}" stepKey="clickTinyMCELinkModalOkButton"/>
110117
<waitForElementNotVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForTinyMCEInsertLinkModalGone"/>
@@ -190,7 +197,6 @@
190197
</assertFalse>
191198
<!-- Check inline WYSIWYG editor will validate for not allowing Image Link and Link URL at the same time -->
192199
<comment userInput="Check inline WYSIWYG editor will validate for not allowing Image Link and Link URL at the same time" stepKey="commentCheckInlineWYSIWYGPreventAddingImageLinkAndLinkUrl"/>
193-
194200
<click selector="{{PageBuilderStage.inlineWYSIWYGEditor(PageBuilderBannerContentType.role, '1')}}" stepKey="focusOnInlineWYSIWYGEditorAreaAddImageLink"/>
195201
<waitForElementVisible selector="{{PageBuilderStage.inlineWYSIWYGEditorPanel(PageBuilderBannerContentType.role, '1')}}" stepKey="waitForInlineWYSIWYGEditorPanelAddImageLink"/>
196202
<!-- Add Image Link to inline WYSIWYG -->
@@ -201,10 +207,13 @@
201207
<waitForPageLoad stepKey="waitForInlineWYSIWYGImageSelectorBrowseModal"/>
202208
<click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickInlineWYSIWYGSelectorBrowseModalStorageRoot"/>
203209
<waitForPageLoad stepKey="waitForInlineWYSIWYGSelectorBrowseModalStorageRoot"/>
204-
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromInlineWYSIWYGSelectorBrowseModalStorageRootMediaStorage">
210+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="navigateToInlineWYSIWYGSelectorBrowseModalStorageRootImageFolder">
211+
<argument name="FolderName" value="{{ImageFolder.name}}"/>
212+
</actionGroup>
213+
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromInlineWYSIWYGSelectorBrowseModalStorageRootImageFolder">
205214
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
206215
</actionGroup>
207-
<actionGroup ref="SaveImageActionGroup" stepKey="saveInlineWYSIWYGSelectorBrowseModalStorageRootMediaStorageImage"/>
216+
<actionGroup ref="SaveImageActionGroup" stepKey="saveInlineWYSIWYGSelectorBrowseModalStorageRootImageFolderImage"/>
208217
<fillField selector="{{WYSIWYGInsertLinkModal.textToDisplayInput}}" userInput="{{PageBuilderBannerLinkUrlProperty.value}}" stepKey="insertInlineWYSIWYGLinkModalTextToDisplay"/>
209218
<click selector="{{WYSIWYGInsertLinkModal.okButton}}" stepKey="clickInlineWYSIWYGLinkModalOkButton"/>
210219
<waitForElementNotVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForInlineWYSIWYGInsertLinkModalGone"/>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemCommonTest/SlideItemCannotHaveInlineWysiwygWidgetAndLinkUrlTest.xml

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,19 @@
2222
</annotations>
2323
<before>
2424
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
25+
<createData entity="simpleCmsPage" stepKey="createCMSPageA"/>
2526
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2627
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
27-
<createData entity="_defaultCmsPage" stepKey="createCMSPageA"/>
2828
</before>
2929
<after>
30-
<deleteData createDataKey="createCMSPageA" stepKey="deletePreReqCMSPageA"/>
30+
<deleteData createDataKey="createCMSPageA" stepKey="deleteCMSPageA"/>
31+
<actionGroup ref="NavigateToMediaGalleryActionGroup" stepKey="navigateToMediaGallery"/>
32+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="navigateToMediaGalleryNavigateToFolder">
33+
<argument name="FolderName" value="{{ImageFolder.name}}"/>
34+
</actionGroup>
35+
<actionGroup ref="DeleteFolderActionGroup" stepKey="deleteMediaGalleryFolder">
36+
<argument name="ImageFolder" value="ImageFolder"/>
37+
</actionGroup>
3138
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3239
</after>
3340
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
@@ -102,10 +109,10 @@
102109
<actionGroup ref="CreateImageFolderActionGroup" stepKey="createTinyMCESelectorBrowseModalStorageRootImageFolder">
103110
<argument name="ImageFolder" value="ImageFolder"/>
104111
</actionGroup>
105-
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromTinyMCESelectorBrowseModalStorageRootMediaStorage">
112+
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromTinyMCESelectorBrowseModalStorageRootImageFolder">
106113
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
107114
</actionGroup>
108-
<actionGroup ref="SaveImageActionGroup" stepKey="saveTinyMCESelectorBrowseModalStorageRootMediaStorageImage"/>
115+
<actionGroup ref="SaveImageActionGroup" stepKey="saveTinyMCESelectorBrowseModalStorageRootImageFolderImage"/>
109116
<fillField selector="{{WYSIWYGInsertLinkModal.textToDisplayInput}}" userInput="{{PageBuilderSlideItemLinkURL_External.value}}" stepKey="insertTinyMCELinkModalTextToDisplay"/>
110117
<click selector="{{WYSIWYGInsertLinkModal.okButton}}" stepKey="clickTinyMCELinkModalOkButton"/>
111118
<waitForElementNotVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForTinyMCEInsertLinkModalGone"/>
@@ -201,10 +208,13 @@
201208
<waitForPageLoad stepKey="waitForInlineWYSIWYGImageSelectorBrowseModal"/>
202209
<click selector="{{MediaGallerySection.StorageRootArrow}}" stepKey="clickInlineWYSIWYGSelectorBrowseModalStorageRoot"/>
203210
<waitForPageLoad stepKey="waitForInlineWYSIWYGSelectorBrowseModalStorageRoot"/>
204-
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromInlineWYSIWYGSelectorBrowseModalStorageRootMediaStorage">
211+
<actionGroup ref="NavigateToMediaFolderActionGroup" stepKey="navigateToInlineWYSIWYGSelectorBrowseModalStorageRootImageFolder">
212+
<argument name="FolderName" value="{{ImageFolder.name}}"/>
213+
</actionGroup>
214+
<actionGroup ref="AttachImageActionGroup" stepKey="selectImageFromInlineWYSIWYGSelectorBrowseModalStorageRootImageFolder">
205215
<argument name="Image" value="PageBuilderImageProperty_StageJPG"/>
206216
</actionGroup>
207-
<actionGroup ref="SaveImageActionGroup" stepKey="saveInlineWYSIWYGSelectorBrowseModalStorageRootMediaStorageImage"/>
217+
<actionGroup ref="SaveImageActionGroup" stepKey="saveInlineWYSIWYGSelectorBrowseModalStorageRootImageFolderImage"/>
208218
<fillField selector="{{WYSIWYGInsertLinkModal.textToDisplayInput}}" userInput="{{PageBuilderSlideItemLinkURL_External.value}}" stepKey="insertInlineWYSIWYGLinkModalTextToDisplay"/>
209219
<click selector="{{WYSIWYGInsertLinkModal.okButton}}" stepKey="clickInlineWYSIWYGLinkModalOkButton"/>
210220
<waitForElementNotVisible selector="{{WYSIWYGInsertLinkModal.modal}}" stepKey="waitForInlineWYSIWYGInsertLinkModalGone"/>

0 commit comments

Comments
 (0)