Skip to content

Commit cfc378c

Browse files
committed
MC-3847: Issues With Same Width Buttons In Tabs
- Resolve static code style issues - Update jasmine test for tabs widget with add functionality
1 parent 6251972 commit cfc378c

File tree

3 files changed

+6
-3
lines changed
  • app/code/Magento/PageBuilder/view
  • dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/view/frontend/web/js/content-type/tabs/appearance/default

3 files changed

+6
-3
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/css/source/_config.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
._required {
2828
> .admin__field-label {
2929
> label:after {
30-
color: #e22626;
30+
color: @color-tomato-brick;
3131
content: '*';
3232
display: inline-block;
3333
font-size: 1.6rem;

app/code/Magento/PageBuilder/view/base/web/js/content-type/tabs/appearance/default/widget.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ define([
3232
$element.find('.tabs-navigation li:not(:first-child)').css('marginLeft', -borderWidth);
3333
},
3434
activate:
35+
3536
/**
3637
* Trigger redraw event since new content is being displayed
3738
*/

dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/view/frontend/web/js/content-type/tabs/appearance/default/widget.test.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ define([
2020

2121
expect($.ui.tabs).toHaveBeenCalledWith({
2222
active: 1,
23-
create: jasmine.any(Function)
23+
create: jasmine.any(Function),
24+
activate: jasmine.any(Function)
2425
}, el);
2526
});
2627

@@ -33,7 +34,8 @@ define([
3334

3435
expect($.ui.tabs).toHaveBeenCalledWith({
3536
active: 0,
36-
create: jasmine.any(Function)
37+
create: jasmine.any(Function),
38+
activate: jasmine.any(Function)
3739
}, el);
3840
});
3941
});

0 commit comments

Comments
 (0)