Skip to content

Commit ca534de

Browse files
committed
MC-5255: Flaky MFTF Map Tests
Add more waits before conditionalClick on google modal on addLocationForm
1 parent 918465a commit ca534de

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeMapActionGroup.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
<waitForPageLoad stepKey="waitForPageLoad2"/>
1717
<waitForElementVisible selector="{{AddLocationForm.form}}" stepKey="waitForForm"/>
1818
<see userInput="Add Location" selector="{{AddLocationForm.formTitle}}" stepKey="seeFormTitle"/>
19+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
1920
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
2021
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
2122
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>
@@ -47,6 +48,7 @@
4748
<waitForPageLoad stepKey="waitForPageLoad"/>
4849
<waitForElementVisible selector="{{AddLocationForm.form}}" stepKey="waitForForm"/>
4950
<see userInput="Add Location" selector="{{AddLocationForm.formTitle}}" stepKey="seeFormTitle"/>
51+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
5052
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
5153
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
5254
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>
@@ -63,6 +65,7 @@
6365
<waitForPageLoad stepKey="waitForPageLoad"/>
6466
<waitForElementVisible selector="{{AddLocationForm.form}}" stepKey="waitForForm"/>
6567
<see userInput="Add Location" selector="{{AddLocationForm.formTitle}}" stepKey="seeFormTitle"/>
68+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
6669
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
6770
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
6871
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>
@@ -107,6 +110,7 @@
107110
<argument name="x" defaultValue="null" type="string"/>
108111
<argument name="y" defaultValue="null" type="string"/>
109112
</arguments>
113+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
110114
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
111115
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
112116
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>
@@ -120,6 +124,7 @@
120124
<argument name="x" defaultValue="null" type="string"/>
121125
<argument name="y" defaultValue="null" type="string"/>
122126
</arguments>
127+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
123128
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
124129
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
125130
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>
@@ -294,6 +299,7 @@
294299
</actionGroup>
295300
<actionGroup name="validateNoPinTooltip">
296301
<comment userInput="validateNoPinTooltip" stepKey="comment"/>
302+
<waitForElement selector="{{AddLocationForm.renderedMap}}" stepKey="waitForMapOnForm"/>
297303
<conditionalClick selector="{{AddLocationForm.googleModalOkButton('1')}}" dependentSelector="{{AddLocationForm.googleModalOkButton('1')}}" visible="true" stepKey="clickOkButton"/>
298304
<waitForElementNotVisible selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="waitForGoogleModalGone"/>
299305
<dontSeeElementInDOM selector="{{AddLocationForm.googleModalOkButton('1')}}" stepKey="dontSeeGoogleModalInDOM"/>

0 commit comments

Comments
 (0)