Skip to content

Commit c9b258f

Browse files
Merge branch 'develop' into PB-422
2 parents 20ed645 + dc3d35b commit c9b258f

File tree

3 files changed

+32
-7
lines changed

3 files changed

+32
-7
lines changed

app/code/Magento/PageBuilderAnalytics/Model/ContentTypeUsageReportProvider.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,13 @@ public function getReport($name) : \IteratorIterator
101101
foreach ($batchQuery->fetchAll() as $row) {
102102
foreach ($contentTypes as $type) {
103103
// Count the amount of content types within the content
104-
$typeCounts[$type['name']] += substr_count(
105-
$row['content'],
106-
'data-content-type="' . $type['name'] . '"'
107-
);
104+
$rowContent = $row['content'] ?? '';
105+
if (strlen($rowContent) > 0) {
106+
$typeCounts[$type['name']] += substr_count(
107+
$rowContent,
108+
'data-content-type="' . $type['name'] . '"'
109+
);
110+
}
108111
}
109112
}
110113
}

dev/tests/integration/_files/Magento/TestModuleCmsPageBuilderAnalytics/etc/reports.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
</using>
1717
</link-source>
1818
<filter glue="and">
19-
<condition attribute="identifier" operator="eq">page-builder-analytics-test-page</condition>
19+
<condition attribute="identifier" operator="like">page-builder-analytics-test-page%</condition>
2020
</filter>
2121
</source>
2222
</report>
@@ -30,8 +30,8 @@
3030
</using>
3131
</link-source>
3232
<filter glue="and">
33-
<condition attribute="identifier" operator="eq">page-builder-analytics-test-page</condition>
33+
<condition attribute="identifier" operator="like">page-builder-analytics-test-page%</condition>
3434
</filter>
3535
</source>
3636
</report>
37-
</config>
37+
</config>

dev/tests/integration/testsuite/Magento/CmsPageBuilderAnalytics/_files/pages.php

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,3 +390,25 @@
390390
->setContent($content)
391391
->setPageLayout('cms-full-width')
392392
->save();
393+
394+
/** @var $emptyContentPage \Magento\Cms\Model\Page */
395+
$emptyContentPage = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(\Magento\Cms\Model\Page::class);
396+
$emptyContentPage->setTitle('Page Builder Analytics Test Page - Empty Content')
397+
->setIdentifier('page-builder-analytics-test-page-empty')
398+
->setStores([0, 1])
399+
->setIsActive(1)
400+
->setCreatedIn(1)
401+
->setContent('')
402+
->setPageLayout('cms-full-width')
403+
->save();
404+
405+
/** @var $nullContentPage \Magento\Cms\Model\Page */
406+
$nullContentPage = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(\Magento\Cms\Model\Page::class);
407+
$nullContentPage->setTitle('Page Builder Analytics Test Page - Null Content')
408+
->setIdentifier('page-builder-analytics-test-page-null')
409+
->setStores([0, 1])
410+
->setIsActive(1)
411+
->setCreatedIn(1)
412+
->setContent(null)
413+
->setPageLayout('cms-full-width')
414+
->save();

0 commit comments

Comments
 (0)