Skip to content

Commit c77cb2d

Browse files
MC-3479: Remove Accordion
- remove unused classes and attributes and add comment to less file
1 parent ad38d52 commit c77cb2d

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/AccordionItem.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ public function render(array $itemData, array $additionalData = []) : string
4747
// data-role is not present on the accordion item as it's no longer it's own type
4848
$rootElementAttributes = [
4949
'data-collapsible' => 'true',
50-
'class' => 'item title accordion-collapsible',
51-
'data-open-on-load' => $eavData['open_on_load'] ? "1" : "0"
50+
'class' => 'item title'
5251
];
5352

5453
if (isset($itemData['formData'])) {
@@ -63,7 +62,7 @@ public function render(array $itemData, array $additionalData = []) : string
6362
$rootElementHtml .= $attributeValue !== '' ? " $attributeName=\"$attributeValue\"" : '';
6463
}
6564
$rootElementHtml .= '><div class="switch" data-role="trigger"><span>' . $eavData['title'] . '</span></div></div>'
66-
. '<div data-content="true" class="item content accordion-content">' . $eavData['textarea'] . '</div>';
65+
. '<div data-content="true" class="item content">' . $eavData['textarea'] . '</div>';
6766

6867
return $rootElementHtml;
6968
}

app/code/Magento/PageBuilder/view/frontend/web/css/source/_module.less

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@
3737
margin-bottom: 20px;
3838
}
3939

40+
//
41+
// styles for legacy content types
42+
// _____________________________________________
43+
4044
.pagebuilder-accordion {
4145
.lib-data-accordion();
4246
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="default"><div data-element="main" data-role="html" data-appearance="default"><div data-mage-init="{&quot;accordion&quot;:{&quot;active&quot;:[0],&quot;collapsibleElement&quot;:&quot;[data-collapsible=true]&quot;,&quot;content&quot;:&quot;[data-content=true]&quot;}}" class="pagebuilder-accordion one two"><div data-collapsible="true" class="item title accordion-collapsible" data-open-on-load="0"><div class="switch" data-role="trigger"><span>Accordion Title</span></div></div><div data-content="true" class="item content accordion-content"><p>Accordion Contents</p></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="default"><div data-element="main" data-role="html" data-appearance="default"><div data-mage-init="{&quot;accordion&quot;:{&quot;active&quot;:[0],&quot;collapsibleElement&quot;:&quot;[data-collapsible=true]&quot;,&quot;content&quot;:&quot;[data-content=true]&quot;}}" class="pagebuilder-accordion one two"><div data-collapsible="true" class="item title"><div class="switch" data-role="trigger"><span>Accordion Title</span></div></div><div data-content="true" class="item content"><p>Accordion Contents</p></div></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="default"><div data-element="main" data-role="html" data-appearance="default"><div data-mage-init="{&quot;accordion&quot;:{&quot;active&quot;:[1],&quot;collapsibleElement&quot;:&quot;[data-collapsible=true]&quot;,&quot;content&quot;:&quot;[data-content=true]&quot;}}" class="pagebuilder-accordion one two"><div data-collapsible="true" class="item title accordion-collapsible" data-open-on-load="0"><div class="switch" data-role="trigger"><span>Title 1</span></div></div><div data-content="true" class="item content accordion-content"><p>Content 1</p></div><div data-collapsible="true" class="item title accordion-collapsible" data-open-on-load="1"><div class="switch" data-role="trigger"><span>Title 2</span></div></div><div data-content="true" class="item content accordion-content"><p>Content 2</p></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="default"><div data-element="main" data-role="html" data-appearance="default"><div data-mage-init="{&quot;accordion&quot;:{&quot;active&quot;:[1],&quot;collapsibleElement&quot;:&quot;[data-collapsible=true]&quot;,&quot;content&quot;:&quot;[data-content=true]&quot;}}" class="pagebuilder-accordion one two"><div data-collapsible="true" class="item title"><div class="switch" data-role="trigger"><span>Title 1</span></div></div><div data-content="true" class="item content"><p>Content 1</p></div><div data-collapsible="true" class="item title"><div class="switch" data-role="trigger"><span>Title 2</span></div></div><div data-content="true" class="item content"><p>Content 2</p></div></div></div></div>

0 commit comments

Comments
 (0)