Skip to content

Commit c70a4a4

Browse files
cspruiellcspruiell
committed
PB-265: Video background for Banner
 - update tests
1 parent 1f1a258 commit c70a4a4

10 files changed

+458
-319
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/BackgroundConfigurationActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@
330330
</actionGroup>
331331
<actionGroup name="validateInvalidVideoBackgroundAndNoFallbackImage">
332332
<annotations>
333-
<description>Validates that the Row renders as an empty row when the video in video background fails to load and there is no fallback image.</description>
333+
<description>Validates that nothing renders when the video in video background fails to load and there is no fallback image.</description>
334334
</annotations>
335335
<arguments>
336336
<argument name="section" defaultValue="RowOnStage"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BackgroundFormData.xml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,19 @@
139139
<data key="value">invalid</data>
140140
<data key="errorMessage">Wrong color format. Please specify color in HEX, RGBa, HSVa, HSLa or use color name.</data>
141141
</entity>
142+
<!-- Background Type -->
143+
<entity name="PageBuilderBackgroundType_Image" type="pagebuilder_background_type_property">
144+
<data key="name">Background Type</data>
145+
<data key="section">background</data>
146+
<data key="fieldName">background_type</data>
147+
<data key="value">image</data>
148+
</entity>
149+
<entity name="PageBuilderBackgroundType_Video" type="pagebuilder_background_type_property">
150+
<data key="name">Background Type</data>
151+
<data key="section">background</data>
152+
<data key="fieldName">background_type</data>
153+
<data key="value">video</data>
154+
</entity>
142155
<!-- Background Image -->
143156
<entity name="PageBuilderBackgroundImage_Default" type="pagebuilder_background_image_property">
144157
<data key="name">Background Image</data>
@@ -580,7 +593,7 @@
580593
<data key="section">background</data>
581594
<data key="fieldName">video_fallback_image</data>
582595
<data key="value"/>
583-
<data key="helperText">Maximum file size: 4 MB. Allowed file types: JPG, GIF, PNG.</data>
596+
<data key="helperText">Maximum file size: 2 MB. Allowed file types: JPG, GIF, PNG.</data>
584597
<data key="tooltipText">Fallback images appear on the screen before a video loads. When the video loads, it replaces the fallback image. If the video does not load for some reason, the fallback image remains on the screen in place of the video.</data>
585598
</entity>
586599
<entity name="PageBuilderVideoBackgroundFallbackImage_JPG" type="pagebuilder_video_background_fallback_image">

‎app/code/Magento/PageBuilder/Test/Mftf/Data/BannerData.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,6 @@
8989
<data key="fieldName">background_color</data>
9090
<data key="stageValue">rgb(250, 250, 250)</data>
9191
</entity>
92-
<!-- Background Type -->
93-
<entity name="PageBuilderBannerBackgroundType_Image" type="pagebuilder_banner_background_type_property">
94-
<data key="name">Background Type</data>
95-
<data key="section">background</data>
96-
<data key="fieldName">background_type</data>
97-
<data key="value">image</data>
98-
</entity>
99-
<entity name="PageBuilderBannerBackgroundType_Video" type="pagebuilder_banner_background_type_property">
100-
<data key="name">Background Type</data>
101-
<data key="section">background</data>
102-
<data key="fieldName">background_type</data>
103-
<data key="value">video</data>
104-
</entity>
10592
<!-- Link -->
10693
<entity name="PageBuilderBannerLinkUrlProperty" type="pagebuilder_banner_linkUrl_property">
10794
<data key="name">Link</data>

‎app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderBannerSection.xml

Lines changed: 24 additions & 24 deletions
Large diffs are not rendered by default.

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1393,7 +1393,7 @@
13931393
<stories value="Banner"/>
13941394
<title value="Validate Video Background in Banner with Collage Center Appearance"/>
13951395
<description value="Set all video background attributes for a banner with collage center appearance and validate on stage and storefront."/>
1396-
<severity value="CRITICAL"/>
1396+
<severity value="BLOCKER"/>
13971397
<useCaseId value="PB-265"/>
13981398
<testCaseId value="MC-31621"/>
13991399
<group value="pagebuilder"/>
@@ -1413,7 +1413,7 @@
14131413
<stories value="Banner"/>
14141414
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Banner with Collage Center Appearance"/>
14151415
<description value="Set video background fallback image for a banner with collage center appearance and validate on stage and storefront."/>
1416-
<severity value="CRITICAL"/>
1416+
<severity value="BLOCKER"/>
14171417
<useCaseId value="PB-265"/>
14181418
<testCaseId value="MC-31629"/>
14191419
<group value="pagebuilder"/>
@@ -1433,7 +1433,7 @@
14331433
<stories value="Banner"/>
14341434
<title value="Validate Banner with Collage Center Appearance Renders When Video Isn't Loaded and There's No Fallback Image "/>
14351435
<description value="Validate that a banner with collage center appearance renders correctly when the video background video hasn't loaded and there is no fallback image."/>
1436-
<severity value="CRITICAL"/>
1436+
<severity value="BLOCKER"/>
14371437
<useCaseId value="PB-265"/>
14381438
<testCaseId value="MC-31635"/>
14391439
<group value="pagebuilder"/>
@@ -1453,7 +1453,7 @@
14531453
<stories value="Banner"/>
14541454
<title value="Validate Banner with Collage Center Appearance with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
14551455
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
1456-
<severity value="MAJOR"/>
1456+
<severity value="BLOCKER"/>
14571457
<useCaseId value="PB-265"/>
14581458
<testCaseId value="MC-31666"/>
14591459
<group value="pagebuilder"/>
@@ -1467,25 +1467,4 @@
14671467
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
14681468
</actionGroup>
14691469
</test>
1470-
<test name="BlockRenderBannerCollageCenterAppearanceWithVideoBackgroundThroughBlockContentType" extends="BlockRenderBannerPosterAppearanceWithVideoBackgroundThroughBlockContentType">
1471-
<annotations>
1472-
<features value="PageBuilder"/>
1473-
<stories value="Block Content"/>
1474-
<title value="Render Banner Collage Center Appearance with Video Background Through Block Content Type"/>
1475-
<description value="Verify that users are able to successfully render the banner content type collage center appearance with a video background through the Block content type."/>
1476-
<severity value="CRITICAL"/>
1477-
<useCaseId value="PB-265"/>
1478-
<testCaseId value="MC-31688"/>
1479-
<group value="pagebuilder"/>
1480-
<group value="pagebuilder-block"/>
1481-
<group value="pagebuilder-block-content"/>
1482-
<group value="pagebuilder-banner"/>
1483-
<group value="pagebuilder-bannerCollageCenter"/>
1484-
<group value="pagebuilder-backgroundForm"/>
1485-
<group value="pagebuilder-video-background"/>
1486-
</annotations>
1487-
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
1488-
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
1489-
</actionGroup>
1490-
</test>
14911470
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,7 +1396,7 @@
13961396
<stories value="Banner"/>
13971397
<title value="Validate Video Background in Banner with Collage Left Appearance"/>
13981398
<description value="Set all video background attributes for a banner with collage left appearance and validate on stage and storefront."/>
1399-
<severity value="CRITICAL"/>
1399+
<severity value="BLOCKER"/>
14001400
<useCaseId value="PB-265"/>
14011401
<testCaseId value="MC-31620"/>
14021402
<group value="pagebuilder"/>
@@ -1416,7 +1416,7 @@
14161416
<stories value="Banner"/>
14171417
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Banner with Collage Left Appearance"/>
14181418
<description value="Set video background fallback image for a banner with collage left appearance and validate on stage and storefront."/>
1419-
<severity value="CRITICAL"/>
1419+
<severity value="BLOCKER"/>
14201420
<useCaseId value="PB-265"/>
14211421
<testCaseId value="MC-31628"/>
14221422
<group value="pagebuilder"/>
@@ -1436,7 +1436,7 @@
14361436
<stories value="Banner"/>
14371437
<title value="Validate Banner with Collage Left Appearance Renders When Video Isn't Loaded and There's No Fallback Image "/>
14381438
<description value="Validate that a banner with collage left appearance renders correctly when the video background video hasn't loaded and there is no fallback image."/>
1439-
<severity value="CRITICAL"/>
1439+
<severity value="BLOCKER"/>
14401440
<useCaseId value="PB-265"/>
14411441
<testCaseId value="MC-31634"/>
14421442
<group value="pagebuilder"/>
@@ -1456,7 +1456,7 @@
14561456
<stories value="Banner"/>
14571457
<title value="Validate Banner with Collage Left Appearance with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
14581458
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
1459-
<severity value="MAJOR"/>
1459+
<severity value="BLOCKER"/>
14601460
<useCaseId value="PB-265"/>
14611461
<testCaseId value="MC-31665"/>
14621462
<group value="pagebuilder"/>
@@ -1470,25 +1470,4 @@
14701470
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
14711471
</actionGroup>
14721472
</test>
1473-
<test name="BlockRenderBannerCollageLeftAppearanceWithVideoBackgroundThroughBlockContentType" extends="BlockRenderBannerPosterAppearanceWithVideoBackgroundThroughBlockContentType">
1474-
<annotations>
1475-
<features value="PageBuilder"/>
1476-
<stories value="Block Content"/>
1477-
<title value="Render Banner Collage Left Appearance with Video Background Through Block Content Type"/>
1478-
<description value="Verify that users are able to successfully render the banner content type collage left appearance with a video background through the Block content type."/>
1479-
<severity value="CRITICAL"/>
1480-
<useCaseId value="PB-265"/>
1481-
<testCaseId value="MC-31687"/>
1482-
<group value="pagebuilder"/>
1483-
<group value="pagebuilder-block"/>
1484-
<group value="pagebuilder-block-content"/>
1485-
<group value="pagebuilder-banner"/>
1486-
<group value="pagebuilder-bannerCollageLeft"/>
1487-
<group value="pagebuilder-backgroundForm"/>
1488-
<group value="pagebuilder-video-background"/>
1489-
</annotations>
1490-
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
1491-
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
1492-
</actionGroup>
1493-
</test>
14941473
</tests>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1297,7 +1297,7 @@
12971297
<stories value="Banner"/>
12981298
<title value="Validate Video Background in Banner with Collage Right Appearance"/>
12991299
<description value="Set all video background attributes for a banner with collage right appearance and validate on stage and storefront."/>
1300-
<severity value="CRITICAL"/>
1300+
<severity value="BLOCKER"/>
13011301
<useCaseId value="PB-265"/>
13021302
<testCaseId value="MC-31622"/>
13031303
<group value="pagebuilder"/>
@@ -1317,7 +1317,7 @@
13171317
<stories value="Banner"/>
13181318
<title value="Validate Video Background Fallback Image Renders When Video Isn't Loaded in Banner with Collage Right Appearance"/>
13191319
<description value="Set video background fallback image for a banner with collage right appearance and validate on stage and storefront."/>
1320-
<severity value="CRITICAL"/>
1320+
<severity value="BLOCKER"/>
13211321
<useCaseId value="PB-265"/>
13221322
<testCaseId value="MC-31630"/>
13231323
<group value="pagebuilder"/>
@@ -1337,12 +1337,12 @@
13371337
<stories value="Banner"/>
13381338
<title value="Validate Banner with Collage Right Appearance Renders When Video Isn't Loaded and There's No Fallback Image "/>
13391339
<description value="Validate that a banner with collage right appearance renders correctly when the video background video hasn't loaded and there is no fallback image."/>
1340-
<severity value="CRITICAL"/>
1340+
<severity value="BLOCKER"/>
13411341
<useCaseId value="PB-265"/>
13421342
<testCaseId value="MC-31636"/>
13431343
<group value="pagebuilder"/>
13441344
<group value="pagebuilder-banner"/>
1345-
<group value="pagebuilder-bannerCollageCenter"/>
1345+
<group value="pagebuilder-bannerCollageRight"/>
13461346
<group value="pagebuilder-backgroundForm"/>
13471347
<group value="pagebuilder-video-background"/>
13481348
</annotations>
@@ -1357,7 +1357,7 @@
13571357
<stories value="Banner"/>
13581358
<title value="Validate Banner with Collage Right Appearance with No Fallback Image, Disabled Infinite Loop, Disabled Play Only When Visible, and Disabled Lazy Load"/>
13591359
<description value="Validate video background with no fallback image, disabled infinite loop, disabled play only when visible, and disabled lazy load."/>
1360-
<severity value="MAJOR"/>
1360+
<severity value="BLOCKER"/>
13611361
<useCaseId value="PB-265"/>
13621362
<testCaseId value="MC-31667"/>
13631363
<group value="pagebuilder"/>
@@ -1371,25 +1371,4 @@
13711371
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
13721372
</actionGroup>
13731373
</test>
1374-
<test name="BlockRenderBannerCollageRightAppearanceWithVideoBackgroundThroughBlockContentType" extends="BlockRenderBannerPosterAppearanceWithVideoBackgroundThroughBlockContentType">
1375-
<annotations>
1376-
<features value="PageBuilder"/>
1377-
<stories value="Block Content"/>
1378-
<title value="Render Banner Collage Right Appearance with Video Background Through Block Content Type"/>
1379-
<description value="Verify that users are able to successfully render the banner content type collage right appearance with a video background through the Block content type."/>
1380-
<severity value="CRITICAL"/>
1381-
<useCaseId value="PB-265"/>
1382-
<testCaseId value="MC-31687"/>
1383-
<group value="pagebuilder"/>
1384-
<group value="pagebuilder-block"/>
1385-
<group value="pagebuilder-block-content"/>
1386-
<group value="pagebuilder-banner"/>
1387-
<group value="pagebuilder-bannerCollageRight"/>
1388-
<group value="pagebuilder-backgroundForm"/>
1389-
<group value="pagebuilder-video-background"/>
1390-
</annotations>
1391-
<actionGroup ref="chooseVisualSelectOption" stepKey="setAppearance">
1392-
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
1393-
</actionGroup>
1394-
</test>
13951374
</tests>

0 commit comments

Comments
 (0)