Skip to content

Commit c4fb765

Browse files
cspruiellcspruiell
committed
MC-5372: Collage Center/Left/Right doesn't work correct in a container smaller than 100% width
 - update test annotations and use more general selectors
1 parent 983bba1 commit c4fb765

8 files changed

+35
-35
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageCenterAppearanceTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,17 +1351,17 @@
13511351
<annotations>
13521352
<features value="PageBuilder"/>
13531353
<stories value="Banner"/>
1354-
<title value="Banner Overlay and Button do not go outside container on collage center appearance"/>
1355-
<description value="User should be able to place a banner inside a narrow column without the contents spilling outside of the column."/>
1356-
<severity value="AVERAGE"/>
1354+
<title value="Collage Center - Banner Overlay and Button do not go outside container on collage center appearance"/>
1355+
<description value="User should be able to place a banner with Collage Center appearance inside a narrow column without the contents spilling outside of the column."/>
1356+
<severity value="MAJOR"/>
13571357
<useCaseId value="MC-5372"/>
1358-
<testCaseId value="MC-5818"/>
1358+
<testCaseId value="MC-5933"/>
13591359
<group value="pagebuilder"/>
13601360
<group value="pagebuilder-banner"/>
13611361
<group value="pagebuilder-bannerCollageCenter"/>
13621362
</annotations>
13631363
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1364-
<argument name="property" value="PageBuilderBannerCollageCenteredProperty"/>
1364+
<argument name="property" value="PageBuilderAppearance_CollageCentered"/>
13651365
</actionGroup>
13661366
<actionGroup ref="validateOverlayAndButtonCollage" stepKey="validateBannerOnStage">
13671367
<argument name="column" value="ColumnOnBackend"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageLeftAppearanceTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,17 +1344,17 @@
13441344
<annotations>
13451345
<features value="PageBuilder"/>
13461346
<stories value="Banner"/>
1347-
<title value="Banner Overlay and Button do not go outside container on collage left appearance"/>
1348-
<description value="User should be able to place a banner inside a narrow column without the contents spilling outside of the column."/>
1349-
<severity value="AVERAGE"/>
1347+
<title value="Collage Left - Banner Overlay and Button do not go outside container on collage left appearance"/>
1348+
<description value="User should be able to place a banner with Collage Left appearance inside a narrow column without the contents spilling outside of the column."/>
1349+
<severity value="MAJOR"/>
13501350
<useCaseId value="MC-5372"/>
13511351
<testCaseId value="MC-5818"/>
13521352
<group value="pagebuilder"/>
13531353
<group value="pagebuilder-banner"/>
13541354
<group value="pagebuilder-bannerCollageLeft"/>
13551355
</annotations>
13561356
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1357-
<argument name="property" value="PageBuilderBannerCollageLeftProperty"/>
1357+
<argument name="property" value="PageBuilderAppearance_CollageLeft"/>
13581358
</actionGroup>
13591359
<actionGroup ref="validateOverlayAndButtonCollage" stepKey="validateBannerOnStage">
13601360
<argument name="column" value="ColumnOnBackend"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerCollageRightAppearanceTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,17 +1255,17 @@
12551255
<annotations>
12561256
<features value="PageBuilder"/>
12571257
<stories value="Banner"/>
1258-
<title value="Banner Overlay and Button do not go outside container on collage right appearance"/>
1259-
<description value="User should be able to place a banner inside a narrow column without the contents spilling outside of the column."/>
1260-
<severity value="AVERAGE"/>
1258+
<title value="Collage Right - Banner Overlay and Button do not go outside container on collage right appearance"/>
1259+
<description value="User should be able to place a banner with Collage Right appearance inside a narrow column without the contents spilling outside of the column."/>
1260+
<severity value="MAJOR"/>
12611261
<useCaseId value="MC-5372"/>
1262-
<testCaseId value="MC-5818"/>
1262+
<testCaseId value="MC-5934"/>
12631263
<group value="pagebuilder"/>
12641264
<group value="pagebuilder-banner"/>
12651265
<group value="pagebuilder-bannerCollageRight"/>
12661266
</annotations>
12671267
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1268-
<argument name="property" value="PageBuilderBannerCollageRightProperty"/>
1268+
<argument name="property" value="PageBuilderAppearance_CollageRight"/>
12691269
</actionGroup>
12701270
<actionGroup ref="validateOverlayAndButtonCollage" stepKey="validateBannerOnStage">
12711271
<argument name="column" value="ColumnOnBackend"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBannerPosterAppearanceTest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1762,11 +1762,11 @@
17621762
<annotations>
17631763
<features value="PageBuilder"/>
17641764
<stories value="Banner"/>
1765-
<title value="Banner Overlay and Button do not go outside container on poster appearance"/>
1766-
<description value="User should be able to place a banner inside a narrow column without the contents spilling outside of the column."/>
1767-
<severity value="AVERAGE"/>
1765+
<title value="Poster - Banner Overlay and Button do not go outside container on poster appearance"/>
1766+
<description value="User should be able to place a banner with Poster appearance inside a narrow column without the contents spilling outside of the column."/>
1767+
<severity value="MAJOR"/>
17681768
<useCaseId value="MC-5372"/>
1769-
<testCaseId value="MC-5818"/>
1769+
<testCaseId value="MC-5935"/>
17701770
<group value="pagebuilder"/>
17711771
<group value="pagebuilder-banner"/>
17721772
<group value="pagebuilder-bannerPoster"/>
@@ -1808,7 +1808,7 @@
18081808
<!-- Fill Out Edit Panel -->
18091809
<comment userInput="Fill Out Edit Panel" stepKey="commentFillEditPanel"/>
18101810
<actionGroup ref="chooseVisualSelectOption" stepKey="enterAppearanceProperty">
1811-
<argument name="property" value="PageBuilderBannerAppearance_Poster"/>
1811+
<argument name="property" value="PageBuilderAppearance_Poster"/>
18121812
</actionGroup>
18131813
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBackgroundColor">
18141814
<argument name="property" value="PageBuilderBackgroundColor_RGB_Blue"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageCenterTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -657,11 +657,11 @@
657657
<annotations>
658658
<features value="PageBuilder"/>
659659
<stories value="Slider"/>
660-
<title value="Slide Overlay and Button do not go outside container on collage center appearance"/>
661-
<description value="User should be able to place a slider inside a narrow column without the contents spilling outside of the column."/>
662-
<severity value="AVERAGE"/>
660+
<title value="Collage Center - Slide Overlay and Button do not go outside container on collage center appearance"/>
661+
<description value="User should be able to place a slide with Collage Center appearance inside a narrow column without the contents spilling outside of the column."/>
662+
<severity value="MAJOR"/>
663663
<useCaseId value="MC-5372"/>
664-
<testCaseId value="MC-5818"/>
664+
<testCaseId value="MC-5937"/>
665665
<group value="pagebuilder"/>
666666
<group value="pagebuilder-slider"/>
667667
<group value="pagebuilder-sliderCollageCenter"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageLeftTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -540,11 +540,11 @@
540540
<annotations>
541541
<features value="PageBuilder"/>
542542
<stories value="Slider"/>
543-
<title value="Slide Overlay and Button do not go outside container on collage left appearance"/>
544-
<description value="User should be able to place a slider inside a narrow column without the contents spilling outside of the column."/>
545-
<severity value="AVERAGE"/>
543+
<title value="Collage Left - Slide Overlay and Button do not go outside container on collage left appearance"/>
544+
<description value="User should be able to place a slide with Collage Left appearance inside a narrow column without the contents spilling outside of the column."/>
545+
<severity value="MAJOR"/>
546546
<useCaseId value="MC-5372"/>
547-
<testCaseId value="MC-5818"/>
547+
<testCaseId value="MC-5936"/>
548548
<group value="pagebuilder"/>
549549
<group value="pagebuilder-slider"/>
550550
<group value="pagebuilder-sliderCollageLeft"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearanceCollageRightTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -431,11 +431,11 @@
431431
<annotations>
432432
<features value="PageBuilder"/>
433433
<stories value="Slider"/>
434-
<title value="Slide Overlay and Button do not go outside container on collage right appearance"/>
435-
<description value="User should be able to place a slider inside a narrow column without the contents spilling outside of the column."/>
436-
<severity value="AVERAGE"/>
434+
<title value="Collage Right - Slide Overlay and Button do not go outside container on collage right appearance"/>
435+
<description value="User should be able to place a slide with Collage Right appearance inside a narrow column without the contents spilling outside of the column."/>
436+
<severity value="MAJOR"/>
437437
<useCaseId value="MC-5372"/>
438-
<testCaseId value="MC-5818"/>
438+
<testCaseId value="MC-5938"/>
439439
<group value="pagebuilder"/>
440440
<group value="pagebuilder-slider"/>
441441
<group value="pagebuilder-sliderCollageRight"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideItemAppearancePosterTests.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1483,11 +1483,11 @@
14831483
<annotations>
14841484
<features value="PageBuilder"/>
14851485
<stories value="Slider"/>
1486-
<title value="Slide Overlay and Button do not go outside container on poster appearance"/>
1487-
<description value="User should be able to place a slider inside a narrow column without the contents spilling outside of the column."/>
1488-
<severity value="AVERAGE"/>
1486+
<title value="Poster - Slide Overlay and Button do not go outside container on poster appearance"/>
1487+
<description value="User should be able to place a slide with Poster appearance inside a narrow column without the contents spilling outside of the column."/>
1488+
<severity value="MAJOR"/>
14891489
<useCaseId value="MC-5372"/>
1490-
<testCaseId value="MC-5818"/>
1490+
<testCaseId value="MC-5939"/>
14911491
<group value="pagebuilder"/>
14921492
<group value="pagebuilder-slider"/>
14931493
<group value="pagebuilder-sliderPoster"/>

0 commit comments

Comments
 (0)